| Message ID | 1350287477-30936-1-git-send-email-voice.shen@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/15/2012 01:51 AM, Bo Shen wrote: > When i2c-gpio node number is greater than 1, the name for each is same > So add the patch to fix it. > > The adap->name printing information is add by myself > > without this patch the log information is as following > ---<8--- > adap->name = i2c-gpio-1 > i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) > adap->name = i2c-gpio-1 > i2c-gpio i2c.3: using pins 64 (SDA) and 65 (SCL) > --->8--- > > with this patch, the log information is as following > ---<8--- > adap->name = i2c.2 > i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) > adap->name = i2c.3 > i2c-gpio i2c.3: using pins 64 (SDA) and 65 (SCL) > --->8--- I think this is reasonable, although I imagine this has zero effect on the I2C bus number that's assigned to the device, so I'm not sure how it interacts with or supports the other Atmel patch series you sent, which I didn't really look at in much detail. Reviewed-by: Stephen Warren <swarren@nvidia.com>
On Mon, Oct 15, 2012 at 03:51:17PM +0800, Bo Shen wrote: > When i2c-gpio node number is greater than 1, the name for each is same > So add the patch to fix it. > > The adap->name printing information is add by myself > > without this patch the log information is as following > ---<8--- > adap->name = i2c-gpio-1 > i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) > adap->name = i2c-gpio-1 > i2c-gpio i2c.3: using pins 64 (SDA) and 65 (SCL) > --->8--- > > with this patch, the log information is as following > ---<8--- > adap->name = i2c.2 > i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) > adap->name = i2c.3 > i2c-gpio i2c.3: using pins 64 (SDA) and 65 (SCL) > --->8--- > > Signed-off-by: Bo Shen <voice.shen@atmel.com> Applied to for-next, thanks.
diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c index e62d2d9..257299a 100644 --- a/drivers/i2c/busses/i2c-gpio.c +++ b/drivers/i2c/busses/i2c-gpio.c @@ -184,7 +184,11 @@ static int __devinit i2c_gpio_probe(struct platform_device *pdev) bit_data->data = pdata; adap->owner = THIS_MODULE; - snprintf(adap->name, sizeof(adap->name), "i2c-gpio%d", pdev->id); + if (pdev->dev.of_node) + strlcpy(adap->name, dev_name(&pdev->dev), sizeof(adap->name)); + else + snprintf(adap->name, sizeof(adap->name), "i2c-gpio%d", pdev->id); + adap->algo_data = bit_data; adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD; adap->dev.parent = &pdev->dev;
When i2c-gpio node number is greater than 1, the name for each is same So add the patch to fix it. The adap->name printing information is add by myself without this patch the log information is as following ---<8--- adap->name = i2c-gpio-1 i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) adap->name = i2c-gpio-1 i2c-gpio i2c.3: using pins 64 (SDA) and 65 (SCL) --->8--- with this patch, the log information is as following ---<8--- adap->name = i2c.2 i2c-gpio i2c.2: using pins 30 (SDA) and 31 (SCL) adap->name = i2c.3 i2c-gpio i2c.3: using pins 64 (SDA) and 65 (SCL) --->8--- Signed-off-by: Bo Shen <voice.shen@atmel.com> --- drivers/i2c/busses/i2c-gpio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)