diff mbox

[1/2] ARM: dts: OMAP: Add counter-32k nodes

Message ID 1350498803-22150-2-git-send-email-jon-hunter@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hunter, Jon Oct. 17, 2012, 6:33 p.m. UTC
Adds the counter-32k timers nodes present in OMAP2/3/4 devices and
device-tree binding documentation for OMAP counter-32k.

Signed-off-by: Jon Hunter <jon-hunter@ti.com>
---
 .../devicetree/bindings/arm/omap/counter32k.txt    |   15 +++++++++++++++
 arch/arm/boot/dts/omap2420.dtsi                    |    6 ++++++
 arch/arm/boot/dts/omap2430.dtsi                    |    6 ++++++
 arch/arm/boot/dts/omap3.dtsi                       |    6 ++++++
 arch/arm/boot/dts/omap4.dtsi                       |    6 ++++++
 5 files changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/omap/counter32k.txt

Comments

Benoit Cousson Oct. 18, 2012, 2:23 p.m. UTC | #1
Hi Jon,

This looks good to me, I just have a minor nit comment.

On 10/17/2012 08:33 PM, Jon Hunter wrote:
> Adds the counter-32k timers nodes present in OMAP2/3/4 devices and
> device-tree binding documentation for OMAP counter-32k.
> 
> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
> ---
>  .../devicetree/bindings/arm/omap/counter32k.txt    |   15 +++++++++++++++
>  arch/arm/boot/dts/omap2420.dtsi                    |    6 ++++++
>  arch/arm/boot/dts/omap2430.dtsi                    |    6 ++++++
>  arch/arm/boot/dts/omap3.dtsi                       |    6 ++++++
>  arch/arm/boot/dts/omap4.dtsi                       |    6 ++++++
>  5 files changed, 39 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/omap/counter32k.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/counter32k.txt b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
> new file mode 100644
> index 0000000..1983fae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
> @@ -0,0 +1,15 @@
> +OMAP Counter-32K bindings
> +
> +Required properties:
> +- compatible:	Must be "ti,omap-counter32k" for OMAP controllers
> +- reg:		Contains timer register address range (base address and length)
> +- ti,hwmods:	Name of the hwmod associated to the counter, which is typically
> +		"counter_32k"
> +
> +Example:
> +
> +counter32k: counter32k@4a304000 {
> +	compatible = "ti,omap-counter32k";
> +	reg = <0x4a304000 0x001f>;
> +	ti,hwmods = "counter_32k";
> +};
> diff --git a/arch/arm/boot/dts/omap2420.dtsi b/arch/arm/boot/dts/omap2420.dtsi
> index 5f68a70..082193f 100644
> --- a/arch/arm/boot/dts/omap2420.dtsi
> +++ b/arch/arm/boot/dts/omap2420.dtsi
> @@ -14,6 +14,12 @@
>  	compatible = "ti,omap2420", "ti,omap2";
>  
>  	ocp {
> +		counter32k: counter32k@48004000 {

I'd rather use "counter" as generic type to be consistent with the timer
type we are already using.

+		counter32k: counter@48004000 {

Regards,
Benoit
Hunter, Jon Oct. 18, 2012, 2:27 p.m. UTC | #2
On 10/18/2012 09:23 AM, Benoit Cousson wrote:
> Hi Jon,
> 
> This looks good to me, I just have a minor nit comment.
> 
> On 10/17/2012 08:33 PM, Jon Hunter wrote:
>> Adds the counter-32k timers nodes present in OMAP2/3/4 devices and
>> device-tree binding documentation for OMAP counter-32k.
>>
>> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
>> ---
>>  .../devicetree/bindings/arm/omap/counter32k.txt    |   15 +++++++++++++++
>>  arch/arm/boot/dts/omap2420.dtsi                    |    6 ++++++
>>  arch/arm/boot/dts/omap2430.dtsi                    |    6 ++++++
>>  arch/arm/boot/dts/omap3.dtsi                       |    6 ++++++
>>  arch/arm/boot/dts/omap4.dtsi                       |    6 ++++++
>>  5 files changed, 39 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/arm/omap/counter32k.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/counter32k.txt b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
>> new file mode 100644
>> index 0000000..1983fae
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
>> @@ -0,0 +1,15 @@
>> +OMAP Counter-32K bindings
>> +
>> +Required properties:
>> +- compatible:	Must be "ti,omap-counter32k" for OMAP controllers
>> +- reg:		Contains timer register address range (base address and length)
>> +- ti,hwmods:	Name of the hwmod associated to the counter, which is typically
>> +		"counter_32k"
>> +
>> +Example:
>> +
>> +counter32k: counter32k@4a304000 {
>> +	compatible = "ti,omap-counter32k";
>> +	reg = <0x4a304000 0x001f>;
>> +	ti,hwmods = "counter_32k";
>> +};
>> diff --git a/arch/arm/boot/dts/omap2420.dtsi b/arch/arm/boot/dts/omap2420.dtsi
>> index 5f68a70..082193f 100644
>> --- a/arch/arm/boot/dts/omap2420.dtsi
>> +++ b/arch/arm/boot/dts/omap2420.dtsi
>> @@ -14,6 +14,12 @@
>>  	compatible = "ti,omap2420", "ti,omap2";
>>  
>>  	ocp {
>> +		counter32k: counter32k@48004000 {
> 
> I'd rather use "counter" as generic type to be consistent with the timer
> type we are already using.
> 
> +		counter32k: counter@48004000 {

Sounds good. Will update.

Cheers
Jon
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/omap/counter32k.txt b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
new file mode 100644
index 0000000..1983fae
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
@@ -0,0 +1,15 @@ 
+OMAP Counter-32K bindings
+
+Required properties:
+- compatible:	Must be "ti,omap-counter32k" for OMAP controllers
+- reg:		Contains timer register address range (base address and length)
+- ti,hwmods:	Name of the hwmod associated to the counter, which is typically
+		"counter_32k"
+
+Example:
+
+counter32k: counter32k@4a304000 {
+	compatible = "ti,omap-counter32k";
+	reg = <0x4a304000 0x001f>;
+	ti,hwmods = "counter_32k";
+};
diff --git a/arch/arm/boot/dts/omap2420.dtsi b/arch/arm/boot/dts/omap2420.dtsi
index 5f68a70..082193f 100644
--- a/arch/arm/boot/dts/omap2420.dtsi
+++ b/arch/arm/boot/dts/omap2420.dtsi
@@ -14,6 +14,12 @@ 
 	compatible = "ti,omap2420", "ti,omap2";
 
 	ocp {
+		counter32k: counter32k@48004000 {
+			compatible = "ti,omap-counter32k";
+			reg = <0x48004000 0x001f>;
+			ti,hwmods = "counter_32k";
+		};
+
 		omap2420_pmx: pinmux@48000030 {
 			compatible = "ti,omap2420-padconf", "pinctrl-single";
 			reg = <0x48000030 0x0113>;
diff --git a/arch/arm/boot/dts/omap2430.dtsi b/arch/arm/boot/dts/omap2430.dtsi
index 7439987..2e568cf 100644
--- a/arch/arm/boot/dts/omap2430.dtsi
+++ b/arch/arm/boot/dts/omap2430.dtsi
@@ -14,6 +14,12 @@ 
 	compatible = "ti,omap2430", "ti,omap2";
 
 	ocp {
+		counter32k: counter32k@49020000 {
+			compatible = "ti,omap-counter32k";
+			reg = <0x49020000 0x001f>;
+			ti,hwmods = "counter_32k";
+		};
+
 		omap2430_pmx: pinmux@49002030 {
 			compatible = "ti,omap2430-padconf", "pinctrl-single";
 			reg = <0x49002030 0x0154>;
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index 3fb910f..aa775b2 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -61,6 +61,12 @@ 
 		ranges;
 		ti,hwmods = "l3_main";
 
+		counter32k: counter32k@48320000 {
+			compatible = "ti,omap-counter32k";
+			reg = <0x48320000 0x001f>;
+			ti,hwmods = "counter_32k";
+		};
+
 		intc: interrupt-controller@48200000 {
 			compatible = "ti,omap2-intc";
 			interrupt-controller;
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index f6ac2b7..3eb66ee 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -95,6 +95,12 @@ 
 		ranges;
 		ti,hwmods = "l3_main_1", "l3_main_2", "l3_main_3";
 
+		counter32k: counter32k@4a304000 {
+			compatible = "ti,omap-counter32k";
+			reg = <0x4a304000 0x001f>;
+			ti,hwmods = "counter_32k";
+		};
+
 		omap4_pmx_core: pinmux@4a100040 {
 			compatible = "ti,omap4-padconf", "pinctrl-single";
 			reg = <0x4a100040 0x0196>;