| Message ID | 1350829392-3812-2-git-send-email-manabian@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 16:23 Sun 21 Oct , Joachim Eastwood wrote: > macb is a platform driver and there is nothing that prevents > this driver from being built on non-ARM/AVR32 platforms. if you want to drop the HAVE_NET_MACB you need to drop it everywher in one patch Best Regards, J. > > Signed-off-by: Joachim Eastwood <manabian@gmail.com> > --- > drivers/net/ethernet/cadence/Kconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig > index 57f78abe..5d1ea30 100644 > --- a/drivers/net/ethernet/cadence/Kconfig > +++ b/drivers/net/ethernet/cadence/Kconfig > @@ -2,13 +2,9 @@ > # Atmel device configuration > # > > -config HAVE_NET_MACB > - bool > - > config NET_CADENCE > bool "Cadence devices" > default y > - depends on HAVE_NET_MACB || (ARM && ARCH_AT91RM9200) > ---help--- > If you have a network (Ethernet) card belonging to this class, say Y. > Make sure you know the name of your card. Read the Ethernet-HOWTO, > @@ -34,7 +30,6 @@ config ARM_AT91_ETHER > > config MACB > tristate "Cadence MACB/GEM support" > - depends on HAVE_NET_MACB > select PHYLIB > ---help--- > The Cadence MACB ethernet interface is found on many Atmel AT32 and > -- > 1.7.12.4 >
On Sun, Oct 21, 2012 at 8:30 PM, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> wrote: > On 16:23 Sun 21 Oct , Joachim Eastwood wrote: >> macb is a platform driver and there is nothing that prevents >> this driver from being built on non-ARM/AVR32 platforms. > if you want to drop the HAVE_NET_MACB you need to drop it everywher in one > patch Breaking it up in several patches doesn't seem to cause any build failures and I did this in case the patches were going into different git trees. regards Joachim Eastwood
You do know that this is going to generate warnings on 64-bit platforms? I was hoping you would have noticed and corrected this before enabling the driver everywhere, I guess my expectations were way too high :-/
On Mon, Oct 22, 2012 at 1:27 AM, David Miller <davem@davemloft.net> wrote: > > You do know that this is going to generate warnings on 64-bit > platforms? > > I was hoping you would have noticed and corrected this before > enabling the driver everywhere, I guess my expectations were > way too high :-/ ah, sorry. Yes, macb seem to generate some integer overflows on ~0UL on 64-bit. I have a patch that turns ~0UL into -1. I can repost the series with fix included. Do you want me to do that? regards Joachim Eastwood
From: Joachim Eastwood <manabian@gmail.com> Date: Mon, 22 Oct 2012 08:59:17 +0200 > On Mon, Oct 22, 2012 at 1:27 AM, David Miller <davem@davemloft.net> wrote: >> >> You do know that this is going to generate warnings on 64-bit >> platforms? >> >> I was hoping you would have noticed and corrected this before >> enabling the driver everywhere, I guess my expectations were >> way too high :-/ > > ah, sorry. > > Yes, macb seem to generate some integer overflows on ~0UL on 64-bit. I > have a patch that turns ~0UL into -1. > > I can repost the series with fix included. Do you want me to do that? Yes, please do. Thanks.
diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig index 57f78abe..5d1ea30 100644 --- a/drivers/net/ethernet/cadence/Kconfig +++ b/drivers/net/ethernet/cadence/Kconfig @@ -2,13 +2,9 @@ # Atmel device configuration # -config HAVE_NET_MACB - bool - config NET_CADENCE bool "Cadence devices" default y - depends on HAVE_NET_MACB || (ARM && ARCH_AT91RM9200) ---help--- If you have a network (Ethernet) card belonging to this class, say Y. Make sure you know the name of your card. Read the Ethernet-HOWTO, @@ -34,7 +30,6 @@ config ARM_AT91_ETHER config MACB tristate "Cadence MACB/GEM support" - depends on HAVE_NET_MACB select PHYLIB ---help--- The Cadence MACB ethernet interface is found on many Atmel AT32 and
macb is a platform driver and there is nothing that prevents this driver from being built on non-ARM/AVR32 platforms. Signed-off-by: Joachim Eastwood <manabian@gmail.com> --- drivers/net/ethernet/cadence/Kconfig | 5 ----- 1 file changed, 5 deletions(-)