| Message ID | 1351254650-26861-3-git-send-email-gregory.clement@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Oct 26, 2012 at 02:30:47PM +0200, Gregory CLEMENT wrote: > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > Signed-off-by: Lior Amsalem <alior@marvell.com> > --- > arch/arm/boot/dts/armada-370-xp.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi > index 94b4b9e..a911f7a 100644 > --- a/arch/arm/boot/dts/armada-370-xp.dtsi > +++ b/arch/arm/boot/dts/armada-370-xp.dtsi > @@ -69,6 +69,15 @@ > compatible = "marvell,armada-addr-decoding-controller"; > reg = <0xd0020000 0x258>; > }; > + > + sata@d00a0000 { > + compatible = "marvell,orion-sata"; > + reg = <0xd00a0000 0x2400>; > + interrupts = <55>; > + clocks = <&coreclk 0>; nit. whitespace? thx, Jason. > + status = "disabled"; > + }; > + > }; > }; > > -- > 1.7.9.5 >
On Fri, Oct 26, 2012 at 09:31:54AM -0400, Jason Cooper wrote: > On Fri, Oct 26, 2012 at 02:30:47PM +0200, Gregory CLEMENT wrote: > > Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > > Signed-off-by: Lior Amsalem <alior@marvell.com> > > --- > > arch/arm/boot/dts/armada-370-xp.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi > > index 94b4b9e..a911f7a 100644 > > --- a/arch/arm/boot/dts/armada-370-xp.dtsi > > +++ b/arch/arm/boot/dts/armada-370-xp.dtsi > > @@ -69,6 +69,15 @@ > > compatible = "marvell,armada-addr-decoding-controller"; > > reg = <0xd0020000 0x258>; > > }; > > + > > + sata@d00a0000 { > > + compatible = "marvell,orion-sata"; > > + reg = <0xd00a0000 0x2400>; > > + interrupts = <55>; > > + clocks = <&coreclk 0>; > > nit. whitespace? [Don't shoot the messenger] How about extending checkpatch to check for this? I guess its just spaces which should be tabs. Andrew
On 10/26/2012 03:34 PM, Andrew Lunn wrote: > On Fri, Oct 26, 2012 at 09:31:54AM -0400, Jason Cooper wrote: >> On Fri, Oct 26, 2012 at 02:30:47PM +0200, Gregory CLEMENT wrote: >>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> >>> Signed-off-by: Lior Amsalem <alior@marvell.com> >>> --- >>> arch/arm/boot/dts/armada-370-xp.dtsi | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi >>> index 94b4b9e..a911f7a 100644 >>> --- a/arch/arm/boot/dts/armada-370-xp.dtsi >>> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi >>> @@ -69,6 +69,15 @@ >>> compatible = "marvell,armada-addr-decoding-controller"; >>> reg = <0xd0020000 0x258>; >>> }; >>> + >>> + sata@d00a0000 { >>> + compatible = "marvell,orion-sata"; >>> + reg = <0xd00a0000 0x2400>; >>> + interrupts = <55>; >>> + clocks = <&coreclk 0>; >> >> nit. whitespace? > > [Don't shoot the messenger] > > How about extending checkpatch to check for this? I guess its just > spaces which should be tabs. No it is the opposite in fact! On this line it's tabs: 3 tabs of 8 whitespace, so the line start at 24. But as there is a '+', the first tab is only 7, so it is still start at 24. Whereas for the other lines it's 24 white spaces, so with the '+' it starts at 25. That's why I didn't notice it, and if you apply the patch all is fine. Now, about white spaces vs tab, I don't know what is the rule for .dts file. Gregory
> Now, about white spaces vs tab, I don't know what is the rule for .dts > file. I personally use tabs, but i don't see anything in the Documentation/CodingStyle. Maybe ask on the device tree mailing list? Andrew
On Fri, 26 Oct 2012 15:52:25 +0200, Andrew Lunn wrote: > > Now, about white spaces vs tab, I don't know what is the rule > > for .dts file. > > I personally use tabs, but i don't see anything in the > Documentation/CodingStyle. > > Maybe ask on the device tree mailing list? Yes, it would be good to know and document what is the rule for .dts files, and possibly extend checkpatch to cover those special rules for .dts files. Best regards, Thomas
On Fri, Oct 26, 2012 at 04:57:59PM +0200, Thomas Petazzoni wrote: > > On Fri, 26 Oct 2012 15:52:25 +0200, Andrew Lunn wrote: > > > Now, about white spaces vs tab, I don't know what is the rule > > > for .dts file. > > > > I personally use tabs, but i don't see anything in the > > Documentation/CodingStyle. > > > > Maybe ask on the device tree mailing list? > > Yes, it would be good to know and document what is the rule for .dts > files, and possibly extend checkpatch to cover those special rules > for .dts files. until that is resolved, can we make this patch conform to what is in the file currently? Once the dt folks clarify, we can run through all the dts's and submit one cleanup series. If there are no other comments on this series, I'm fine taking it as is and doing the fixup on my end. No need to do a version bump just for this. thx, Jason.
On 10/26/2012 05:02 PM, Jason Cooper wrote: > On Fri, Oct 26, 2012 at 04:57:59PM +0200, Thomas Petazzoni wrote: >> >> On Fri, 26 Oct 2012 15:52:25 +0200, Andrew Lunn wrote: >>>> Now, about white spaces vs tab, I don't know what is the rule >>>> for .dts file. >>> >>> I personally use tabs, but i don't see anything in the >>> Documentation/CodingStyle. >>> >>> Maybe ask on the device tree mailing list? >> >> Yes, it would be good to know and document what is the rule for .dts >> files, and possibly extend checkpatch to cover those special rules >> for .dts files. > > until that is resolved, can we make this patch conform to what is in the > file currently? Once the dt folks clarify, we can run through all the > dts's and submit one cleanup series. > > If there are no other comments on this series, I'm fine taking it as is > and doing the fixup on my end. No need to do a version bump just for > this. OK then you will just have to replace my tabs by whitespace. Thanks, Gregory
diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi index 94b4b9e..a911f7a 100644 --- a/arch/arm/boot/dts/armada-370-xp.dtsi +++ b/arch/arm/boot/dts/armada-370-xp.dtsi @@ -69,6 +69,15 @@ compatible = "marvell,armada-addr-decoding-controller"; reg = <0xd0020000 0x258>; }; + + sata@d00a0000 { + compatible = "marvell,orion-sata"; + reg = <0xd00a0000 0x2400>; + interrupts = <55>; + clocks = <&coreclk 0>; + status = "disabled"; + }; + }; };