| Message ID | 1351352973-3719-1-git-send-email-akinobu.mita@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Oct 27, 2012 at 5:49 PM, Akinobu Mita <akinobu.mita@gmail.com> wrote: > Replace open-coded loop with for_each_set_bit(). > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> > Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: Dan Williams <djbw@fb.com> Makes perfect sense to me, Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c index ae55091..08f5bfe 100644 --- a/drivers/dma/ste_dma40.c +++ b/drivers/dma/ste_dma40.c @@ -1487,7 +1487,7 @@ static irqreturn_t d40_handle_interrupt(int irq, void *data) u32 regs[ARRAY_SIZE(il)]; u32 idx; u32 row; - long chan = -1; + long chan; struct d40_chan *d40c; unsigned long flags; struct d40_base *base = data; @@ -1498,15 +1498,8 @@ static irqreturn_t d40_handle_interrupt(int irq, void *data) for (i = 0; i < ARRAY_SIZE(il); i++) regs[i] = readl(base->virtbase + il[i].src); - for (;;) { - - chan = find_next_bit((unsigned long *)regs, - BITS_PER_LONG * ARRAY_SIZE(il), chan + 1); - - /* No more set bits found? */ - if (chan == BITS_PER_LONG * ARRAY_SIZE(il)) - break; - + for_each_set_bit(chan, (unsigned long *)regs, + BITS_PER_LONG * ARRAY_SIZE(il)) { row = chan / BITS_PER_LONG; idx = chan & (BITS_PER_LONG - 1);
Replace open-coded loop with for_each_set_bit(). Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: linux-arm-kernel@lists.infradead.org Cc: Vinod Koul <vinod.koul@intel.com> Cc: Dan Williams <djbw@fb.com> --- drivers/dma/ste_dma40.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-)