diff mbox

arm: bcm2835: enable proc and sysfs in defconfig

Message ID 1351357249-17658-1-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thomas Petazzoni Oct. 27, 2012, 5 p.m. UTC
For some reason, support for proc and sysfs is currently disabled in
the bcm2835_defconfig, even though those filesystems are quite
essential even for very basic Linux userspace. As most defconfig have
them enabled by default, enable them as well in bcm2835_defconfig.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/configs/bcm2835_defconfig |    2 --
 1 file changed, 2 deletions(-)

Comments

Stephen Warren Oct. 28, 2012, 2:33 a.m. UTC | #1
On 10/27/2012 11:00 AM, Thomas Petazzoni wrote:
> For some reason, support for proc and sysfs is currently disabled in
> the bcm2835_defconfig, even though those filesystems are quite
> essential even for very basic Linux userspace. As most defconfig have
> them enabled by default, enable them as well in bcm2835_defconfig.

How silly of me; I had this as part of a local change for testing, but
hadn't made a patch to add it to the defconfig upstream.

Applied to bcm2835's for-3.8/defconfig branch. Thanks.
Sergei Shtylyov Oct. 28, 2012, 11:43 a.m. UTC | #2
Hello.

On 27-10-2012 21:00, Thomas Petazzoni wrote:

> For some reason, support for proc and sysfs is currently disabled in
> the bcm2835_defconfig, even though those filesystems are quite
> essential even for very basic Linux userspace. As most defconfig have
> them enabled by default, enable them as well in bcm2835_defconfig.

> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>   arch/arm/configs/bcm2835_defconfig |    2 --
>   1 file changed, 2 deletions(-)

> diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig
> index 7aea702..74e27f0 100644
> --- a/arch/arm/configs/bcm2835_defconfig
> +++ b/arch/arm/configs/bcm2835_defconfig
> @@ -66,8 +66,6 @@ CONFIG_TTY_PRINTK=y
>   # CONFIG_FILE_LOCKING is not set
>   # CONFIG_DNOTIFY is not set
>   # CONFIG_INOTIFY_USER is not set
> -# CONFIG_PROC_FS is not set
> -# CONFIG_SYSFS is not set

    Hm, I don't see where are you enabling them... So I miss something?

WBR, Sergei
Thomas Petazzoni Oct. 28, 2012, 12:28 p.m. UTC | #3
Dear Sergei Shtylyov,

On Sun, 28 Oct 2012 15:43:33 +0400, Sergei Shtylyov wrote:

> > diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig
> > index 7aea702..74e27f0 100644
> > --- a/arch/arm/configs/bcm2835_defconfig
> > +++ b/arch/arm/configs/bcm2835_defconfig
> > @@ -66,8 +66,6 @@ CONFIG_TTY_PRINTK=y
> >   # CONFIG_FILE_LOCKING is not set
> >   # CONFIG_DNOTIFY is not set
> >   # CONFIG_INOTIFY_USER is not set
> > -# CONFIG_PROC_FS is not set
> > -# CONFIG_SYSFS is not set
> 
>     Hm, I don't see where are you enabling them... So I miss something?

Yes:

config PROC_FS
        bool "/proc file system support" if EXPERT
        default y

config SYSFS
        bool "sysfs file system support" if EXPERT
        default y

Those options are enabled by default. So, when there's nothing in the
defconfig file to disable them, they are enabled.

Thomas
diff mbox

Patch

diff --git a/arch/arm/configs/bcm2835_defconfig b/arch/arm/configs/bcm2835_defconfig
index 7aea702..74e27f0 100644
--- a/arch/arm/configs/bcm2835_defconfig
+++ b/arch/arm/configs/bcm2835_defconfig
@@ -66,8 +66,6 @@  CONFIG_TTY_PRINTK=y
 # CONFIG_FILE_LOCKING is not set
 # CONFIG_DNOTIFY is not set
 # CONFIG_INOTIFY_USER is not set
-# CONFIG_PROC_FS is not set
-# CONFIG_SYSFS is not set
 # CONFIG_MISC_FILESYSTEMS is not set
 CONFIG_PRINTK_TIME=y
 # CONFIG_ENABLE_WARN_DEPRECATED is not set