| Message ID | 1351498881-32482-3-git-send-email-hvaibhav@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>>>> "Vaibhav" == Vaibhav Hiremath <hvaibhav@ti.com> writes: Vaibhav> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync() Vaibhav> api, driver is calling pm_runtime_put_sync() api in resume callback Vaibhav> function. The bug was introduced by commit id (ae2c07aaf74: Vaibhav> davinci_mdio: runtime PM support). Vaibhav> Now, the reason why it didn't impact functionality is, the patch has Vaibhav> been tested on AM335x-EVM and BeagleBone platform while submitting; Vaibhav> and in case of AM335x the MDIO driver doesn't control the module Vaibhav> enable/disable part, which is handled by CPSW driver. Vaibhav> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> Vaibhav> Cc: Mugunthan V N <mugunthanvnm@ti.com> Vaibhav> Cc: Richard Cochran <richardcochran@gmail.com> Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c index 51a96db..ae74280 100644 --- a/drivers/net/ethernet/ti/davinci_mdio.c +++ b/drivers/net/ethernet/ti/davinci_mdio.c @@ -465,7 +465,7 @@ static int davinci_mdio_resume(struct device *dev) u32 ctrl; spin_lock(&data->lock); - pm_runtime_put_sync(data->dev); + pm_runtime_get_sync(data->dev); /* restart the scan state machine */ ctrl = __raw_readl(&data->regs->control);
By mistake (most likely a copy-paste), instead of pm_runtime_get_sync() api, driver is calling pm_runtime_put_sync() api in resume callback function. The bug was introduced by commit id (ae2c07aaf74: davinci_mdio: runtime PM support). Now, the reason why it didn't impact functionality is, the patch has been tested on AM335x-EVM and BeagleBone platform while submitting; and in case of AM335x the MDIO driver doesn't control the module enable/disable part, which is handled by CPSW driver. Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com> Cc: Mugunthan V N <mugunthanvnm@ti.com> Cc: Richard Cochran <richardcochran@gmail.com> --- drivers/net/ethernet/ti/davinci_mdio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)