From patchwork Wed Oct 31 10:48:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaotian Feng X-Patchwork-Id: 1678351 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id E91A6DF2F6 for ; Wed, 31 Oct 2012 10:50:56 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TTVqP-0006Gb-GH; Wed, 31 Oct 2012 10:48:21 +0000 Received: from mail-da0-f49.google.com ([209.85.210.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TTVqH-0006AS-Be for linux-arm-kernel@lists.infradead.org; Wed, 31 Oct 2012 10:48:15 +0000 Received: by mail-da0-f49.google.com with SMTP id q27so545424daj.36 for ; Wed, 31 Oct 2012 03:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=XBwg/rZ5Nn17IYSo28GaU6l697fACZydoXR9frfZhJQ=; b=HgMQNl/Jka9l9/5QRXMwk5PkEUEoA9BSx46n6w5IK61bJtC+VDEUPx9aLbHV2PKy+D b7F/kmo81uCmCthlQc2EqteYs1XKCMZH4WM3AGwqobLrqHM4rcfjp1QOWY6XOK3iAO0C rZZcURoG3h6uqP3AmNl9HYUiE98mp7ffJmqJ7qqSg8AVgpIX8CL5KSd9lbqjKfA2QzH3 m1IQSAaNSrk8Cfo+FaLXGFtMPVmTlgp4aPPZC7XR8NVrSeCQ+rK2SHRbtjOVrC55G0KL dOSiOcdAW3jexYep0fEoNiu8aaQEFjA4ZahNp31c0fpa8TGUUvvjBbkCDNtOx67Si8cU QjCA== Received: by 10.68.220.169 with SMTP id px9mr113295215pbc.14.1351680487872; Wed, 31 Oct 2012 03:48:07 -0700 (PDT) Received: from localhost.localdomain ([61.135.172.68]) by mx.google.com with ESMTPS id ay5sm2018151pab.1.2012.10.31.03.48.01 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 31 Oct 2012 03:48:06 -0700 (PDT) From: Xiaotian Feng To: linux-kernel@vger.kernel.org Subject: [PATCH] mmc: s3cmci: use tasklet_kill in device remove/release process Date: Wed, 31 Oct 2012 18:48:45 +0800 Message-Id: <1351680525-27253-1-git-send-email-xtfeng@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121031_064813_586775_E65D39B2 X-CRM114-Status: GOOD ( 13.34 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.210.49 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (xtfeng[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.8 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [61.135.172.68 listed in dnsbl.sorbs.net] Cc: Xiaotian Feng , linux-mmc@vger.kernel.org, Ben Dooks , Xiaotian Feng , Chris Ball , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Some driver uses tasklet_disable in device remove/release process, tasklet_disable will inc tasklet->count and return. If the tasklet is not handled yet under some softirq pressure, the tasklet will be placed on the tasklet_vec, never have a chance to be excuted. This might lead to a heavy loaded ksoftirqd, wakeup with pending_softirq, but tasklet is disabled. tasklet_kill should be used in this case. Signed-off-by: Xiaotian Feng Cc: Ben Dooks Cc: Chris Ball Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mmc@vger.kernel.org --- drivers/mmc/host/s3cmci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 4638dda..d70d0cc 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -1830,7 +1830,7 @@ static int __devexit s3cmci_remove(struct platform_device *pdev) clk_put(host->clk); - tasklet_disable(&host->pio_tasklet); + tasklet_kill(&host->pio_tasklet); if (s3cmci_host_usedma(host)) s3c2410_dma_free(host->dma, &s3cmci_dma_client);