| Message ID | 1352176605-16153-1-git-send-email-padma.v@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Nov 6, 2012 at 1:37 PM, Padmavathi Venna wrote: > Subject: [PATCH V3] ARM: EXYNOS5: Add I2S SFR base addresse > > This patch adds I2S controller0,1,2 base addresses > > Signed-off-by: Padmavathi Venna <padma.v@samsung.com> Acked-by: Sangbeom Kim <sbkim73@samsung.com> Thanks, Sangbeom.
cc'ing Mark Brown On Tue, Nov 6, 2012 at 10:06 AM, Padmavathi Venna <padma.v@samsung.com> wrote: > This patch adds I2S controller0,1,2 base addresses > > Signed-off-by: Padmavathi Venna <padma.v@samsung.com> > --- > > Changes since V2: > - Rebased on 3.7-rc3 > > Changes since V1: > - Rebased on 3.6-rc6 > - Reverted Exynos4 I2S1,2 address changes that are added in V1 > as Exynos4 based boards have different I2S base addresses. > > arch/arm/mach-exynos/include/mach/map.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h > index ef4958b..4192d23 100644 > --- a/arch/arm/mach-exynos/include/mach/map.h > +++ b/arch/arm/mach-exynos/include/mach/map.h > @@ -42,6 +42,9 @@ > #define EXYNOS4_PA_I2S0 0x03830000 > #define EXYNOS4_PA_I2S1 0xE3100000 > #define EXYNOS4_PA_I2S2 0xE2A00000 > +#define EXYNOS5_PA_I2S0 0x03830000 > +#define EXYNOS5_PA_I2S1 0x12D60000 > +#define EXYNOS5_PA_I2S2 0x12D70000 > > #define EXYNOS4_PA_PCM0 0x03840000 > #define EXYNOS4_PA_PCM1 0x13980000 > -- > 1.7.4.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Padmavathi Venna wrote: > > This patch adds I2S controller0,1,2 base addresses > > Signed-off-by: Padmavathi Venna <padma.v@samsung.com> > --- > > Changes since V2: > - Rebased on 3.7-rc3 > > Changes since V1: > - Rebased on 3.6-rc6 > - Reverted Exynos4 I2S1,2 address changes that are added in V1 > as Exynos4 based boards have different I2S base addresses. > > arch/arm/mach-exynos/include/mach/map.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach- > exynos/include/mach/map.h > index ef4958b..4192d23 100644 > --- a/arch/arm/mach-exynos/include/mach/map.h > +++ b/arch/arm/mach-exynos/include/mach/map.h > @@ -42,6 +42,9 @@ > #define EXYNOS4_PA_I2S0 0x03830000 > #define EXYNOS4_PA_I2S1 0xE3100000 > #define EXYNOS4_PA_I2S2 0xE2A00000 > +#define EXYNOS5_PA_I2S0 0x03830000 > +#define EXYNOS5_PA_I2S1 0x12D60000 > +#define EXYNOS5_PA_I2S2 0x12D70000 > > #define EXYNOS4_PA_PCM0 0x03840000 > #define EXYNOS4_PA_PCM1 0x13980000 > -- > 1.7.4.4 I have 2 comments on this. 1. If above definitions are required, this patch can be squashed into the patch which they are used ([PATCH V3 2/2] ARM: EXYNOS: Enable platform support for I2S controllers) or this should be tied up one series with the patch. 2. I think, we don't need this because the value can be used in auxdata directly. So, I don't apply this. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index ef4958b..4192d23 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -42,6 +42,9 @@ #define EXYNOS4_PA_I2S0 0x03830000 #define EXYNOS4_PA_I2S1 0xE3100000 #define EXYNOS4_PA_I2S2 0xE2A00000 +#define EXYNOS5_PA_I2S0 0x03830000 +#define EXYNOS5_PA_I2S1 0x12D60000 +#define EXYNOS5_PA_I2S2 0x12D70000 #define EXYNOS4_PA_PCM0 0x03840000 #define EXYNOS4_PA_PCM1 0x13980000
This patch adds I2S controller0,1,2 base addresses Signed-off-by: Padmavathi Venna <padma.v@samsung.com> --- Changes since V2: - Rebased on 3.7-rc3 Changes since V1: - Rebased on 3.6-rc6 - Reverted Exynos4 I2S1,2 address changes that are added in V1 as Exynos4 based boards have different I2S base addresses. arch/arm/mach-exynos/include/mach/map.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)