From patchwork Tue Nov 6 21:55:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 1707091 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id A49B03FCAE for ; Tue, 6 Nov 2012 21:58:48 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TVr8M-0002KE-3q; Tue, 06 Nov 2012 21:56:34 +0000 Received: from moutng.kundenserver.de ([212.227.17.8]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TVr7a-00021r-W9 for linux-arm-kernel@lists.infradead.org; Tue, 06 Nov 2012 21:55:49 +0000 Received: from localhost.localdomain (HSI-KBW-149-172-5-253.hsi13.kabel-badenwuerttemberg.de [149.172.5.253]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0M2ndG-1TFpdY1wvO-00snKX; Tue, 06 Nov 2012 22:55:43 +0100 From: Arnd Bergmann To: linux-kernel@vger.kernel.org Subject: [PATCH 7/8] ata: highbank: mark ahci_highbank_probe as __devinit Date: Tue, 6 Nov 2012 22:55:32 +0100 Message-Id: <1352238933-4886-8-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1352238933-4886-1-git-send-email-arnd@arndb.de> References: <1352238933-4886-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:oQM2Nb2FpM/JP98YNZes+7+tFTmvDAK4Kp4rqTWvbVz 3tzEGZ/3na6oWULIi7eF4uMgzx/KcaA9HfJr6JH7n/ebximoR9 pXjvzl2dwITAP17F0gtm3UYJZ45Y0c7lxasAemaghzgaZpK3Pb RBvEHUR7KKCcGPFfXn53b0KiRHWu06Ezfa8h/LwOB6iWkZJCot JbnM8A5BQ91fxpt9gNR2vGI2jRsNzJV598T0onCd1v1r1ptPuw ABJDf1PXLnQwqC1FkuSY6CfMYV35pAWRavv/H53Vg8KRRlPc0r QQUArWWZiR/ZvJi8IuEr2FcY3q8AkGyBkmGH2u2Xa0sdlFC6Xb 8M7KTsmQmzZ7OLZ+bt7muaGrECH0A/wD7BrDJnuorLOGnDVXo1 oHVAEjgH06aGQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121106_165547_473086_9182504E X-CRM114-Status: GOOD ( 13.44 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.8 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Mark Langsdorf , Rob Herring , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Jeff Garzik X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The ahci_highbank_probe function is incorrectly marked as __init, which means it can get discarded at boot time, which might be a problem if for some reason the device only becomes operational after loading another module. Using __devinit instead avoids seeing this warning for every build: WARNING: vmlinux.o(.data+0xf7b0): Section mismatch in reference from the variable ahci_highbank_driver to the function .init.text:ahci_highbank_probe() The variable ahci_highbank_driver references the function __init ahci_highbank_probe() If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Signed-off-by: Arnd Bergmann Cc: Mark Langsdorf Cc: Rob Herring Cc: Jeff Garzik --- drivers/ata/sata_highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c index 0d7c4c2..36a141a 100644 --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c @@ -260,7 +260,7 @@ static const struct of_device_id ahci_of_match[] = { }; MODULE_DEVICE_TABLE(of, ahci_of_match); -static int __init ahci_highbank_probe(struct platform_device *pdev) +static int __devinit ahci_highbank_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct ahci_host_priv *hpriv;