From patchwork Fri Nov 9 08:32:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 1719601 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 6DA64DF264 for ; Fri, 9 Nov 2012 08:34:38 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TWk0s-00012l-4l; Fri, 09 Nov 2012 08:32:30 +0000 Received: from mail-wi0-f169.google.com ([209.85.212.169]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TWk0o-00011p-Db for linux-arm-kernel@lists.infradead.org; Fri, 09 Nov 2012 08:32:27 +0000 Received: by mail-wi0-f169.google.com with SMTP id hq4so380842wib.0 for ; Fri, 09 Nov 2012 00:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=jmiRcILY8mDBNPTL7cph0h6OgMMmEQk/yKXbf1cNfEA=; b=KONCgtBTIZTrNjB+OjGWD40jIVG3RpRe3CfgAcxHuP2hstvi1S9rB4yjGhx67D2qyz kp4GxyF+I8Lid5+mDrAuHvcnzEYX4ZpeXRoU5/vekqERm6XO03xUwXyl/fx69hGQQi5b lfad6U1AVCxGMNAdoTUq8+8NtYNeECjB8uP0vCi5yLSb7ydujbwn8coVDBLd+jOrYoh5 4KOzFoKWdh2ImxzpEZUGwzwBOToApIcncfkwhoRx2v7fj9KF9FCvOODlyGHf95Gxf94H dyM8pi1+cAFil7R42RgIneZ4U9jqBzlV9qtB1kRjKoaLdncmEfr6gdxzFNCAlKmn4VyA G8qg== Received: by 10.216.137.34 with SMTP id x34mr3030591wei.142.1352449944665; Fri, 09 Nov 2012 00:32:24 -0800 (PST) Received: from localhost.localdomain (88.Red-2-139-206.staticIP.rima-tde.net. [2.139.206.88]) by mx.google.com with ESMTPS id gg4sm1352585wib.6.2012.11.09.00.32.23 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 09 Nov 2012 00:32:24 -0800 (PST) From: Sylwester Nawrocki To: kgene.kim@samsung.com Subject: [PATCH] ARM: S3C64XX: Statically define parent clock of the "camera" clock Date: Fri, 9 Nov 2012 09:32:09 +0100 Message-Id: <1352449929-20168-1-git-send-email-sylvester.nawrocki@gmail.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121109_033226_592478_ADA9E4E4 X-CRM114-Status: GOOD ( 14.90 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sylvester.nawrocki[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.212.169 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Sylwester Nawrocki , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dron0gus@gmail.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The "camera" clock defined in arch/arm/mach-s3c64xx/clock.c has null clock source mux control register as it can have only one parent clock. In such cases there is a need to configure the parent clock statically, otherwise s3c_set_clksrc() bails out with an error message "no parent clock specified" leaving the parent clock not configured. Define statically the parent clock so it is possible to get or set rate of the "camera" clock. While at it remove the unneded null reg_src definition. Reported-by: In-Bae Jeong Signed-off-by: Sylwester Nawrocki --- arch/arm/mach-s3c64xx/clock.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c index 28041e8..2e6d7f9 100644 --- a/arch/arm/mach-s3c64xx/clock.c +++ b/arch/arm/mach-s3c64xx/clock.c @@ -744,9 +744,9 @@ static struct clksrc_clk clksrcs[] = { .name = "camera", .ctrlbit = S3C_CLKCON_SCLK_CAM, .enable = s3c64xx_sclk_ctrl, + .parent = &clk_h2, }, .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 }, - .reg_src = { .reg = NULL, .shift = 0, .size = 0 }, .sources = &clkset_camif, }, };