From patchwork Thu Nov 15 12:13:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naveen Krishna Chatradhi X-Patchwork-Id: 1748781 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id C1F31DF230 for ; Thu, 15 Nov 2012 11:57:46 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TYy2s-0007ve-1D; Thu, 15 Nov 2012 11:55:47 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TYy2m-0007tN-PK for linux-arm-kernel@lists.infradead.org; Thu, 15 Nov 2012 11:55:41 +0000 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MDJ007IR2G84KO0@mailout2.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 15 Nov 2012 20:55:39 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.122]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 83.50.01231.B38D4A05; Thu, 15 Nov 2012 20:55:39 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-13-50a4d83bfa24 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id F2.50.01231.B38D4A05; Thu, 15 Nov 2012 20:55:39 +0900 (KST) Received: from localhost.localdomain ([107.108.73.106]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MDJ0033F28S3800@mmp1.samsung.com> for linux-arm-kernel@lists.infradead.org; Thu, 15 Nov 2012 20:55:39 +0900 (KST) From: Naveen Krishna Chatradhi To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org Subject: [PATCH 4/4] i2c-s3c2410: do not special case HDMIPHY stuck bus detection Date: Thu, 15 Nov 2012 17:43:33 +0530 Message-id: <1352981613-2098-5-git-send-email-ch.naveen@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1352981613-2098-1-git-send-email-ch.naveen@samsung.com> References: <1352981613-2098-1-git-send-email-ch.naveen@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsWyRsSkStf6xpIAgwdztS02Pb7G6sDosXlJ fQBjFJdNSmpOZllqkb5dAlfGpX8P2AtW8Vds2XuatYHxKE8XIyeHhICJxK3fN9ghbDGJC/fW s3UxcnEICSxllFjS/oAZpqipaxMrRGIRo8Sv/plMEM4GJon+lfNZQKrYBMwkDi5aDTZKRCBD YsmjDYwgRcwCvYwS24B2gySEBYIlFvz/ywpiswioStydPBWomYODV8BF4sO7NIhtChKtyw6B lXMKuEpsX3qUEcQWAirZfXElVKuAxLfJh8BaJQRkJTYdYAZZJSFwnU1i3q49UO9IShxccYNl AqPwAkaGVYyiqQXJBcVJ6bmGesWJucWleel6yfm5mxiBQXj63zOpHYwrGywOMQpwMCrx8Dr8 WBwgxJpYVlyZe4hRgoNZSYTX4NySACHelMTKqtSi/Pii0pzU4kOMPkCXTGSWEk3OB0ZIXkm8 obGJuamxqaWRkZmpKQ5hJXHeZo+UACGB9MSS1OzU1ILUIphxTBycUg2MnKe1Fs2Y6PZSLbFq 2wuVmherv+VFT5fKe12st3i9x74EGwWz11ukInSW9VksqPGVXPnhfMyCbeEzz+hH8LRkHG5p 7egyeXDtomi2oNn0p1fdc9dfPHJEZE1q853VJXs2lPOGXHWS0N5Z0Jnv+Kbh3J+5fcZrlk72 K0/lXtR++ir7w2ptHqlvSizFGYmGWsxFxYkAdfTmUG8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e+xgK71jSUBBks+y1tsenyN1YHRY/OS +gDGqAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zByg qUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjEv/HrAXrOKv2LL3NGsD 41GeLkZODgkBE4mmrk2sELaYxIV769m6GLk4hAQWMUr86p/JBOFsYJLoXzmfBaSKTcBM4uCi 1ewgtohAhsSSRxsYQYqYBXoZJbYBrQBJCAsESyz4/xdsLIuAqsTdyVOBmjk4eAVcJD68S4PY piDRuuwQWDmngKvE9qVHGUFsIaCS3RdXsk5g5F3AyLCKUTS1ILmgOCk911CvODG3uDQvXS85 P3cTIzjEn0ntYFzZYHGIUYCDUYmH1+HH4gAh1sSy4srcQ4wSHMxKIrwG55YECPGmJFZWpRbl xxeV5qQWH2L0ATpqIrOUaHI+MP7ySuINjU3MTY1NLU0sTMwscQgrifM2e6QECAmkJ5akZqem FqQWwYxj4uCUamCcWaS7o335rxKDLr+qkj2rrfNr222nPNhYYbs1fKZsxVdXFvW/adeNbmns mn58eeS+prlBVmc1exlvx4hEcXv0/vuYPsNgftbEreL2P7Ie3T+cIaLpvzho26Kiv1/Z9OdI rCxd9O5K3NlF3a6t0vZBb7NN+LyNauq3TWk8FrP82NuW/Xv5g5SUWIozEg21mIuKEwF554QT ngIAAA== X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121115_065541_325906_D7AC7523 X-CRM114-Status: GOOD ( 12.54 ) X-Spam-Score: -7.6 (-------) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-7.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/, high trust [203.254.224.25 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: kgene.kim@samsung.com, w.sang@pengutronix.de, djkurtz@chromium.org, ben-linux@fluff.org, khali@linux-fr.org, naveenkrishna.ch@gmail.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Daniel Kurtz Commit "i2c-s3c2410: Add HDMIPHY quirk for S3C2440" added support for HDMIPHY with some special handling in s3c24xx_i2c_set_master: "due to unknown reason (probably HW bug in HDMIPHY and/or the controller) a transfer fails to finish. The controller hangs after sending the last byte, the workaround for this bug is resetting the controller after each transfer" The "unknown reason" was that the proper sequence for generating a STOP condition wasn't being followed as per the datasheet. Since this is fixed by "PATCH: i2c-s3c2410: do not generate STOP for QUIRK_HDMIPHY buses", remove the special handling. Signed-off-by: Daniel Kurtz Cc: Daniel Kurtz Signed-off-by: Naveen Krishna Chatradhi --- drivers/i2c/busses/i2c-s3c2410.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 362a307..c76ca7c 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c @@ -531,13 +531,6 @@ static int s3c24xx_i2c_set_master(struct s3c24xx_i2c *i2c) unsigned long iicstat; int timeout = 400; - /* the timeout for HDMIPHY is reduced to 10 ms because - * the hangup is expected to happen, so waiting 400 ms - * causes only unnecessary system hangup - */ - if (i2c->quirks & QUIRK_HDMIPHY) - timeout = 10; - while (timeout-- > 0) { iicstat = readl(i2c->regs + S3C2410_IICSTAT); @@ -547,15 +540,6 @@ static int s3c24xx_i2c_set_master(struct s3c24xx_i2c *i2c) msleep(1); } - /* hang-up of bus dedicated for HDMIPHY occurred, resetting */ - if (i2c->quirks & QUIRK_HDMIPHY) { - writel(0, i2c->regs + S3C2410_IICCON); - writel(0, i2c->regs + S3C2410_IICSTAT); - writel(0, i2c->regs + S3C2410_IICDS); - - return 0; - } - return -ETIMEDOUT; }