diff mbox

[PATCHv2] ARM: dts: cfa10049: Add PCA9555 GPIO expander to the device tree

Message ID 1353422015-4790-1-git-send-email-maxime.ripard@free-electrons.com (mailing list archive)
State New, archived
Headers show

Commit Message

Maxime Ripard Nov. 20, 2012, 2:33 p.m. UTC
Add the GPIO expander found on the i2c1 bus, behind the muxer to the
device tree.

This gpio expander will be used to get tachymeters values and data ready
interruptions from the nuvoton NAU7802 ADCs.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 arch/arm/boot/dts/imx28-cfa10049.dts |   26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

Comments

Maxime Ripard Nov. 22, 2012, 10:45 a.m. UTC | #1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Shawn,

Le 20/11/2012 15:33, Maxime Ripard a écrit :
> Add the GPIO expander found on the i2c1 bus, behind the muxer to
> the device tree.
> 
> This gpio expander will be used to get tachymeters values and data 
> ready interruptions from the nuvoton NAU7802 ADCs.

If you're ok with it, I'd really like for that patch to be in 3.8.
Is this version ok, or do you have any additional comments I could
address?

Thanks,
Maxime

- -- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iEYEARECAAYFAlCuAjsACgkQGxsu9jQV9naCFwCfXjxLa0qLRx2ThFDFLSC8bKAk
hHsAnjYIC7xtbHzZW27GGy3TdfZO5O5M
=0dLl
-----END PGP SIGNATURE-----
Shawn Guo Nov. 22, 2012, 11:24 a.m. UTC | #2
On Thu, Nov 22, 2012 at 11:45:17AM +0100, Maxime Ripard wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi Shawn,
> 
> Le 20/11/2012 15:33, Maxime Ripard a écrit :
> > Add the GPIO expander found on the i2c1 bus, behind the muxer to
> > the device tree.
> > 
> > This gpio expander will be used to get tachymeters values and data 
> > ready interruptions from the nuvoton NAU7802 ADCs.
> 
> If you're ok with it, I'd really like for that patch to be in 3.8.
> Is this version ok, or do you have any additional comments I could
> address?
> 
The patch is ok now.  But I have problem to apply it because its
prerequisite has been applied on i2c tree, as I did not plan a second
pull request for 3.8 at all.

I hope it's fine to apply the patch on top of v3.8-rc1, or you can
try to ask Wolfram to have this patch go via his tree too.

Shawn
Maxime Ripard Nov. 23, 2012, 10:17 a.m. UTC | #3
Hi Wolfram,

Le 20/11/2012 15:33, Maxime Ripard a écrit :
> Add the GPIO expander found on the i2c1 bus, behind the muxer to the
> device tree.
> 
> This gpio expander will be used to get tachymeters values and data ready
> interruptions from the nuvoton NAU7802 ADCs.

Since this patch depends on the I2C muxer patches you applied, can you
take it to push it for 3.8? Shawn Guo is ok with it, but it doesn't
apply in his tree.

Thanks,
Maxime
Maxime Ripard Dec. 27, 2012, 10 p.m. UTC | #4
Hi Shawn,

Le 22/11/2012 12:24, Shawn Guo a écrit :
> On Thu, Nov 22, 2012 at 11:45:17AM +0100, Maxime Ripard wrote:
> The patch is ok now.  But I have problem to apply it because its
> prerequisite has been applied on i2c tree, as I did not plan a second
> pull request for 3.8 at all.
> 
> I hope it's fine to apply the patch on top of v3.8-rc1, or you can
> try to ask Wolfram to have this patch go via his tree too.

Are you still ok to apply it on top of 3.8-rc1 and send it for -rc2? Or
to queue it up for 3.9?

Thanks,
Maxime
Shawn Guo Dec. 28, 2012, 11:03 a.m. UTC | #5
On Thu, Dec 27, 2012 at 11:00:51PM +0100, Maxime Ripard wrote:
> Are you still ok to apply it on top of 3.8-rc1 and send it for -rc2? Or
> to queue it up for 3.9?
> 
Since it's not really a bug fix, I will have to queue it up for 3.9.

Shawn
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx28-cfa10049.dts b/arch/arm/boot/dts/imx28-cfa10049.dts
index bdc80a4..7890acc 100644
--- a/arch/arm/boot/dts/imx28-cfa10049.dts
+++ b/arch/arm/boot/dts/imx28-cfa10049.dts
@@ -23,7 +23,8 @@ 
 		apbh@80000000 {
 			pinctrl@80018000 {
 				pinctrl-names = "default", "default";
-				pinctrl-1 = <&hog_pins_cfa10049>;
+				pinctrl-1 = <&hog_pins_cfa10049
+					&hog_pins_cfa10049_pullup>;
 
 				hog_pins_cfa10049: hog-10049@0 {
 					reg = <0>;
@@ -38,6 +39,16 @@ 
 					fsl,pull-up = <0>;
 				};
 
+				hog_pins_cfa10049_pullup: hog-10049-pullup@0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
+						0x2133 /* MX28_PAD_SSP2_D3__GPIO_2_19 */
+					>;
+					fsl,drive-strength = <0>;
+					fsl,voltage = <1>;
+					fsl,pull-up = <1>;
+				};
+
 				spi3_pins_cfa10049: spi3-cfa10049@0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
@@ -113,6 +124,19 @@ 
 
 				i2c@3 {
 					reg = <3>;
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					pca9555: pca9555@20 {
+						compatible = "nxp,pca9555";
+						interrupt-parent = <&gpio2>;
+						interrupts = <19 0x2>;
+						gpio-controller;
+						#gpio-cells = <2>;
+						interrupt-controller;
+						#interrupt-cells = <2>;
+						reg = <0x20>;
+					};
 				};
 			};