diff mbox

[06/29] usb: host: ehci-mv: fix clk APIs

Message ID 1353549910-988-6-git-send-email-xiechao.mail@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chao Xie Nov. 22, 2012, 2:04 a.m. UTC 
From: Chao Xie <chao.xie@marvell.com>

Signed-off-by: Chao Xie <xiechao.mail@gmail.com>
---
 drivers/usb/host/ehci-mv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Alan Stern Nov. 23, 2012, 4:06 p.m. UTC | #1 
On Wed, 21 Nov 2012, Chao Xie wrote:

> From: Chao Xie <chao.xie@marvell.com>
> 
> Signed-off-by: Chao Xie <xiechao.mail@gmail.com>

I don't like patches with no patch description.  You should write 
something here, explaining why the change is needed.  What's wrong with 
the clk APIs?

The same hold for your other patches, except perhaps the trivial one 
that removes an unused local variable definition.

Alan Stern
diff mbox

Patch

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index f7bfc0b..6c56297 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -43,7 +43,7 @@  static void ehci_clock_enable(struct ehci_hcd_mv *ehci_mv)
 	unsigned int i;
 
 	for (i = 0; i < ehci_mv->clknum; i++)
-		clk_enable(ehci_mv->clk[i]);
+		clk_prepare_enable(ehci_mv->clk[i]);
 }
 
 static void ehci_clock_disable(struct ehci_hcd_mv *ehci_mv)
@@ -51,7 +51,7 @@  static void ehci_clock_disable(struct ehci_hcd_mv *ehci_mv)
 	unsigned int i;
 
 	for (i = 0; i < ehci_mv->clknum; i++)
-		clk_disable(ehci_mv->clk[i]);
+		clk_disable_unprepare(ehci_mv->clk[i]);
 }
 
 static int mv_ehci_enable(struct ehci_hcd_mv *ehci_mv)