diff mbox

[1/4] ARM: dts: Add very basic dt support for mx31pdk

Message ID 1353611447-7732-1-git-send-email-fabio.estevam@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Nov. 22, 2012, 7:10 p.m. UTC
Add very basic dt support for mx31pdk.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 Documentation/devicetree/bindings/arm/fsl.txt |    4 ++++
 arch/arm/boot/dts/Makefile                    |    3 ++-
 arch/arm/boot/dts/imx31-pdk.dts               |   30 +++++++++++++++++++++++++
 3 files changed, 36 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/imx31-pdk.dts

Comments

Sascha Hauer Nov. 26, 2012, 10:03 a.m. UTC | #1
On Thu, Nov 22, 2012 at 05:10:43PM -0200, Fabio Estevam wrote:
> Add very basic dt support for mx31pdk.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Could you provide a bit more complete patch? I think at least the low
hanging fruits like nor flash and nand, some i2c devices is not much
work but would save a lot of churn in patching the file.

Sascha

> ---
>  Documentation/devicetree/bindings/arm/fsl.txt |    4 ++++
>  arch/arm/boot/dts/Makefile                    |    3 ++-
>  arch/arm/boot/dts/imx31-pdk.dts               |   30 +++++++++++++++++++++++++
>  3 files changed, 36 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/imx31-pdk.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
> index ac9e751..50b931a 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.txt
> +++ b/Documentation/devicetree/bindings/arm/fsl.txt
> @@ -9,6 +9,10 @@ i.MX28 Evaluation Kit
>  Required root node properties:
>      - compatible = "fsl,imx28-evk", "fsl,imx28";
>  
> +i.MX31 Product Development Kit
> +Required root node properties:
> +    - compatible = "fsl,imx31-pdk", "fsl,imx31";
> +
>  i.MX51 Babbage Board
>  Required root node properties:
>      - compatible = "fsl,imx51-babbage", "fsl,imx51";
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 701388b..5b5590f 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -59,7 +59,8 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
>  	msm8960-cdp.dtb
>  dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
>  	armada-xp-db.dtb
> -dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
> +dtb-$(CONFIG_ARCH_MXC) += imx31-pdk.dtb \
> +	imx51-babbage.dtb \
>  	imx53-ard.dtb \
>  	imx53-evk.dtb \
>  	imx53-qsb.dtb \
> diff --git a/arch/arm/boot/dts/imx31-pdk.dts b/arch/arm/boot/dts/imx31-pdk.dts
> new file mode 100644
> index 0000000..1e46d80
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx31-pdk.dts
> @@ -0,0 +1,30 @@
> +/*
> + * Copyright 2012 Freescale Semiconductor, Inc.
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +/include/ "imx31.dtsi"
> +
> +/ {
> +	model = "mx31-pdk";
> +	compatible = "freescale,imx31-pdk", "fsl,imx31";
> +
> +	memory {
> +		reg = <0x80000000 0x8000000>;
> +	};
> +
> +	soc {
> +		aips@43f00000 { /* AIPS1 */
> +			uart1: serial@43f90000 {
> +				status = "okay";
> +			};
> +		};
> +	};
> +};
> -- 
> 1.7.9.5
> 
> 
>
Fabio Estevam Nov. 27, 2012, 3:08 a.m. UTC | #2
On Mon, Nov 26, 2012 at 8:03 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Thu, Nov 22, 2012 at 05:10:43PM -0200, Fabio Estevam wrote:
>> Add very basic dt support for mx31pdk.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Could you provide a bit more complete patch? I think at least the low
> hanging fruits like nor flash and nand, some i2c devices is not much
> work but would save a lot of churn in patching the file.

Ok, what about the other patches of the series? Are they good?

Regards,

Fabio Estevam
Sascha Hauer Nov. 27, 2012, 7:39 a.m. UTC | #3
On Tue, Nov 27, 2012 at 01:08:07AM -0200, Fabio Estevam wrote:
> On Mon, Nov 26, 2012 at 8:03 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > On Thu, Nov 22, 2012 at 05:10:43PM -0200, Fabio Estevam wrote:
> >> Add very basic dt support for mx31pdk.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Could you provide a bit more complete patch? I think at least the low
> > hanging fruits like nor flash and nand, some i2c devices is not much
> > work but would save a lot of churn in patching the file.
> 
> Ok, what about the other patches of the series? Are they good?

Yeah, the rest looks ok. Applied them.

Sascha
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
index ac9e751..50b931a 100644
--- a/Documentation/devicetree/bindings/arm/fsl.txt
+++ b/Documentation/devicetree/bindings/arm/fsl.txt
@@ -9,6 +9,10 @@  i.MX28 Evaluation Kit
 Required root node properties:
     - compatible = "fsl,imx28-evk", "fsl,imx28";
 
+i.MX31 Product Development Kit
+Required root node properties:
+    - compatible = "fsl,imx31-pdk", "fsl,imx31";
+
 i.MX51 Babbage Board
 Required root node properties:
     - compatible = "fsl,imx51-babbage", "fsl,imx51";
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 701388b..5b5590f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -59,7 +59,8 @@  dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 	msm8960-cdp.dtb
 dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-xp-db.dtb
-dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
+dtb-$(CONFIG_ARCH_MXC) += imx31-pdk.dtb \
+	imx51-babbage.dtb \
 	imx53-ard.dtb \
 	imx53-evk.dtb \
 	imx53-qsb.dtb \
diff --git a/arch/arm/boot/dts/imx31-pdk.dts b/arch/arm/boot/dts/imx31-pdk.dts
new file mode 100644
index 0000000..1e46d80
--- /dev/null
+++ b/arch/arm/boot/dts/imx31-pdk.dts
@@ -0,0 +1,30 @@ 
+/*
+ * Copyright 2012 Freescale Semiconductor, Inc.
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+/include/ "imx31.dtsi"
+
+/ {
+	model = "mx31-pdk";
+	compatible = "freescale,imx31-pdk", "fsl,imx31";
+
+	memory {
+		reg = <0x80000000 0x8000000>;
+	};
+
+	soc {
+		aips@43f00000 { /* AIPS1 */
+			uart1: serial@43f90000 {
+				status = "okay";
+			};
+		};
+	};
+};