| Message ID | 1354232481-32168-1-git-send-email-dromede@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
The port could be not routed to external, but used internally. I cannot remember the details of spitz as there isn't too much public detail around, just want to make sure no other devices are connected to port 1 and 3. On Fri, Nov 30, 2012 at 7:41 AM, <dromede@gmail.com> wrote: > From: Marko Katic <dromede.gmail.com> > > Spitz devices only have a single mini usb a/b plug > connected to usb port 2. > This patch disables ports 1 and 3 since they are not used. > > Signed-off-by: Marko Katic <dromede@gmail.com> > --- > arch/arm/mach-pxa/spitz.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c > index 0f92264..4443540 100644 > --- a/arch/arm/mach-pxa/spitz.c > +++ b/arch/arm/mach-pxa/spitz.c > @@ -651,7 +651,7 @@ static struct pxaohci_platform_data spitz_ohci_platform_data = { > .port_mode = PMM_NPS_MODE, > .init = spitz_ohci_init, > .exit = spitz_ohci_exit, > - .flags = ENABLE_PORT_ALL | NO_OC_PROTECTION, > + .flags = ENABLE_PORT2 | NO_OC_PROTECTION, > .power_budget = 150, > }; > > -- > 1.7.10.4 >
On Mon, Dec 3, 2012 at 3:13 AM, Eric Miao <eric.y.miao@gmail.com> wrote: > The port could be not routed to external, but used internally. I cannot > remember the details of spitz as there isn't too much public detail around, > just want to make sure no other devices are connected to port 1 and 3. I'm pretty certain both are unused. Take a look at this: http://www.penguin.cz/~utx/zaurus/www.iral.com/~albertr/linux/zaurus/wireless/ I also tested this change and i didn't notice that something was broken or missing. But if no power savings are to be gained from disabling these ports then i guess we can leave them be.
diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c index 0f92264..4443540 100644 --- a/arch/arm/mach-pxa/spitz.c +++ b/arch/arm/mach-pxa/spitz.c @@ -651,7 +651,7 @@ static struct pxaohci_platform_data spitz_ohci_platform_data = { .port_mode = PMM_NPS_MODE, .init = spitz_ohci_init, .exit = spitz_ohci_exit, - .flags = ENABLE_PORT_ALL | NO_OC_PROTECTION, + .flags = ENABLE_PORT2 | NO_OC_PROTECTION, .power_budget = 150, };