diff mbox

[v4,3/7] watchdog: sp805_wdt depends on ARM

Message ID 1355146956-6009-4-git-send-email-ciminaghi@gnudd.com (mailing list archive)
State New, archived
Headers show

Commit Message

Davide Ciminaghi Dec. 10, 2012, 1:42 p.m. UTC 
From: Alessandro Rubini <rubini@gnudd.com>

The SP805 driver is only used by the Spear machines, and uses
writel_relaxed, which is not available on all architectures.

The dependency from CONFIG_ARM avoids compilation problems under
randomconfig when CONFIG_ARM_AMBA is enabled for x86 builds.

Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
Signed-off-by: Davide Ciminaghi <ciminaghi@gnudd.com>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Grant Likely Dec. 12, 2012, 10:20 p.m. UTC | #1 
On Wed, Dec 12, 2012 at 9:21 PM, Wim Van Sebroeck <wim@iguana.be> wrote:
> Hi Davide
>
>> From: Alessandro Rubini <rubini@gnudd.com>
>>
>> The SP805 driver is only used by the Spear machines, and uses
>> writel_relaxed, which is not available on all architectures.
>>
>> The dependency from CONFIG_ARM avoids compilation problems under
>> randomconfig when CONFIG_ARM_AMBA is enabled for x86 builds.
>>
>> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
>> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
>> Signed-off-by: Davide Ciminaghi <ciminaghi@gnudd.com>
>
> Signed-off-by: Wim Van Sebroeck <wim@iguana.be>

Point of order. Adding Signed-off-by is only appropriate if you have
actually "handled" a patch (ie. either applied it to your own git tree
or you are reposting it). If you're merely stating that you're okay
with the patch then "Acked-by" is what you should use.

Signed-off-by is more properly about asserting that you received the
patch under licensing terms compatible with the current. See
Developer's Certificate of Origin in Documentation/SubmittingPatches
for details.

g.
diff mbox

Patch

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index ad1bb93..c76fc07 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -98,7 +98,7 @@  config WM8350_WATCHDOG
 
 config ARM_SP805_WATCHDOG
 	tristate "ARM SP805 Watchdog"
-	depends on ARM_AMBA
+	depends on ARM && ARM_AMBA
 	select WATCHDOG_CORE
 	help
 	  ARM Primecell SP805 Watchdog timer. This will reboot your system when