| Message ID | 1355760668-28606-1-git-send-email-will.deacon@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/12/12 16:11, Will Deacon wrote: > Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore > private memory region") accidentally broke the definition for the base > address of the private peripheral region on revision B Realview-EB > boards. > > This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE. > > Cc: Marc Zyngier <marc.zyngier@arm.com> > Tested-by: Florian Fainelli <florian@openwrt.org> > Signed-off-by: Will Deacon <will.deacon@arm.com> Acked-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm/mach-realview/include/mach/board-eb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h > index 124bce6..a301e61 100644 > --- a/arch/arm/mach-realview/include/mach/board-eb.h > +++ b/arch/arm/mach-realview/include/mach/board-eb.h > @@ -47,7 +47,7 @@ > #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */ > > #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB > -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000 > +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000 > #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */ > #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */ > #else >
On 17/12/12 16:11, Will Deacon wrote: > Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore > private memory region") accidentally broke the definition for the base > address of the private peripheral region on revision B Realview-EB > boards. > > This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE. > > Cc: Marc Zyngier <marc.zyngier@arm.com> > Tested-by: Florian Fainelli <florian@openwrt.org> > Signed-off-by: Will Deacon <will.deacon@arm.com> Acked-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm/mach-realview/include/mach/board-eb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h > index 124bce6..a301e61 100644 > --- a/arch/arm/mach-realview/include/mach/board-eb.h > +++ b/arch/arm/mach-realview/include/mach/board-eb.h > @@ -47,7 +47,7 @@ > #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */ > > #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB > -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000 > +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000 > #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */ > #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */ > #else >
On 17/12/12 16:11, Will Deacon wrote: > Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore > private memory region") accidentally broke the definition for the base > address of the private peripheral region on revision B Realview-EB > boards. > > This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE. > > Cc: Marc Zyngier <marc.zyngier@arm.com> > Tested-by: Florian Fainelli <florian@openwrt.org> > Signed-off-by: Will Deacon <will.deacon@arm.com> Acked-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm/mach-realview/include/mach/board-eb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h > index 124bce6..a301e61 100644 > --- a/arch/arm/mach-realview/include/mach/board-eb.h > +++ b/arch/arm/mach-realview/include/mach/board-eb.h > @@ -47,7 +47,7 @@ > #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */ > > #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB > -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000 > +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000 > #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */ > #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */ > #else >
On 17/12/12 16:11, Will Deacon wrote: > Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore > private memory region") accidentally broke the definition for the base > address of the private peripheral region on revision B Realview-EB > boards. > > This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE. > > Cc: Marc Zyngier <marc.zyngier@arm.com> > Tested-by: Florian Fainelli <florian@openwrt.org> > Signed-off-by: Will Deacon <will.deacon@arm.com> Acked-by: Marc Zyngier <marc.zyngier@arm.com> > --- > arch/arm/mach-realview/include/mach/board-eb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h > index 124bce6..a301e61 100644 > --- a/arch/arm/mach-realview/include/mach/board-eb.h > +++ b/arch/arm/mach-realview/include/mach/board-eb.h > @@ -47,7 +47,7 @@ > #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */ > > #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB > -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000 > +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000 > #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */ > #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */ > #else >
On Tue, 18 Dec 2012 10:25:52 +0000, Marc Zyngier <marc.zyngier@arm.com> wrote: > On 17/12/12 16:11, Will Deacon wrote: >> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore >> private memory region") accidentally broke the definition for the base >> address of the private peripheral region on revision B Realview-EB >> boards. >> >> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE. >> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Tested-by: Florian Fainelli <florian@openwrt.org> >> Signed-off-by: Will Deacon <will.deacon@arm.com> > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> The ARM email server seems to be acting up. Sorry for the noise. M.
On Tue, Dec 18, 2012 at 10:38:20AM +0000, Marc Zyngier wrote: > On Tue, 18 Dec 2012 10:25:52 +0000, Marc Zyngier <marc.zyngier@arm.com> > wrote: > > On 17/12/12 16:11, Will Deacon wrote: > >> Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore > >> private memory region") accidentally broke the definition for the base > >> address of the private peripheral region on revision B Realview-EB > >> boards. > >> > >> This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE. > >> > >> Cc: Marc Zyngier <marc.zyngier@arm.com> > >> Tested-by: Florian Fainelli <florian@openwrt.org> > >> Signed-off-by: Will Deacon <will.deacon@arm.com> > > > > Acked-by: Marc Zyngier <marc.zyngier@arm.com> > > The ARM email server seems to be acting up. Sorry for the noise. Damn, I just thought you were really into the patch. Will
diff --git a/arch/arm/mach-realview/include/mach/board-eb.h b/arch/arm/mach-realview/include/mach/board-eb.h index 124bce6..a301e61 100644 --- a/arch/arm/mach-realview/include/mach/board-eb.h +++ b/arch/arm/mach-realview/include/mach/board-eb.h @@ -47,7 +47,7 @@ #define REALVIEW_EB_USB_BASE 0x4F000000 /* USB */ #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB -#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x1F000000 +#define REALVIEW_EB11MP_PRIV_MEM_BASE 0x10100000 #define REALVIEW_EB11MP_L220_BASE 0x10102000 /* L220 registers */ #define REALVIEW_EB11MP_SYS_PLD_CTRL1 0xD8 /* Register offset for MPCore sysctl */ #else
Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards. This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE. Cc: Marc Zyngier <marc.zyngier@arm.com> Tested-by: Florian Fainelli <florian@openwrt.org> Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/arm/mach-realview/include/mach/board-eb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)