From patchwork Tue Dec 18 12:06:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 1891421 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 5C4523FC64 for ; Tue, 18 Dec 2012 12:10:27 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tkvxd-0008RD-9t; Tue, 18 Dec 2012 12:07:49 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TkvxZ-0008Pt-Ro for linux-arm-kernel@lists.infradead.org; Tue, 18 Dec 2012 12:07:46 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 18 Dec 2012 12:07:20 +0000 Received: from localhost.localdomain ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 18 Dec 2012 12:07:17 +0000 From: Mark Rutland To: linux-kernel@vger.kernel.org Subject: [RFC PATCH 1/5] ARM: remove useless guard in smp.c Date: Tue, 18 Dec 2012 12:06:54 +0000 Message-Id: <1355832418-31692-2-git-send-email-mark.rutland@arm.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1355832418-31692-1-git-send-email-mark.rutland@arm.com> References: <1355832418-31692-1-git-send-email-mark.rutland@arm.com> X-OriginalArrivalTime: 18 Dec 2012 12:07:17.0922 (UTC) FILETIME=[399DF820:01CDDD18] X-MC-Unique: 112121812072003201 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121218_070746_189967_114C472E X-CRM114-Status: GOOD ( 10.59 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [91.220.42.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Mark Rutland , linux@arm.linux.org.uk, nico@linaro.org, marc.zyngier@arm.com, will.deacon@arm.com, john.stultz@linaro.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Currently we only provide an implementation of smp_timer_broadcast in smp.c if GENERIC_CLOCKEVENTS_BROADCAST is selected. As smp_timer_broadcast is only used in smp.c, smp.c depends on SMP, and GENERIC_CLOCKEVENTS_BROADCAST is selected by SMP, this is unnecessary. This patch removes the redundant guard. Signed-off-by: Mark Rutland Reviewed-by: Stephen Boyd --- arch/arm/kernel/smp.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index fbc8b26..21954bc 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -473,14 +473,10 @@ static void ipi_timer(void) evt->event_handler(evt); } -#ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST static void smp_timer_broadcast(const struct cpumask *mask) { smp_cross_call(mask, IPI_TIMER); } -#else -#define smp_timer_broadcast NULL -#endif static void broadcast_timer_set_mode(enum clock_event_mode mode, struct clock_event_device *evt)