diff mbox

[1/1] ARM: ux500: Disable Power Supply and Battery Management by default

Message ID 1358175470-5041-1-git-send-email-lee.jones@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Lee Jones Jan. 14, 2013, 2:57 p.m. UTC
The AB8500 Battery Management collection of drivers are more than a
little bit broken. There is lots of work still on-going in that area
and it's improving day by day; however, it's not ready to be enabled
by default just yet.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 arch/arm/configs/u8500_defconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Linus Walleij Jan. 21, 2013, 1:51 p.m. UTC | #1
On Mon, Jan 14, 2013 at 3:57 PM, Lee Jones <lee.jones@linaro.org> wrote:

> The AB8500 Battery Management collection of drivers are more than a
> little bit broken. There is lots of work still on-going in that area
> and it's improving day by day; however, it's not ready to be enabled
> by default just yet.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Is this going for fixes (v3.8?)

For v3.9 I think you've submitted a whole lot of patches
actually fixing it up?

Anyway: Acked-by: Linus Walleij <linus.walleij@linaro.org>
since you certainly know the status of this driver better than
me.

Yours,
Linus Walleij
Lee Jones Jan. 21, 2013, 2:02 p.m. UTC | #2
> > The AB8500 Battery Management collection of drivers are more than a
> > little bit broken. There is lots of work still on-going in that area
> > and it's improving day by day; however, it's not ready to be enabled
> > by default just yet.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> Is this going for fixes (v3.8?)
> 
> For v3.9 I think you've submitted a whole lot of patches
> actually fixing it up?

I did submit a bunch of fixes, but more are required.

> Anyway: Acked-by: Linus Walleij <linus.walleij@linaro.org>
> since you certainly know the status of this driver better than
> me.

Thanks.
Lee Jones Jan. 24, 2013, 9:37 a.m. UTC | #3
On Mon, 21 Jan 2013, Linus Walleij wrote:

> On Mon, Jan 14, 2013 at 3:57 PM, Lee Jones <lee.jones@linaro.org> wrote:
> 
> > The AB8500 Battery Management collection of drivers are more than a
> > little bit broken. There is lots of work still on-going in that area
> > and it's improving day by day; however, it's not ready to be enabled
> > by default just yet.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> Is this going for fixes (v3.8?)

Sorry, I thought I answer this, but clearly I didn't.

Can you take this into the -rcs please? It's preventing from a few of
the platforms from booting.

> For v3.9 I think you've submitted a whole lot of patches
> actually fixing it up?
> 
> Anyway: Acked-by: Linus Walleij <linus.walleij@linaro.org>
> since you certainly know the status of this driver better than
> me.
> 
> Yours,
> Linus Walleij
diff mbox

Patch

diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig
index 231dca6..426270f 100644
--- a/arch/arm/configs/u8500_defconfig
+++ b/arch/arm/configs/u8500_defconfig
@@ -66,9 +66,9 @@  CONFIG_SPI=y
 CONFIG_SPI_PL022=y
 CONFIG_GPIO_STMPE=y
 CONFIG_GPIO_TC3589X=y
-CONFIG_POWER_SUPPLY=y
-CONFIG_AB8500_BM=y
-CONFIG_AB8500_BATTERY_THERM_ON_BATCTRL=y
+# CONFIG_POWER_SUPPLY is not set
+# CONFIG_AB8500_BM is not set
+# CONFIG_AB8500_BATTERY_THERM_ON_BATCTRL is not set
 CONFIG_THERMAL=y
 CONFIG_CPU_THERMAL=y
 CONFIG_MFD_STMPE=y