diff mbox

[14/26] mfd: ab8500-debugfs: Fix introduced compiler time warnings

Message ID 1358254566-12419-15-git-send-email-lee.jones@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Lee Jones Jan. 15, 2013, 12:55 p.m. UTC
From: Philippe Langlais <philippe.langlais@stericsson.com>

Some simple fixes regarding pre-processor usage.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Philippe Langlais <philippe.langlais@linaro.org>
---
 drivers/mfd/ab8500-debugfs.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Samuel Ortiz Jan. 27, 2013, 11:53 p.m. UTC | #1
Hi Lee,

On Tue, Jan 15, 2013 at 12:55:54PM +0000, Lee Jones wrote:
> From: Philippe Langlais <philippe.langlais@stericsson.com>
> 
> Some simple fixes regarding pre-processor usage.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Philippe Langlais <philippe.langlais@linaro.org>
> ---
>  drivers/mfd/ab8500-debugfs.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
Here again, please squash this one with the previous one.

Cheers,
Samuel.
Lee Jones Jan. 28, 2013, 8:45 a.m. UTC | #2
On Mon, 28 Jan 2013, Samuel Ortiz wrote:

> Hi Lee,
> 
> On Tue, Jan 15, 2013 at 12:55:54PM +0000, Lee Jones wrote:
> > From: Philippe Langlais <philippe.langlais@stericsson.com>
> > 
> > Some simple fixes regarding pre-processor usage.
> > 
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > Signed-off-by: Philippe Langlais <philippe.langlais@linaro.org>
> > ---
> >  drivers/mfd/ab8500-debugfs.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> Here again, please squash this one with the previous one.

I'll fixup.
diff mbox

Patch

diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 78a8e0c..7698d30 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -776,9 +776,9 @@  static ssize_t hwreg_common_write(char *b, struct hwreg_cfg *cfg,
 	/* args are ok, update target cfg (mainly for read) */
 	*cfg = loc;
 
-#if ABB_HWREG_DEBUG
-	pr_warn("HWREG request: %s, %s, addr=0x%08X, mask=0x%X, shift=%d
-			value=0x%X\n", (write) ? "write" : "read",
+#ifdef ABB_HWREG_DEBUG
+	pr_warn("HWREG request: %s, %s, addr=0x%08X, mask=0x%X, shift=%d"
+			"value=0x%X\n", (write) ? "write" : "read",
 			REG_FMT_DEC(cfg) ? "decimal" : "hexa",
 			cfg->addr, cfg->mask, cfg->shift, val);
 #endif