From patchwork Tue Jan 15 17:45:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Rutland X-Patchwork-Id: 1979691 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id EA20BDF264 for ; Tue, 15 Jan 2013 17:50:20 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TvAbA-0002RE-Kr; Tue, 15 Jan 2013 17:46:59 +0000 Received: from service87.mimecast.com ([91.220.42.44]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TvAb6-0002Ph-KT for linux-arm-kernel@lists.infradead.org; Tue, 15 Jan 2013 17:46:53 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 15 Jan 2013 17:46:50 +0000 Received: from localhost.localdomain ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 15 Jan 2013 17:46:49 +0000 From: Mark Rutland To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv4 01/14] arm: arch_timer: balance device_node refcounting Date: Tue, 15 Jan 2013 17:45:18 +0000 Message-Id: <1358271931-7761-2-git-send-email-mark.rutland@arm.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1358271931-7761-1-git-send-email-mark.rutland@arm.com> References: <1358271931-7761-1-git-send-email-mark.rutland@arm.com> X-OriginalArrivalTime: 15 Jan 2013 17:46:49.0697 (UTC) FILETIME=[4BB52510:01CDF348] X-MC-Unique: 113011517465000701 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130115_124653_140328_2D4A45B2 X-CRM114-Status: GOOD ( 10.45 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [91.220.42.44 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Mark Rutland , c.dall@virtualopensystems.com, Marc.Zyngier@arm.com, catalin.marinas@arm.com, sboyd@codeaurora.org, Will.Deacon@arm.com, santosh.shilimkar@ti.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org When we get the device_node for the arch timer, it's refcount is automatically incremented in of_find_matching_node, but it is never decremented. This patch decrements the refcount on the node after we're finished using it. Reported-by: Will Deacon Signed-off-by: Mark Rutland Acked-by: Santosh Shilimkar --- arch/arm/kernel/arch_timer.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c index c8ef207..6dd73c6 100644 --- a/arch/arm/kernel/arch_timer.c +++ b/arch/arm/kernel/arch_timer.c @@ -488,6 +488,8 @@ int __init arch_timer_of_register(void) for (i = PHYS_SECURE_PPI; i < MAX_TIMER_PPI; i++) arch_timer_ppi[i] = irq_of_parse_and_map(np, i); + of_node_put(np); + /* * If no interrupt provided for virtual timer, we'll have to * stick to the physical timer. It'd better be accessible...