diff mbox

ARM: dts: remove generated .dtb files on clean

Message ID 1358890049-26981-1-git-send-email-nm@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Nishanth Menon Jan. 22, 2013, 9:27 p.m. UTC
commit 5f300acd8ae9f3d4585154370012ffc5c665330f
(ARM: 7152/1: distclean: Remove generated .dtb files)
ensured that dtbs were cleaned up when they were in
arch/arm/boot.
However, with the following commit:
commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
(ARM: dt: change .dtb build rules to build in dts directory)

make clean now leaves dtbs in arch/arm/boot/dts/
untouched. Include dts directory so that clean-files rule
from arch/arm/boot/dts/Makefile is invoked when make
clean is done.

Cc: Dirk Behme <dirk.behme@de.bosch.com>
CC: Grant Likely <grant.likely@secretlab.ca>

Signed-off-by: Nishanth Menon <nm@ti.com>
---
 arch/arm/boot/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Santosh Shilimkar Jan. 30, 2013, 6:29 a.m. UTC | #1
Looping RMK, Arnd

On Wednesday 23 January 2013 02:57 AM, Nishanth Menon wrote:
> commit 5f300acd8ae9f3d4585154370012ffc5c665330f
> (ARM: 7152/1: distclean: Remove generated .dtb files)
> ensured that dtbs were cleaned up when they were in
> arch/arm/boot.
> However, with the following commit:
> commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
> (ARM: dt: change .dtb build rules to build in dts directory)
>
> make clean now leaves dtbs in arch/arm/boot/dts/
> untouched. Include dts directory so that clean-files rule
> from arch/arm/boot/dts/Makefile is invoked when make
> clean is done.
>
> Cc: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Grant Likely <grant.likely@secretlab.ca>
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>   arch/arm/boot/Makefile |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
> index abfce28..3837f97 100644
> --- a/arch/arm/boot/Makefile
> +++ b/arch/arm/boot/Makefile
> @@ -115,4 +115,4 @@ i:
>   	$(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
>   	$(obj)/Image System.map "$(INSTALL_PATH)"
>
> -subdir-	    := bootp compressed
> +subdir-	    := bootp compressed dts
>
Seems to be the valid fix for me.

Regards,
Santosh
Nishanth Menon March 1, 2013, 1:35 a.m. UTC | #2
On Wed, Jan 30, 2013 at 12:29 AM, Santosh Shilimkar
<santosh.shilimkar@ti.com> wrote:
> Looping RMK, Arnd
Gentle query if we are still interested in this:
https://patchwork.kernel.org/patch/2020831/

Looks like linux master still wont delete the dtbs on make clean etc..
I think leaving the stale dtbs
around could have it's set of user errors.
Regards,
Nishanth Menon

>
>
> On Wednesday 23 January 2013 02:57 AM, Nishanth Menon wrote:
>>
>> commit 5f300acd8ae9f3d4585154370012ffc5c665330f
>> (ARM: 7152/1: distclean: Remove generated .dtb files)
>> ensured that dtbs were cleaned up when they were in
>> arch/arm/boot.
>> However, with the following commit:
>> commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8
>> (ARM: dt: change .dtb build rules to build in dts directory)
>>
>> make clean now leaves dtbs in arch/arm/boot/dts/
>> untouched. Include dts directory so that clean-files rule
>> from arch/arm/boot/dts/Makefile is invoked when make
>> clean is done.
>>
>> Cc: Dirk Behme <dirk.behme@de.bosch.com>
>> CC: Grant Likely <grant.likely@secretlab.ca>
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>>   arch/arm/boot/Makefile |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
>> index abfce28..3837f97 100644
>> --- a/arch/arm/boot/Makefile
>> +++ b/arch/arm/boot/Makefile
>> @@ -115,4 +115,4 @@ i:
>>         $(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
>>         $(obj)/Image System.map "$(INSTALL_PATH)"
>>
>> -subdir-            := bootp compressed
>> +subdir-            := bootp compressed dts
>>
> Seems to be the valid fix for me.
>
> Regards,
> Santosh
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Olof Johansson March 1, 2013, 1:47 a.m. UTC | #3
On Thu, Feb 28, 2013 at 5:35 PM, Nishanth Menon <nm@ti.com> wrote:
> On Wed, Jan 30, 2013 at 12:29 AM, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
>> Looping RMK, Arnd
> Gentle query if we are still interested in this:
> https://patchwork.kernel.org/patch/2020831/
>
> Looks like linux master still wont delete the dtbs on make clean etc..
> I think leaving the stale dtbs
> around could have it's set of user errors.

Applied to arm-soc fixes for 3.9.


-Olof
diff mbox

Patch

diff --git a/arch/arm/boot/Makefile b/arch/arm/boot/Makefile
index abfce28..3837f97 100644
--- a/arch/arm/boot/Makefile
+++ b/arch/arm/boot/Makefile
@@ -115,4 +115,4 @@  i:
 	$(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
 	$(obj)/Image System.map "$(INSTALL_PATH)"
 
-subdir-	    := bootp compressed
+subdir-	    := bootp compressed dts