Message ID | 1359095795-9538-1-git-send-email-rnayak@ti.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, 25 Jan 2013, Rajendra Nayak wrote: > dpll_usb needs the clkdm association so the clkdm can be > turned on before a relock. All other dplls for omap4 belong > to the ALWON (always on) domain. > > The association was present as part of the older data file > (clock44xx_data.c) but looks like was accidently dropped with > the common clk convertion. Thanks, queued for v3.8-rc fixes. - Paul
Hi Paul, >> dpll_usb needs the clkdm association so the clkdm can be >> turned on before a relock. All other dplls for omap4 belong >> to the ALWON (always on) domain. >> >> The association was present as part of the older data file >> (clock44xx_data.c) but looks like was accidently dropped with >> the common clk convertion. > > Thanks, queued for v3.8-rc fixes. I just realized that apart from adding the missing .clkdm_name, I also need to populate a .init as part of clk_ops for dpll_usb so the clockdomain lookup can then happen based on the .clkdm_name. I have updated the $Subject patch and posted a v2 (http://marc.info /?l=linux-omap&m=135963212530790&w=2). Would it be possible for you to pick the v2 instead and drop this one from your fixes branch. regards, Rajendra > > - Paul >
On Thu, 31 Jan 2013, Rajendra Nayak wrote: > Hi Paul, > > > > dpll_usb needs the clkdm association so the clkdm can be > > > turned on before a relock. All other dplls for omap4 belong > > > to the ALWON (always on) domain. > > > > > > The association was present as part of the older data file > > > (clock44xx_data.c) but looks like was accidently dropped with > > > the common clk convertion. > > > > Thanks, queued for v3.8-rc fixes. > > I just realized that apart from adding the missing .clkdm_name, I > also need to populate a .init as part of clk_ops for dpll_usb > so the clockdomain lookup can then happen based on the .clkdm_name. > > I have updated the $Subject patch and posted a v2 (http://marc.info > /?l=linux-omap&m=135963212530790&w=2). Would it be possible for you to > pick the v2 instead and drop this one from your fixes branch. No problem. - Paul
diff --git a/arch/arm/mach-omap2/cclock44xx_data.c b/arch/arm/mach-omap2/cclock44xx_data.c index 5789a5e..fdea8da 100644 --- a/arch/arm/mach-omap2/cclock44xx_data.c +++ b/arch/arm/mach-omap2/cclock44xx_data.c @@ -601,6 +601,7 @@ static struct clk_hw_omap dpll_usb_ck_hw = { }, .dpll_data = &dpll_usb_dd, .ops = &clkhwops_omap3_dpll, + .clkdm_name = "l3_init_clkdm", }; DEFINE_STRUCT_CLK(dpll_usb_ck, dpll_usb_ck_parents, dpll_ck_ops);
dpll_usb needs the clkdm association so the clkdm can be turned on before a relock. All other dplls for omap4 belong to the ALWON (always on) domain. The association was present as part of the older data file (clock44xx_data.c) but looks like was accidently dropped with the common clk convertion. More details of the patch which fixed this up in the older data file can be dound here.. http://www.spinics.net/lists/linux-omap/msg63076.html Signed-off-by: Rajendra Nayak <rnayak@ti.com> --- arch/arm/mach-omap2/cclock44xx_data.c | 1 + 1 file changed, 1 insertion(+)