From patchwork Fri Jan 25 22:44:02 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 2047961 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 02C80DF23E for ; Fri, 25 Jan 2013 22:49:43 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tys2n-0004ZZ-TB; Fri, 25 Jan 2013 22:46:45 +0000 Received: from moutng.kundenserver.de ([212.227.17.8]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tys1v-0004Mv-Eo for linux-arm-kernel@lists.infradead.org; Fri, 25 Jan 2013 22:45:56 +0000 Received: from wuerfel.lan (HSI-KBW-46-223-90-92.hsi.kabel-badenwuerttemberg.de [46.223.90.92]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0LgtBS-1Um0cw2raw-00o6gv; Fri, 25 Jan 2013 23:45:44 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/19] ARM: msm: proc_comm_boot_wait should not be __init Date: Fri, 25 Jan 2013 22:44:02 +0000 Message-Id: <1359153858-31992-4-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1359153858-31992-1-git-send-email-arnd@arndb.de> References: <1359123276-15833-1-git-send-email-arnd@arndb.de> <1359153858-31992-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:eRYK/RIYWicap1wo2F5Bt/hJ3/+XF6uJIHv/8Og8PsZ 1z65gu8svf7H+VCezKsu35CG8QX4b+cYLIsuWFa4ItAdX37hwj HxkHNp/8gqP8tunj/KuY77H4pnfStQxPg+zRIMO5+QRQsLnLp3 HgSANrzL2BMf/tNiSTxCb0ByYp1SJnHOirQMrGoKLuz2OQUmRJ Q7gOc+Dr07Ip2txfzytIHDWtQaMaHvA6s+CB+5PdJIvj/OmIHt bO4s+h6o6RsgvcWglcfjfuo5wJAPgRkTCOge1GcynCVJ2su3KF Y3BmGV3qV9JlS2+5YAj6+ssAPLCy0O4Ni6WNzqveSoNxeysfAj SwbCxiydASWKM8UsnCbARAPcJRMgmVCwTfnUsR0M/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130125_174551_916295_B25A9E74 X-CRM114-Status: GOOD ( 13.62 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.8 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Bryan Huntsman , David Brown , linux-kernel@vger.kernel.org, Arnd Bergmann , linux-arm-msm@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org msm_smd_probe is a driver probe function and may get called after the __init time, so it must not call any __init function, as the link-time warning reports. Take away the __init annotation on proc_comm_boot_wait to fix this. Without this patch, building msm_defconfig results in: WARNING: vmlinux.o(.text+0xb048): Section mismatch in reference from the function msm_smd_probe() to the function .init.text:proc_comm_boot_wait() The function msm_smd_probe() references the function __init proc_comm_boot_wait(). This is often because msm_smd_probe lacks a __init annotation or the annotation of proc_comm_boot_wait is wrong. Signed-off-by: Arnd Bergmann Cc: David Brown Cc: Bryan Huntsman Cc: linux-arm-msm@vger.kernel.org --- arch/arm/mach-msm/proc_comm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-msm/proc_comm.h b/arch/arm/mach-msm/proc_comm.h index 12da4ca..e8d043a 100644 --- a/arch/arm/mach-msm/proc_comm.h +++ b/arch/arm/mach-msm/proc_comm.h @@ -253,6 +253,6 @@ enum { (((drvstr) & 0xF) << 17)) int msm_proc_comm(unsigned cmd, unsigned *data1, unsigned *data2); -void __init proc_comm_boot_wait(void); +void proc_comm_boot_wait(void); #endif