| Message ID | 1359464183-6255-4-git-send-email-ldewangan@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/29/2013 05:56 AM, Laxman Dewangan wrote: > NVIDIA's Tegra114 has 32 channels APB DMA controller. Add DT entry for > APB DMA controllers and make it compatible with "nvidia,tegra114-apbdma". The APB DMA controller node needs a clocks property. The same goes for I2C and KBC. I'd like to avoid merging those 3 patches until the Tegra114 clock patches are present, since the nodes won't be useful until then anyway. I expect the clock patches will be merged in 3.10. Related, the I2C driver appears to need updates since the HW isn't 100% backwards-compatible. I would prefer not to apply the patch adding DT nodes for I2C until the relevant driver patches are also posted and checked in. That said, Wolfram said he applied the Tegra114 I2C patch on 1/24, although I don't see it in next-20130128; perhaps he simply didn't push out his next branch to the git server yet? I think the other patches are all OK, so I'll apply them to Tegra's for-3.9/soc-t114 branch.
On Tuesday 29 January 2013 11:12 PM, Stephen Warren wrote: > On 01/29/2013 05:56 AM, Laxman Dewangan wrote: >> NVIDIA's Tegra114 has 32 channels APB DMA controller. Add DT entry for >> APB DMA controllers and make it compatible with "nvidia,tegra114-apbdma". > The APB DMA controller node needs a clocks property. The same goes for > I2C and KBC. I'd like to avoid merging those 3 patches until the > Tegra114 clock patches are present, since the nodes won't be useful > until then anyway. I expect the clock patches will be merged in 3.10. > I think clock patches can be posted on top of this as Peter is working. Although, the driver will fail in clk_get() but still I think this can be apply to populate the dts file with controller specific information.
On 01/29/2013 08:54 PM, Laxman Dewangan wrote: > On Tuesday 29 January 2013 11:12 PM, Stephen Warren wrote: >> On 01/29/2013 05:56 AM, Laxman Dewangan wrote: >>> NVIDIA's Tegra114 has 32 channels APB DMA controller. Add DT entry for >>> APB DMA controllers and make it compatible with >>> "nvidia,tegra114-apbdma". >> The APB DMA controller node needs a clocks property. The same goes for >> I2C and KBC. I'd like to avoid merging those 3 patches until the >> Tegra114 clock patches are present, since the nodes won't be useful >> until then anyway. I expect the clock patches will be merged in 3.10. > > I think clock patches can be posted on top of this as Peter is working. > Although, the driver will fail in clk_get() but still I think this can > be apply to populate the dts file with controller specific information. While it would be physically possible for me to apply these patches now and rely on Peter to add the clocks properties later, there's no point in doing so, since as you say the drivers won't work with just these patches. There will be less churn if we simply wait for the Tegra114 clock driver first, and then apply patches to add complete and working DT nodes for all the devices.
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi index 9ce1a68..74f6a77 100644 --- a/arch/arm/boot/dts/tegra114.dtsi +++ b/arch/arm/boot/dts/tegra114.dtsi @@ -37,6 +37,43 @@ reg = <0x6000c004 0x14c>; }; + apbdma: dma { + compatible = "nvidia,tegra114-apbdma"; + reg = <0x6000a000 0x1400>; + interrupts = <0 104 0x04 + 0 105 0x04 + 0 106 0x04 + 0 107 0x04 + 0 108 0x04 + 0 109 0x04 + 0 110 0x04 + 0 111 0x04 + 0 112 0x04 + 0 113 0x04 + 0 114 0x04 + 0 115 0x04 + 0 116 0x04 + 0 117 0x04 + 0 118 0x04 + 0 119 0x04 + 0 128 0x04 + 0 129 0x04 + 0 130 0x04 + 0 131 0x04 + 0 132 0x04 + 0 133 0x04 + 0 134 0x04 + 0 135 0x04 + 0 136 0x04 + 0 137 0x04 + 0 138 0x04 + 0 139 0x04 + 0 140 0x04 + 0 141 0x04 + 0 142 0x04 + 0 143 0x04>; + }; + gpio: gpio { compatible = "nvidia,tegra114-gpio", "nvidia,tegra30-gpio"; reg = <0x6000d000 0x1000>;
NVIDIA's Tegra114 has 32 channels APB DMA controller. Add DT entry for APB DMA controllers and make it compatible with "nvidia,tegra114-apbdma". Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- arch/arm/boot/dts/tegra114.dtsi | 37 +++++++++++++++++++++++++++++++++++++ 1 files changed, 37 insertions(+), 0 deletions(-)