| Message ID | 1359559782-14552-3-git-send-email-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jan 30, 2013 at 04:29:38PM +0100, Sascha Hauer wrote: > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > This adds two little devicetree helper functions for determining the > dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from > the devicetree. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > drivers/usb/usb-common.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/usb/of.h | 27 ++++++++++++++++++ > include/linux/usb/otg.h | 7 +++++ > include/linux/usb/phy.h | 9 ++++++ > 4 files changed, 112 insertions(+) > create mode 100644 include/linux/usb/of.h > > diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c > index d29503e..1c0292c 100644 > --- a/drivers/usb/usb-common.c > +++ b/drivers/usb/usb-common.c > @@ -14,6 +14,9 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/usb/ch9.h> > +#include <linux/of.h> > +#include <linux/usb/of.h> > +#include <linux/usb/otg.h> > > const char *usb_speed_string(enum usb_device_speed speed) > { > @@ -32,4 +35,70 @@ const char *usb_speed_string(enum usb_device_speed speed) > } > EXPORT_SYMBOL_GPL(usb_speed_string); > > +#ifdef CONFIG_OF > +static const char *usb_dr_modes[] = { > + [USB_DR_MODE_UNKNOWN] = "", > + [USB_DR_MODE_HOST] = "host", > + [USB_DR_MODE_PERIPHERAL] = "peripheral", > + [USB_DR_MODE_OTG] = "otg", > +}; > + > +/** > + * of_usb_get_dr_mode - Get dual role mode for given device_node > + * @np: Pointer to the given device_node > + * > + * The function gets phy interface string from property 'dr_mode', > + * and returns the correspondig enum usb_phy_dr_mode > + */ > +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) The word "phy" at usb_phy_dr_mode may cause misunderstand, just usb_dr_mode is ok > +{ > + const char *dr_mode; > + int err, i; > + > + err = of_property_read_string(np, "dr_mode", &dr_mode); > + if (err < 0) > + return USB_DR_MODE_UNKNOWN; > + > + for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) > + if (!strcasecmp(dr_mode, usb_dr_modes[i])) > + return i; Just curious, why not using strcmp? > + > + return USB_DR_MODE_UNKNOWN; > +} > + > +#ifdef CONFIG_OF > +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np); > +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np); > +#else > +static inline enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np) > +{ > + return USBPHY_INTERFACE_MODE_NA; > +} > + > +static inline enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) > +{ > + return USB_DR_MODE_UNKNOWN; > +} For, dr_mode, if value has not existed, you use *_UNKNOWN, why for usbphy, you use *_NA. It is better uniform.
Hi, On Wednesday 30 January 2013 08:59 PM, Sascha Hauer wrote: > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > This adds two little devicetree helper functions for determining the > dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from > the devicetree. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > --- > drivers/usb/usb-common.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/usb/of.h | 27 ++++++++++++++++++ > include/linux/usb/otg.h | 7 +++++ > include/linux/usb/phy.h | 9 ++++++ > 4 files changed, 112 insertions(+) > create mode 100644 include/linux/usb/of.h > > diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c > index d29503e..1c0292c 100644 > --- a/drivers/usb/usb-common.c > +++ b/drivers/usb/usb-common.c > @@ -14,6 +14,9 @@ > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/usb/ch9.h> > +#include <linux/of.h> > +#include <linux/usb/of.h> > +#include <linux/usb/otg.h> > > const char *usb_speed_string(enum usb_device_speed speed) > { > @@ -32,4 +35,70 @@ const char *usb_speed_string(enum usb_device_speed speed) > } > EXPORT_SYMBOL_GPL(usb_speed_string); > > +#ifdef CONFIG_OF > +static const char *usb_dr_modes[] = { > + [USB_DR_MODE_UNKNOWN] = "", > + [USB_DR_MODE_HOST] = "host", > + [USB_DR_MODE_PERIPHERAL] = "peripheral", > + [USB_DR_MODE_OTG] = "otg", > +}; > + > +/** > + * of_usb_get_dr_mode - Get dual role mode for given device_node > + * @np: Pointer to the given device_node > + * > + * The function gets phy interface string from property 'dr_mode', > + * and returns the correspondig enum usb_phy_dr_mode > + */ > +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) > +{ > + const char *dr_mode; > + int err, i; > + > + err = of_property_read_string(np, "dr_mode", &dr_mode); > + if (err < 0) > + return USB_DR_MODE_UNKNOWN; > + > + for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) > + if (!strcasecmp(dr_mode, usb_dr_modes[i])) > + return i; > + > + return USB_DR_MODE_UNKNOWN; > +} > +EXPORT_SYMBOL_GPL(of_usb_get_dr_mode); > + > +static const char *usbphy_modes[] = { > + [USBPHY_INTERFACE_MODE_NA] = "", > + [USBPHY_INTERFACE_MODE_UTMI] = "utmi", > + [USBPHY_INTERFACE_MODE_UTMIW] = "utmi_wide", > + [USBPHY_INTERFACE_MODE_ULPI] = "ulpi", > + [USBPHY_INTERFACE_MODE_SERIAL] = "serial", > + [USBPHY_INTERFACE_MODE_HSIC] = "hsic", > +}; > + > +/** > + * of_get_usbphy_mode - Get phy mode for given device_node %s/of_get_usbphy_mode/of_usb_get_phy_mode > + * @np: Pointer to the given device_node > + * > + * The function gets phy interface string from property 'phy_type', > + * and returns the correspondig enum usb_phy_interface > + */ > +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np) > +{ You agreed to move this function inside usb/phy.. no? Thanks Kishon
On Thu, Jan 31, 2013 at 11:44:21AM +0530, kishon wrote: > Hi, > > On Wednesday 30 January 2013 08:59 PM, Sascha Hauer wrote: > >From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > > >This adds two little devicetree helper functions for determining the > >dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from > >the devicetree. > > > >Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > >Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > >Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > >--- > > drivers/usb/usb-common.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/usb/of.h | 27 ++++++++++++++++++ > > include/linux/usb/otg.h | 7 +++++ > > include/linux/usb/phy.h | 9 ++++++ > > 4 files changed, 112 insertions(+) > > create mode 100644 include/linux/usb/of.h > > > >diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c > >index d29503e..1c0292c 100644 > >--- a/drivers/usb/usb-common.c > >+++ b/drivers/usb/usb-common.c > >@@ -14,6 +14,9 @@ > > #include <linux/kernel.h> > > #include <linux/module.h> > > #include <linux/usb/ch9.h> > >+#include <linux/of.h> > >+#include <linux/usb/of.h> > >+#include <linux/usb/otg.h> > > > > const char *usb_speed_string(enum usb_device_speed speed) > > { > >@@ -32,4 +35,70 @@ const char *usb_speed_string(enum usb_device_speed speed) > > } > > EXPORT_SYMBOL_GPL(usb_speed_string); > > > >+#ifdef CONFIG_OF > >+static const char *usb_dr_modes[] = { > >+ [USB_DR_MODE_UNKNOWN] = "", > >+ [USB_DR_MODE_HOST] = "host", > >+ [USB_DR_MODE_PERIPHERAL] = "peripheral", > >+ [USB_DR_MODE_OTG] = "otg", > >+}; > >+ > >+/** > >+ * of_usb_get_dr_mode - Get dual role mode for given device_node > >+ * @np: Pointer to the given device_node > >+ * > >+ * The function gets phy interface string from property 'dr_mode', > >+ * and returns the correspondig enum usb_phy_dr_mode > >+ */ > >+enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) > >+{ > >+ const char *dr_mode; > >+ int err, i; > >+ > >+ err = of_property_read_string(np, "dr_mode", &dr_mode); > >+ if (err < 0) > >+ return USB_DR_MODE_UNKNOWN; > >+ > >+ for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) > >+ if (!strcasecmp(dr_mode, usb_dr_modes[i])) > >+ return i; > >+ > >+ return USB_DR_MODE_UNKNOWN; > >+} > >+EXPORT_SYMBOL_GPL(of_usb_get_dr_mode); > >+ > >+static const char *usbphy_modes[] = { > >+ [USBPHY_INTERFACE_MODE_NA] = "", > >+ [USBPHY_INTERFACE_MODE_UTMI] = "utmi", > >+ [USBPHY_INTERFACE_MODE_UTMIW] = "utmi_wide", > >+ [USBPHY_INTERFACE_MODE_ULPI] = "ulpi", > >+ [USBPHY_INTERFACE_MODE_SERIAL] = "serial", > >+ [USBPHY_INTERFACE_MODE_HSIC] = "hsic", > >+}; > >+ > >+/** > >+ * of_get_usbphy_mode - Get phy mode for given device_node > > %s/of_get_usbphy_mode/of_usb_get_phy_mode > >+ * @np: Pointer to the given device_node > >+ * > >+ * The function gets phy interface string from property 'phy_type', > >+ * and returns the correspondig enum usb_phy_interface > >+ */ > >+enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np) > >+{ > > You agreed to move this function inside usb/phy.. no? Yes, I did, but as mentioned in the introduction mail, the chipidea driver has to determine the phy type even when phy support (aka CONFIG_USB_OTG_UTILS) is disabled, so I can't put it in phy/phy.c. I could add a phy/of.c though. Would that be better? Sascha
On Thu, Jan 31, 2013 at 10:30:36AM +0800, Peter Chen wrote: > On Wed, Jan 30, 2013 at 04:29:38PM +0100, Sascha Hauer wrote: > > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > > > This adds two little devicetree helper functions for determining the > > dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from > > the devicetree. > > > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > --- > > drivers/usb/usb-common.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/usb/of.h | 27 ++++++++++++++++++ > > include/linux/usb/otg.h | 7 +++++ > > include/linux/usb/phy.h | 9 ++++++ > > 4 files changed, 112 insertions(+) > > create mode 100644 include/linux/usb/of.h > > > > diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c > > index d29503e..1c0292c 100644 > > --- a/drivers/usb/usb-common.c > > +++ b/drivers/usb/usb-common.c > > @@ -14,6 +14,9 @@ > > #include <linux/kernel.h> > > #include <linux/module.h> > > #include <linux/usb/ch9.h> > > +#include <linux/of.h> > > +#include <linux/usb/of.h> > > +#include <linux/usb/otg.h> > > > > const char *usb_speed_string(enum usb_device_speed speed) > > { > > @@ -32,4 +35,70 @@ const char *usb_speed_string(enum usb_device_speed speed) > > } > > EXPORT_SYMBOL_GPL(usb_speed_string); > > > > +#ifdef CONFIG_OF > > +static const char *usb_dr_modes[] = { > > + [USB_DR_MODE_UNKNOWN] = "", > > + [USB_DR_MODE_HOST] = "host", > > + [USB_DR_MODE_PERIPHERAL] = "peripheral", > > + [USB_DR_MODE_OTG] = "otg", > > +}; > > + > > +/** > > + * of_usb_get_dr_mode - Get dual role mode for given device_node > > + * @np: Pointer to the given device_node > > + * > > + * The function gets phy interface string from property 'dr_mode', > > + * and returns the correspondig enum usb_phy_dr_mode > > + */ > > +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) > The word "phy" at usb_phy_dr_mode may cause misunderstand, just usb_dr_mode > is ok ok, changed. > > +{ > > + const char *dr_mode; > > + int err, i; > > + > > + err = of_property_read_string(np, "dr_mode", &dr_mode); > > + if (err < 0) > > + return USB_DR_MODE_UNKNOWN; > > + > > + for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) > > + if (!strcasecmp(dr_mode, usb_dr_modes[i])) > > + return i; > Just curious, why not using strcmp? Probably because this is based on drivers/of/of_net.c which uses strcasecmp. I never heard that devicetrees are case insensitive, so I'll change this to strcmp. > > + > > + return USB_DR_MODE_UNKNOWN; > > +} > > + > > +#ifdef CONFIG_OF > > +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np); > > +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np); > > +#else > > +static inline enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np) > > +{ > > + return USBPHY_INTERFACE_MODE_NA; > > +} > > + > > +static inline enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) > > +{ > > + return USB_DR_MODE_UNKNOWN; > > +} > For, dr_mode, if value has not existed, you use *_UNKNOWN, why > for usbphy, you use *_NA. It is better uniform. yup, fixed. Sascha
On Thursday 31 January 2013 01:13 PM, Sascha Hauer wrote: > On Thu, Jan 31, 2013 at 11:44:21AM +0530, kishon wrote: >> Hi, >> >> On Wednesday 30 January 2013 08:59 PM, Sascha Hauer wrote: >>> From: Michael Grzeschik <m.grzeschik@pengutronix.de> >>> >>> This adds two little devicetree helper functions for determining the >>> dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from >>> the devicetree. >>> >>> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> >>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> >>> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> >>> --- >>> drivers/usb/usb-common.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++ >>> include/linux/usb/of.h | 27 ++++++++++++++++++ >>> include/linux/usb/otg.h | 7 +++++ >>> include/linux/usb/phy.h | 9 ++++++ >>> 4 files changed, 112 insertions(+) >>> create mode 100644 include/linux/usb/of.h >>> >>> diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c >>> index d29503e..1c0292c 100644 >>> --- a/drivers/usb/usb-common.c >>> +++ b/drivers/usb/usb-common.c >>> @@ -14,6 +14,9 @@ >>> #include <linux/kernel.h> >>> #include <linux/module.h> >>> #include <linux/usb/ch9.h> >>> +#include <linux/of.h> >>> +#include <linux/usb/of.h> >>> +#include <linux/usb/otg.h> >>> >>> const char *usb_speed_string(enum usb_device_speed speed) >>> { >>> @@ -32,4 +35,70 @@ const char *usb_speed_string(enum usb_device_speed speed) >>> } >>> EXPORT_SYMBOL_GPL(usb_speed_string); >>> >>> +#ifdef CONFIG_OF >>> +static const char *usb_dr_modes[] = { >>> + [USB_DR_MODE_UNKNOWN] = "", >>> + [USB_DR_MODE_HOST] = "host", >>> + [USB_DR_MODE_PERIPHERAL] = "peripheral", >>> + [USB_DR_MODE_OTG] = "otg", >>> +}; >>> + >>> +/** >>> + * of_usb_get_dr_mode - Get dual role mode for given device_node >>> + * @np: Pointer to the given device_node >>> + * >>> + * The function gets phy interface string from property 'dr_mode', >>> + * and returns the correspondig enum usb_phy_dr_mode >>> + */ >>> +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) >>> +{ >>> + const char *dr_mode; >>> + int err, i; >>> + >>> + err = of_property_read_string(np, "dr_mode", &dr_mode); >>> + if (err < 0) >>> + return USB_DR_MODE_UNKNOWN; >>> + >>> + for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) >>> + if (!strcasecmp(dr_mode, usb_dr_modes[i])) >>> + return i; >>> + >>> + return USB_DR_MODE_UNKNOWN; >>> +} >>> +EXPORT_SYMBOL_GPL(of_usb_get_dr_mode); >>> + >>> +static const char *usbphy_modes[] = { >>> + [USBPHY_INTERFACE_MODE_NA] = "", >>> + [USBPHY_INTERFACE_MODE_UTMI] = "utmi", >>> + [USBPHY_INTERFACE_MODE_UTMIW] = "utmi_wide", >>> + [USBPHY_INTERFACE_MODE_ULPI] = "ulpi", >>> + [USBPHY_INTERFACE_MODE_SERIAL] = "serial", >>> + [USBPHY_INTERFACE_MODE_HSIC] = "hsic", >>> +}; >>> + >>> +/** >>> + * of_get_usbphy_mode - Get phy mode for given device_node >> >> %s/of_get_usbphy_mode/of_usb_get_phy_mode >>> + * @np: Pointer to the given device_node >>> + * >>> + * The function gets phy interface string from property 'phy_type', >>> + * and returns the correspondig enum usb_phy_interface >>> + */ >>> +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np) >>> +{ >> >> You agreed to move this function inside usb/phy.. no? > > Yes, I did, but as mentioned in the introduction mail, the chipidea > driver has to determine the phy type even when phy support (aka > CONFIG_USB_OTG_UTILS) is disabled, so I can't put it in phy/phy.c. > > I could add a phy/of.c though. Would that be better? Yes. I think that would be better. Thanks Kishon
diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c index d29503e..1c0292c 100644 --- a/drivers/usb/usb-common.c +++ b/drivers/usb/usb-common.c @@ -14,6 +14,9 @@ #include <linux/kernel.h> #include <linux/module.h> #include <linux/usb/ch9.h> +#include <linux/of.h> +#include <linux/usb/of.h> +#include <linux/usb/otg.h> const char *usb_speed_string(enum usb_device_speed speed) { @@ -32,4 +35,70 @@ const char *usb_speed_string(enum usb_device_speed speed) } EXPORT_SYMBOL_GPL(usb_speed_string); +#ifdef CONFIG_OF +static const char *usb_dr_modes[] = { + [USB_DR_MODE_UNKNOWN] = "", + [USB_DR_MODE_HOST] = "host", + [USB_DR_MODE_PERIPHERAL] = "peripheral", + [USB_DR_MODE_OTG] = "otg", +}; + +/** + * of_usb_get_dr_mode - Get dual role mode for given device_node + * @np: Pointer to the given device_node + * + * The function gets phy interface string from property 'dr_mode', + * and returns the correspondig enum usb_phy_dr_mode + */ +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) +{ + const char *dr_mode; + int err, i; + + err = of_property_read_string(np, "dr_mode", &dr_mode); + if (err < 0) + return USB_DR_MODE_UNKNOWN; + + for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) + if (!strcasecmp(dr_mode, usb_dr_modes[i])) + return i; + + return USB_DR_MODE_UNKNOWN; +} +EXPORT_SYMBOL_GPL(of_usb_get_dr_mode); + +static const char *usbphy_modes[] = { + [USBPHY_INTERFACE_MODE_NA] = "", + [USBPHY_INTERFACE_MODE_UTMI] = "utmi", + [USBPHY_INTERFACE_MODE_UTMIW] = "utmi_wide", + [USBPHY_INTERFACE_MODE_ULPI] = "ulpi", + [USBPHY_INTERFACE_MODE_SERIAL] = "serial", + [USBPHY_INTERFACE_MODE_HSIC] = "hsic", +}; + +/** + * of_get_usbphy_mode - Get phy mode for given device_node + * @np: Pointer to the given device_node + * + * The function gets phy interface string from property 'phy_type', + * and returns the correspondig enum usb_phy_interface + */ +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np) +{ + const char *phy_type; + int err, i; + + err = of_property_read_string(np, "phy_type", &phy_type); + if (err < 0) + return USBPHY_INTERFACE_MODE_NA; + + for (i = 0; i < ARRAY_SIZE(usbphy_modes); i++) + if (!strcasecmp(phy_type, usbphy_modes[i])) + return i; + + return USBPHY_INTERFACE_MODE_NA; +} +EXPORT_SYMBOL_GPL(of_usb_get_phy_mode); +#endif + MODULE_LICENSE("GPL"); diff --git a/include/linux/usb/of.h b/include/linux/usb/of.h new file mode 100644 index 0000000..53d69da --- /dev/null +++ b/include/linux/usb/of.h @@ -0,0 +1,27 @@ +/* + * OF helpers for usb devices. + * + * This file is released under the GPLv2 + */ + +#ifndef __LINUX_USB_OF_H +#define __LINUX_USB_OF_H + +#include <linux/usb/phy.h> + +#ifdef CONFIG_OF +enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np); +enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np); +#else +static inline enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np) +{ + return USBPHY_INTERFACE_MODE_NA; +} + +static inline enum usb_phy_dr_mode of_usb_get_dr_mode(struct device_node *np) +{ + return USB_DR_MODE_UNKNOWN; +} +#endif + +#endif /* __LINUX_USB_OF_H */ diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h index e8a5fe8..9c012f0 100644 --- a/include/linux/usb/otg.h +++ b/include/linux/usb/otg.h @@ -99,4 +99,11 @@ otg_start_srp(struct usb_otg *otg) /* for OTG controller drivers (and maybe other stuff) */ extern int usb_bus_start_enum(struct usb_bus *bus, unsigned port_num); +enum usb_phy_dr_mode { + USB_DR_MODE_UNKNOWN, + USB_DR_MODE_HOST, + USB_DR_MODE_PERIPHERAL, + USB_DR_MODE_OTG, +}; + #endif /* __LINUX_USB_OTG_H */ diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h index 15847cb..a5170d8 100644 --- a/include/linux/usb/phy.h +++ b/include/linux/usb/phy.h @@ -12,6 +12,15 @@ #include <linux/notifier.h> #include <linux/usb.h> +enum usb_phy_interface { + USBPHY_INTERFACE_MODE_NA, + USBPHY_INTERFACE_MODE_UTMI, + USBPHY_INTERFACE_MODE_UTMIW, + USBPHY_INTERFACE_MODE_ULPI, + USBPHY_INTERFACE_MODE_SERIAL, + USBPHY_INTERFACE_MODE_HSIC, +}; + enum usb_phy_events { USB_EVENT_NONE, /* no events or cable disconnected */ USB_EVENT_VBUS, /* vbus valid event */