| Message ID | 1359714424-21167-1-git-send-email-anilkumar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Quoting AnilKumar Ch (2013-02-01 02:27:04) > Add missing soc_is_am33xx() check in noncore DPLL set rate function. > Without this, dpll set_rate function throughs warnings for am33xx > family of devices. > > Signed-off-by: AnilKumar Ch <anilkumar@ti.com> I think that only 3430 needs the freqsel calculation. If this is true, then I think it would be better to just have a check for cpu_is_3430() instead of appending new SoCs to the list that do not care about the freqsel calculation. Regards, Mike > --- > arch/arm/mach-omap2/dpll3xxx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c > index 0a02aab5..4bb3f78 100644 > --- a/arch/arm/mach-omap2/dpll3xxx.c > +++ b/arch/arm/mach-omap2/dpll3xxx.c > @@ -501,7 +501,8 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, > return -EINVAL; > > /* No freqsel on OMAP4 and OMAP3630 */ > - if (!cpu_is_omap44xx() && !cpu_is_omap3630()) { > + if (!cpu_is_omap44xx() && !cpu_is_omap3630() && > + !soc_is_am33xx()) { > freqsel = _omap3_dpll_compute_freqsel(clk, > dd->last_rounded_n); > WARN_ON(!freqsel); > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/dpll3xxx.c b/arch/arm/mach-omap2/dpll3xxx.c index 0a02aab5..4bb3f78 100644 --- a/arch/arm/mach-omap2/dpll3xxx.c +++ b/arch/arm/mach-omap2/dpll3xxx.c @@ -501,7 +501,8 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate, return -EINVAL; /* No freqsel on OMAP4 and OMAP3630 */ - if (!cpu_is_omap44xx() && !cpu_is_omap3630()) { + if (!cpu_is_omap44xx() && !cpu_is_omap3630() && + !soc_is_am33xx()) { freqsel = _omap3_dpll_compute_freqsel(clk, dd->last_rounded_n); WARN_ON(!freqsel);
Add missing soc_is_am33xx() check in noncore DPLL set rate function. Without this, dpll set_rate function throughs warnings for am33xx family of devices. Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- arch/arm/mach-omap2/dpll3xxx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)