| Message ID | 1359993540-20780-11-git-send-email-rogerq@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: > Adds device nodes for HS USB Host module, TLL module, > OHCI and EHCI controllers. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 files changed, 30 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 739bb79..3429280 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -529,5 +529,35 @@ > ti,hwmods = "timer11"; > ti,timer-pwm; > }; > + > + usbhstll: usbhstll@0x4a062000 { > + compatible = "ti,usbhs-tll"; > + reg = <0x4a062000 0x1000>; > + interrupts = <0 78 0x4>; > + ti,hwmods = "usb_tll_hs"; > + }; > + > + usbhshost: usbhshost@0x4a064000 { > + compatible = "ti,usbhs-host"; > + reg = <0x4a064000 0x800>; > + ti,hwmods = "usb_host_hs"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + usbhsohci: ohci@0x4a064800 { > + compatible = "ti,omap3-ohci", "usb-ohci"; > + reg = <0x4a064800 0x400>; > + interrupt-parent = <&gic>; Just curious.. Were you facing issues if you are not having interrupt-parent here? It's also missing in your dt node usbhstll. Thanks Kishon
On Mon, Feb 04, 2013 at 05:58:57PM +0200, Roger Quadros wrote: > Adds device nodes for HS USB Host module, TLL module, > OHCI and EHCI controllers. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 files changed, 30 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi > index 739bb79..3429280 100644 > --- a/arch/arm/boot/dts/omap4.dtsi > +++ b/arch/arm/boot/dts/omap4.dtsi > @@ -529,5 +529,35 @@ > ti,hwmods = "timer11"; > ti,timer-pwm; > }; > + > + usbhstll: usbhstll@0x4a062000 { > + compatible = "ti,usbhs-tll"; > + reg = <0x4a062000 0x1000>; > + interrupts = <0 78 0x4>; > + ti,hwmods = "usb_tll_hs"; > + }; > + > + usbhshost: usbhshost@0x4a064000 { > + compatible = "ti,usbhs-host"; > + reg = <0x4a064000 0x800>; > + ti,hwmods = "usb_host_hs"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + usbhsohci: ohci@0x4a064800 { usbhsohci is a bit misleading :-) How about we stick to ohci and ehci for these nodes ? :-)
On 02/05/2013 08:24 AM, kishon wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> Adds device nodes for HS USB Host module, TLL module, >> OHCI and EHCI controllers. >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++ >> 1 files changed, 30 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi >> index 739bb79..3429280 100644 >> --- a/arch/arm/boot/dts/omap4.dtsi >> +++ b/arch/arm/boot/dts/omap4.dtsi >> @@ -529,5 +529,35 @@ >> ti,hwmods = "timer11"; >> ti,timer-pwm; >> }; >> + >> + usbhstll: usbhstll@0x4a062000 { >> + compatible = "ti,usbhs-tll"; >> + reg = <0x4a062000 0x1000>; >> + interrupts = <0 78 0x4>; >> + ti,hwmods = "usb_tll_hs"; >> + }; >> + >> + usbhshost: usbhshost@0x4a064000 { >> + compatible = "ti,usbhs-host"; >> + reg = <0x4a064000 0x800>; >> + ti,hwmods = "usb_host_hs"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + usbhsohci: ohci@0x4a064800 { >> + compatible = "ti,omap3-ohci", "usb-ohci"; >> + reg = <0x4a064800 0x400>; >> + interrupt-parent = <&gic>; > > Just curious.. Were you facing issues if you are not having interrupt-parent here? It's also missing in your dt node usbhstll. Yes I was. Interrupt-parent is not there in any of the children which are at the same level as usbhstll. cheers, -roger
On Tuesday 05 February 2013 02:24 PM, Roger Quadros wrote: > On 02/05/2013 08:24 AM, kishon wrote: >> On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >>> Adds device nodes for HS USB Host module, TLL module, >>> OHCI and EHCI controllers. >>> >>> Signed-off-by: Roger Quadros <rogerq@ti.com> >>> --- >>> arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++ >>> 1 files changed, 30 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi >>> index 739bb79..3429280 100644 >>> --- a/arch/arm/boot/dts/omap4.dtsi >>> +++ b/arch/arm/boot/dts/omap4.dtsi >>> @@ -529,5 +529,35 @@ >>> ti,hwmods = "timer11"; >>> ti,timer-pwm; >>> }; >>> + >>> + usbhstll: usbhstll@0x4a062000 { >>> + compatible = "ti,usbhs-tll"; >>> + reg = <0x4a062000 0x1000>; >>> + interrupts = <0 78 0x4>; >>> + ti,hwmods = "usb_tll_hs"; >>> + }; >>> + >>> + usbhshost: usbhshost@0x4a064000 { >>> + compatible = "ti,usbhs-host"; >>> + reg = <0x4a064000 0x800>; >>> + ti,hwmods = "usb_host_hs"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + ranges; >>> + >>> + usbhsohci: ohci@0x4a064800 { >>> + compatible = "ti,omap3-ohci", "usb-ohci"; >>> + reg = <0x4a064800 0x400>; >>> + interrupt-parent = <&gic>; >> >> Just curious.. Were you facing issues if you are not having interrupt-parent here? It's also missing in your dt node usbhstll. > > Yes I was. Interrupt-parent is not there in any of the children which are at the same level as usbhstll. Cool. Thought so :-) Thanks Kishon
On 02/05/2013 09:41 AM, Felipe Balbi wrote: > On Mon, Feb 04, 2013 at 05:58:57PM +0200, Roger Quadros wrote: >> Adds device nodes for HS USB Host module, TLL module, >> OHCI and EHCI controllers. >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++ >> 1 files changed, 30 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi >> index 739bb79..3429280 100644 >> --- a/arch/arm/boot/dts/omap4.dtsi >> +++ b/arch/arm/boot/dts/omap4.dtsi >> @@ -529,5 +529,35 @@ >> ti,hwmods = "timer11"; >> ti,timer-pwm; >> }; >> + >> + usbhstll: usbhstll@0x4a062000 { >> + compatible = "ti,usbhs-tll"; >> + reg = <0x4a062000 0x1000>; >> + interrupts = <0 78 0x4>; >> + ti,hwmods = "usb_tll_hs"; >> + }; >> + >> + usbhshost: usbhshost@0x4a064000 { >> + compatible = "ti,usbhs-host"; >> + reg = <0x4a064000 0x800>; >> + ti,hwmods = "usb_host_hs"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + usbhsohci: ohci@0x4a064800 { > > usbhsohci is a bit misleading :-) > > How about we stick to ohci and ehci for these nodes ? :-) > Was just thinking of a unique label that will point to the OHCI/EHCI controller in the HS USB subsystem. We need the label to provide PHY information in the board DT. If we are sure we won't have another OHCI/EHCI controller then I can just use ehci/ohci. cheers, -roger
diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 739bb79..3429280 100644 --- a/arch/arm/boot/dts/omap4.dtsi +++ b/arch/arm/boot/dts/omap4.dtsi @@ -529,5 +529,35 @@ ti,hwmods = "timer11"; ti,timer-pwm; }; + + usbhstll: usbhstll@0x4a062000 { + compatible = "ti,usbhs-tll"; + reg = <0x4a062000 0x1000>; + interrupts = <0 78 0x4>; + ti,hwmods = "usb_tll_hs"; + }; + + usbhshost: usbhshost@0x4a064000 { + compatible = "ti,usbhs-host"; + reg = <0x4a064000 0x800>; + ti,hwmods = "usb_host_hs"; + #address-cells = <1>; + #size-cells = <1>; + ranges; + + usbhsohci: ohci@0x4a064800 { + compatible = "ti,omap3-ohci", "usb-ohci"; + reg = <0x4a064800 0x400>; + interrupt-parent = <&gic>; + interrupts = <0 76 0x4>; + }; + + usbhsehci: ehci@0x4a064c00 { + compatible = "ti,omap-ehci", "usb-ehci"; + reg = <0x4a064c00 0x400>; + interrupt-parent = <&gic>; + interrupts = <0 77 0x4>; + }; + }; }; };
Adds device nodes for HS USB Host module, TLL module, OHCI and EHCI controllers. Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm/boot/dts/omap4.dtsi | 30 ++++++++++++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-)