| Message ID | 135fba212abd740584a2547903cc8d175417344c.1423736523.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 12, 2015 at 10:22:07AM +0000, Michal Simek wrote: > Add OCM node for all zynq boards. OCM location > can changed but for all current boards this > is the location where OCM is.` > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > This patch is done based on discussion here. > https://lkml.org/lkml/2014/12/1/396 > > There are some ways how to do it. > OCM location can be changed but board DTS files > can easily rewrite it. > The problem which there is that node has address > in it but maybe someone can suggest better solution. Given that the node is so simple, can't this be pushed down into the board files? So long as the label is consistent anything else that's referring to it should still work. Thanks, Mark. > --- > arch/arm/boot/dts/zynq-7000.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi > index a5cd2eda3edf..d55a8b365a6c 100644 > --- a/arch/arm/boot/dts/zynq-7000.dtsi > +++ b/arch/arm/boot/dts/zynq-7000.dtsi > @@ -150,6 +150,11 @@ > reg = <0xf8006000 0x1000>; > }; > > + ocm: sram@fffc0000 { > + compatible = "mmio-sram"; > + reg = <0xfffc0000 0x10000>; > + }; > + > uart0: serial@e0000000 { > compatible = "xlnx,xuartps", "cdns,uart-r1p8"; > status = "disabled"; > -- > 1.8.2.3 > >
Hi Mark, On 02/12/2015 11:26 AM, Mark Rutland wrote: > On Thu, Feb 12, 2015 at 10:22:07AM +0000, Michal Simek wrote: >> Add OCM node for all zynq boards. OCM location >> can changed but for all current boards this >> is the location where OCM is.` >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> This patch is done based on discussion here. >> https://lkml.org/lkml/2014/12/1/396 >> >> There are some ways how to do it. >> OCM location can be changed but board DTS files >> can easily rewrite it. >> The problem which there is that node has address >> in it but maybe someone can suggest better solution. > > Given that the node is so simple, can't this be pushed down into the > board files? So long as the label is consistent anything else that's > referring to it should still work. ok. Let me send v2 with moving stuff to board file and reference bus. (I expect you will want to use different solution but will see). Thanks, Michal
On Thu, Feb 12, 2015 at 10:26:16AM +0000, Mark Rutland wrote: > On Thu, Feb 12, 2015 at 10:22:07AM +0000, Michal Simek wrote: > > Add OCM node for all zynq boards. OCM location > > can changed but for all current boards this > > is the location where OCM is.` > > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > --- > > > > This patch is done based on discussion here. > > https://lkml.org/lkml/2014/12/1/396 > > > > There are some ways how to do it. > > OCM location can be changed but board DTS files > > can easily rewrite it. > > The problem which there is that node has address > > in it but maybe someone can suggest better solution. > > Given that the node is so simple, can't this be pushed down into the > board files? So long as the label is consistent anything else that's > referring to it should still work. Not that I have a strong opinion, but I've found that sometimes it's nice to be able to just glance at the SoC dtsi file to get an understanding of all of the hardware currently being modeled. Josh
diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi index a5cd2eda3edf..d55a8b365a6c 100644 --- a/arch/arm/boot/dts/zynq-7000.dtsi +++ b/arch/arm/boot/dts/zynq-7000.dtsi @@ -150,6 +150,11 @@ reg = <0xf8006000 0x1000>; }; + ocm: sram@fffc0000 { + compatible = "mmio-sram"; + reg = <0xfffc0000 0x10000>; + }; + uart0: serial@e0000000 { compatible = "xlnx,xuartps", "cdns,uart-r1p8"; status = "disabled";
Add OCM node for all zynq boards. OCM location can changed but for all current boards this is the location where OCM is.` Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- This patch is done based on discussion here. https://lkml.org/lkml/2014/12/1/396 There are some ways how to do it. OCM location can be changed but board DTS files can easily rewrite it. The problem which there is that node has address in it but maybe someone can suggest better solution. --- arch/arm/boot/dts/zynq-7000.dtsi | 5 +++++ 1 file changed, 5 insertions(+)