| Message ID | 1360365467-25056-5-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 08, 2013 at 11:17:34PM +0000, Ben Dooks wrote: > Add ARCH_SUPPORTS_BIG_ENDIAN define to arch/arm/Kconfig. Since it used > to live in arch/arm/mach-ixp4xx/Kconfig we move it up to the ARM one > as the next best place for it. > > It may be that it could be moved to a more generic location, with the > other ARCH_SUPPORT functions. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> So in patch 3, you remove this option (which removes it from the generated configs) and add it back in in the following patch. This makes this series non-bisectable. Please roll this into patch 3 and update the patch description accordingly. I'd also suggest moving it to arch/arm/mm/Kconfig rather than arch/arm/Kconfig, just before its only user, CPU_BIG_ENDIAN.
On 09/02/2013 11:55, Russell King - ARM Linux wrote: > On Fri, Feb 08, 2013 at 11:17:34PM +0000, Ben Dooks wrote: >> Add ARCH_SUPPORTS_BIG_ENDIAN define to arch/arm/Kconfig. Since it >> used >> to live in arch/arm/mach-ixp4xx/Kconfig we move it up to the ARM one >> as the next best place for it. >> >> It may be that it could be moved to a more generic location, with >> the >> other ARCH_SUPPORT functions. >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > > So in patch 3, you remove this option (which removes it from the > generated > configs) and add it back in in the following patch. This makes this > series > non-bisectable. Please roll this into patch 3 and update the patch > description accordingly. > > I'd also suggest moving it to arch/arm/mm/Kconfig rather than > arch/arm/Kconfig, just before its only user, CPU_BIG_ENDIAN. I was wondering if it should go elsewhere for other archs to use, but arch/arm/mmk/Kconfig seems reasonable. We always move it later.
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index d3f6c4f..8dfa634 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -152,6 +152,12 @@ config ARCH_HAS_CPUFREQ and that the relevant menu configurations are displayed for it. +config ARCH_SUPPORTS_BIG_ENDIAN + bool + help + Internal node to specify the architecture can run in Big Endian + mode. + config GENERIC_HWEIGHT bool default y
Add ARCH_SUPPORTS_BIG_ENDIAN define to arch/arm/Kconfig. Since it used to live in arch/arm/mach-ixp4xx/Kconfig we move it up to the ARM one as the next best place for it. It may be that it could be moved to a more generic location, with the other ARCH_SUPPORT functions. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- arch/arm/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+)