| Message ID | 1360882071-4072668-4-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Arnd Bergmann <arnd@arndb.de> [130214 14:51]: > The newly created omap_hwmod_reset.c is missing an > include of linux/errno.h in commit c02060d8 "ARM: > OMAP4+: AESS: enable internal auto-gating during > initial setup". It still works in omap2_defconfig, > but not in all other combinations. > > Without this patch, building allmodconfig results in: > > arch/arm/mach-omap2/omap_hwmod_reset.c: In function 'omap_hwmod_aess_preprogram': > arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) > arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: note: each undeclared identifier is reported only once for each function it appears in > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Paul Walmsley <paul@pwsan.com> > Cc: Sebastien Guiriec <s-guiriec@ti.com> Acked-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/mach-omap2/omap_hwmod_reset.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_reset.c b/arch/arm/mach-omap2/omap_hwmod_reset.c > index bba43fa..65e186c 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_reset.c > +++ b/arch/arm/mach-omap2/omap_hwmod_reset.c > @@ -24,6 +24,7 @@ > * 02110-1301 USA > */ > #include <linux/kernel.h> > +#include <linux/errno.h> > > #include <sound/aess.h> > > -- > 1.8.1.2 >
On Thu, 14 Feb 2013, Arnd Bergmann wrote: > The newly created omap_hwmod_reset.c is missing an > include of linux/errno.h in commit c02060d8 "ARM: > OMAP4+: AESS: enable internal auto-gating during > initial setup". It still works in omap2_defconfig, > but not in all other combinations. > > Without this patch, building allmodconfig results in: > > arch/arm/mach-omap2/omap_hwmod_reset.c: In function 'omap_hwmod_aess_preprogram': > arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) > arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: note: each undeclared identifier is reported only once for each function it appears in Acked-by: Paul Walmsley <paul@pwsan.com> - Paul
On Thursday 14 February 2013, Tony Lindgren wrote: > * Arnd Bergmann <arnd@arndb.de> [130214 14:51]: > > The newly created omap_hwmod_reset.c is missing an > > include of linux/errno.h in commit c02060d8 "ARM: > > OMAP4+: AESS: enable internal auto-gating during > > initial setup". It still works in omap2_defconfig, > > but not in all other combinations. > > > > Without this patch, building allmodconfig results in: > > > > arch/arm/mach-omap2/omap_hwmod_reset.c: In function 'omap_hwmod_aess_preprogram': > > arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) > > arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: note: each undeclared identifier is reported only once for each function it appears in > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: Paul Walmsley <paul@pwsan.com> > > Cc: Sebastien Guiriec <s-guiriec@ti.com> > > Acked-by: Tony Lindgren <tony@atomide.com> Ok, applied on top of late/omap Arnd
diff --git a/arch/arm/mach-omap2/omap_hwmod_reset.c b/arch/arm/mach-omap2/omap_hwmod_reset.c index bba43fa..65e186c 100644 --- a/arch/arm/mach-omap2/omap_hwmod_reset.c +++ b/arch/arm/mach-omap2/omap_hwmod_reset.c @@ -24,6 +24,7 @@ * 02110-1301 USA */ #include <linux/kernel.h> +#include <linux/errno.h> #include <sound/aess.h>
The newly created omap_hwmod_reset.c is missing an include of linux/errno.h in commit c02060d8 "ARM: OMAP4+: AESS: enable internal auto-gating during initial setup". It still works in omap2_defconfig, but not in all other combinations. Without this patch, building allmodconfig results in: arch/arm/mach-omap2/omap_hwmod_reset.c: In function 'omap_hwmod_aess_preprogram': arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: error: 'EINVAL' undeclared (first use in this function) arch/arm/mach-omap2/omap_hwmod_reset.c:47:11: note: each undeclared identifier is reported only once for each function it appears in Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Paul Walmsley <paul@pwsan.com> Cc: Sebastien Guiriec <s-guiriec@ti.com> Cc: Tony Lindgren <tony@atomide.com> --- arch/arm/mach-omap2/omap_hwmod_reset.c | 1 + 1 file changed, 1 insertion(+)