| Message ID | 1361373527-21695-3-git-send-email-santosh.shilimkar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, * Santosh Shilimkar <santosh.shilimkar@ti.com> [130220 07:21]: > On OMAP platform, FIQ is reserved for secure environment only. If at all > the FIQ needs to be disabled, it involves going through security > API call. Hence the local_fiq_[enable/disable]() in the OMAP code is bogus. > > So just get rid of it. This is not true for all omaps, needs to be checked carefully at what point it was made HS omap only. We have at least mach-omap1//ams-delta-fiq.c that's being used. Regards, Tony
On Wednesday 20 February 2013 09:39 PM, Tony Lindgren wrote: > Hi, > > * Santosh Shilimkar <santosh.shilimkar@ti.com> [130220 07:21]: >> On OMAP platform, FIQ is reserved for secure environment only. If at all >> the FIQ needs to be disabled, it involves going through security >> API call. Hence the local_fiq_[enable/disable]() in the OMAP code is bogus. >> >> So just get rid of it. > > This is not true for all omaps, needs to be checked carefully > at what point it was made HS omap only. We have at least > mach-omap1//ams-delta-fiq.c that's being used. > This is true for all OMAP2 and onward devices. I assumed it was the case for OMAP1 as well but that doesn't seems to be the case. Sorry I didn't look at OMAP1 code carefully. So this patch can be dropped then. Regards Santosh
diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c index 7a7690a..25aa9c4 100644 --- a/arch/arm/mach-omap1/pm.c +++ b/arch/arm/mach-omap1/pm.c @@ -111,8 +111,6 @@ void omap1_pm_idle(void) __u32 use_idlect1 = arm_idlect1_mask; int do_sleep = 0; - local_fiq_disable(); - #if defined(CONFIG_OMAP_MPU_TIMER) && !defined(CONFIG_OMAP_DM_TIMER) #warning Enable 32kHz OS timer in order to allow sleep states in idle use_idlect1 = use_idlect1 & ~(1 << 9); @@ -158,8 +156,6 @@ void omap1_pm_idle(void) } omap_sram_suspend(omap_readl(ARM_IDLECT1), omap_readl(ARM_IDLECT2)); - - local_fiq_enable(); } /* @@ -235,7 +231,6 @@ void omap1_pm_suspend(void) */ local_irq_disable(); - local_fiq_disable(); /* * Step 2: save registers @@ -414,7 +409,6 @@ void omap1_pm_suspend(void) */ local_irq_enable(); - local_fiq_enable(); omap_serial_wake_trigger(0);
On OMAP platform, FIQ is reserved for secure environment only. If at all the FIQ needs to be disabled, it involves going through security API call. Hence the local_fiq_[enable/disable]() in the OMAP code is bogus. So just get rid of it. Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/mach-omap1/pm.c | 6 ------ 1 file changed, 6 deletions(-)