diff mbox

[6/9] ARM: OMAP4+: Remove out of placed smp_wmb() in secondary wakeup code

Message ID 1361373527-21695-7-git-send-email-santosh.shilimkar@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Santosh Shilimkar Feb. 20, 2013, 3:18 p.m. UTC
The smp_wmb() here is out of placed and redundant. So remove it. It is
a left over of the pain_release cleanup mostly.

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 arch/arm/mach-omap2/omap-smp.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Sergei Shtylyov Feb. 21, 2013, 12:55 p.m. UTC | #1
Hello.

On 20-02-2013 19:18, Santosh Shilimkar wrote:

> The smp_wmb() here is out of placed

    s/placed/place/

> and redundant. So remove it. It is
> a left over of the pain_release

   Sure it's not 'pen_release'?

> cleanup mostly.

> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

WBR, Sergei
Santosh Shilimkar Feb. 21, 2013, 12:59 p.m. UTC | #2
On Thursday 21 February 2013 06:25 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 20-02-2013 19:18, Santosh Shilimkar wrote:
>
>> The smp_wmb() here is out of placed
>
>     s/placed/place/
>
>> and redundant. So remove it. It is
>> a left over of the pain_release
>
>    Sure it's not 'pen_release'?
>
>> cleanup mostly.
>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
Yes... Will fix.

Regards,
Santosh
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/omap-smp.c b/arch/arm/mach-omap2/omap-smp.c
index 81fd489..7d29a74 100644
--- a/arch/arm/mach-omap2/omap-smp.c
+++ b/arch/arm/mach-omap2/omap-smp.c
@@ -186,8 +186,6 @@  static void __init wakeup_secondary(void)
 		__raw_writel(virt_to_phys(omap5_secondary_startup),
 						base + OMAP_AUX_CORE_BOOT_1);
 
-	smp_wmb();
-
 	/*
 	 * Send a 'sev' to wake the secondary core from WFE.
 	 * Drain the outstanding writes to memory