| Message ID | 1361484083-5906-1-git-send-email-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 22 February 2013 03:31, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > The broadcast timer could be passed as parameter to the function > instead of using again tick_broadcast_device.evtdev which was > previously used in the caller function. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> I know you are going for another round with this patchset and was just trying v1. I did my tests on ARM Vexpress - TC2, big.LITTLE Arch. Tested-by: Viresh Kumar <viresh.kumar@linaro.org>
On 02/26/2013 09:45 AM, Viresh Kumar wrote: > On 22 February 2013 03:31, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> The broadcast timer could be passed as parameter to the function >> instead of using again tick_broadcast_device.evtdev which was >> previously used in the caller function. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > I know you are going for another round with this patchset and was just > trying v1. > > I did my tests on ARM Vexpress - TC2, big.LITTLE Arch. > > Tested-by: Viresh Kumar <viresh.kumar@linaro.org> Thanks Viresh for testing.
On 02/26/2013 09:45 AM, Viresh Kumar wrote: > On 22 February 2013 03:31, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> The broadcast timer could be passed as parameter to the function >> instead of using again tick_broadcast_device.evtdev which was >> previously used in the caller function. >> >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > I know you are going for another round with this patchset and was just > trying v1. > > I did my tests on ARM Vexpress - TC2, big.LITTLE Arch. > > Tested-by: Viresh Kumar <viresh.kumar@linaro.org> Oh, by the way, could send me the patch to set the flag to the timer device ? I will include it to the patchset. Thanks -- Daniel
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index f113755..baf9b0e7 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -370,10 +370,9 @@ struct cpumask *tick_get_broadcast_oneshot_mask(void) return to_cpumask(tick_broadcast_oneshot_mask); } -static int tick_broadcast_set_event(ktime_t expires, int force) +static int tick_broadcast_set_event(struct clock_event_device *bc, + ktime_t expires, int force) { - struct clock_event_device *bc = tick_broadcast_device.evtdev; - if (bc->mode != CLOCK_EVT_MODE_ONESHOT) clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT); @@ -443,7 +442,7 @@ again: * Rearm the broadcast device. If event expired, * repeat the above */ - if (tick_broadcast_set_event(next_event, 0)) + if (tick_broadcast_set_event(dev, next_event, 0)) goto again; } raw_spin_unlock(&tick_broadcast_lock); @@ -486,7 +485,7 @@ void tick_broadcast_oneshot_control(unsigned long reason) cpumask_set_cpu(cpu, tick_get_broadcast_oneshot_mask()); clockevents_set_mode(dev, CLOCK_EVT_MODE_SHUTDOWN); if (dev->next_event.tv64 < bc->next_event.tv64) - tick_broadcast_set_event(dev->next_event, 1); + tick_broadcast_set_event(bc, dev->next_event, 1); } } else { if (cpumask_test_cpu(cpu, tick_get_broadcast_oneshot_mask())) { @@ -555,7 +554,7 @@ void tick_broadcast_setup_oneshot(struct clock_event_device *bc) clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT); tick_broadcast_init_next_event(to_cpumask(tmpmask), tick_next_period); - tick_broadcast_set_event(tick_next_period, 1); + tick_broadcast_set_event(bc, tick_next_period, 1); } else bc->next_event.tv64 = KTIME_MAX; } else {
The broadcast timer could be passed as parameter to the function instead of using again tick_broadcast_device.evtdev which was previously used in the caller function. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- kernel/time/tick-broadcast.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)