From patchwork Mon Feb 25 03:49:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haojian Zhuang X-Patchwork-Id: 2180071 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4C0BB3FCA4 for ; Mon, 25 Feb 2013 03:56:57 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1U9p7v-00046b-4I; Mon, 25 Feb 2013 03:53:19 +0000 Received: from mail-pa0-f45.google.com ([209.85.220.45]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1U9p6C-0003K9-E8 for linux-arm-kernel@lists.infradead.org; Mon, 25 Feb 2013 03:51:34 +0000 Received: by mail-pa0-f45.google.com with SMTP id kl14so1492246pab.32 for ; Sun, 24 Feb 2013 19:51:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=qRjiT89ArT2RkI+aOzzq3rmynlUQswFzoIzkv9jcGrQ=; b=bPHxRdHWgnDh5wRGntII/6i4pasrCIxggq0ZJmdccjZ0KBVwTaTzG+n3VqfIBj1oBo PzlkA8M+NCarT+M4trb9xEI0AJ4OmoPNufBroiFYd33oJDFjbKEnZmyJlKYtbYgB/rFP Ldfb1sRrcJ9CTpLu7h8mD8ODM08qzAdypFZ3x3d4V8vaLWCYoXEosz226uzQPNh9f/sM mHTHlZmfJk8t/+fTwC1dAypMbdfIJm12g+bI/MCwm2wmYNpuiOxDhk+GpsDwG8QufruZ BboePBal3BhRl/AHo9zYPuA4UG7lT4zu693/x9wobSzabIJW4BwXnxqdticb8u9nXgP7 aV7A== X-Received: by 10.66.88.198 with SMTP id bi6mr16667197pab.54.1361764290956; Sun, 24 Feb 2013 19:51:30 -0800 (PST) Received: from localhost.localdomain ([67.198.145.34]) by mx.google.com with ESMTPS id b9sm11188695pba.6.2013.02.24.19.51.25 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Feb 2013 19:51:30 -0800 (PST) From: Haojian Zhuang To: grinberg@compulab.co.il, linus.walleij@linaro.org, linux@arm.linux.org.uk, marek.vasut@gmail.com, robert.jarzmik@free.fr, daniel@caiaq.de, linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca, cxie4@marvell.com Subject: [PATCH v5 07/12] gpio: pxa: add irq base in platform data Date: Mon, 25 Feb 2013 11:49:36 +0800 Message-Id: <1361764181-26647-8-git-send-email-haojian.zhuang@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1361764181-26647-1-git-send-email-haojian.zhuang@linaro.org> References: <1361764181-26647-1-git-send-email-haojian.zhuang@linaro.org> X-Gm-Message-State: ALoCoQnsTdywXscjMjiTMzddH/g7BPNY4wAoPjbfRZTddmUSVwtpwY0kGMlK7svVjSEAHZj4Uy6e X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130224_225132_717870_56BD530A X-CRM114-Status: GOOD ( 16.02 ) X-Spam-Score: 0.4 (/) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (0.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.45 listed in list.dnswl.org] 3.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Haojian Zhuang , patches@linaro.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Macro PXA_GPIO_TO_IRQ() & MMP_GPIO_TO_IRQ() is used in machine driver without DT. So move them into machine driver. Signed-off-by: Haojian Zhuang Tested-by: Igor Grinberg --- arch/arm/mach-mmp/aspenite.c | 1 + arch/arm/mach-mmp/avengers_lite.c | 1 + arch/arm/mach-mmp/brownstone.c | 1 + arch/arm/mach-mmp/flint.c | 1 + arch/arm/mach-mmp/gplugd.c | 1 + arch/arm/mach-mmp/tavorevb.c | 1 + arch/arm/mach-mmp/teton_bga.c | 1 + arch/arm/mach-mmp/ttc_dkb.c | 1 + arch/arm/mach-pxa/pxa25x.c | 1 + arch/arm/mach-pxa/pxa27x.c | 1 + arch/arm/mach-pxa/pxa3xx.c | 1 + drivers/gpio/gpio-pxa.c | 22 +++++++++------------- include/linux/gpio-pxa.h | 1 + 13 files changed, 21 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach-mmp/aspenite.c b/arch/arm/mach-mmp/aspenite.c index a3e42dc..5785931 100644 --- a/arch/arm/mach-mmp/aspenite.c +++ b/arch/arm/mach-mmp/aspenite.c @@ -113,6 +113,7 @@ static unsigned long common_pin_config[] __initdata = { static struct pxa_gpio_platform_data pxa168_gpio_pdata = { .nr_gpios = 128, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-mmp/avengers_lite.c b/arch/arm/mach-mmp/avengers_lite.c index 1ea6502..074fbbe 100644 --- a/arch/arm/mach-mmp/avengers_lite.c +++ b/arch/arm/mach-mmp/avengers_lite.c @@ -35,6 +35,7 @@ static unsigned long avengers_lite_pin_config_V16F[] __initdata = { static struct pxa_gpio_platform_data pxa168_gpio_pdata = { .nr_gpios = 128, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp/brownstone.c index a32156f..3b4224c 100644 --- a/arch/arm/mach-mmp/brownstone.c +++ b/arch/arm/mach-mmp/brownstone.c @@ -107,6 +107,7 @@ static unsigned long brownstone_pin_config[] __initdata = { static struct pxa_gpio_platform_data mmp2_gpio_pdata = { .nr_gpios = 192, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-mmp/flint.c b/arch/arm/mach-mmp/flint.c index 3f301b5..00cdf62 100644 --- a/arch/arm/mach-mmp/flint.c +++ b/arch/arm/mach-mmp/flint.c @@ -80,6 +80,7 @@ static unsigned long flint_pin_config[] __initdata = { static struct pxa_gpio_platform_data mmp2_gpio_pdata = { .nr_gpios = 192, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-mmp/gplugd.c b/arch/arm/mach-mmp/gplugd.c index 019b178..78acca4 100644 --- a/arch/arm/mach-mmp/gplugd.c +++ b/arch/arm/mach-mmp/gplugd.c @@ -130,6 +130,7 @@ static unsigned long gplugd_pin_config[] __initdata = { static struct pxa_gpio_platform_data pxa168_gpio_pdata = { .nr_gpios = 128, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-mmp/tavorevb.c b/arch/arm/mach-mmp/tavorevb.c index 6e8cf80..86ed017 100644 --- a/arch/arm/mach-mmp/tavorevb.c +++ b/arch/arm/mach-mmp/tavorevb.c @@ -63,6 +63,7 @@ static unsigned long tavorevb_pin_config[] __initdata = { static struct pxa_gpio_platform_data ttc_dkb_gpio_pdata = { .nr_gpios = 128, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c index b5146bb..db65631 100644 --- a/arch/arm/mach-mmp/teton_bga.c +++ b/arch/arm/mach-mmp/teton_bga.c @@ -52,6 +52,7 @@ static unsigned long teton_bga_pin_config[] __initdata = { static struct pxa_gpio_platform_data pxa168_gpio_pdata = { .nr_gpios = 128, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c index 387e3f8..0e0ea87 100644 --- a/arch/arm/mach-mmp/ttc_dkb.c +++ b/arch/arm/mach-mmp/ttc_dkb.c @@ -78,6 +78,7 @@ static unsigned long ttc_dkb_pin_config[] __initdata = { static struct pxa_gpio_platform_data ttc_dkb_gpio_pdata = { .nr_gpios = 128, + .irq_base = MMP_GPIO_TO_IRQ(0), .ed_mask = true, }; diff --git a/arch/arm/mach-pxa/pxa25x.c b/arch/arm/mach-pxa/pxa25x.c index 52f94f3..2195e1a 100644 --- a/arch/arm/mach-pxa/pxa25x.c +++ b/arch/arm/mach-pxa/pxa25x.c @@ -346,6 +346,7 @@ static struct pxa_gpio_platform_data pxa25x_gpio_info __initdata = { #else .nr_gpios = 85, #endif + .irq_base = PXA_GPIO_TO_IRQ(0), .gafr = true, .gpio_set_wake = gpio_set_wake, }; diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c index 619b2f2..cb3f443 100644 --- a/arch/arm/mach-pxa/pxa27x.c +++ b/arch/arm/mach-pxa/pxa27x.c @@ -433,6 +433,7 @@ void __init pxa27x_set_i2c_power_info(struct i2c_pxa_platform_data *info) static struct pxa_gpio_platform_data pxa27x_gpio_info __initdata = { .gafr = true, .nr_gpios = 121, + .irq_base = PXA_GPIO_TO_IRQ(0), .gpio_set_wake = gpio_set_wake, }; diff --git a/arch/arm/mach-pxa/pxa3xx.c b/arch/arm/mach-pxa/pxa3xx.c index f6bff16..ef0634b 100644 --- a/arch/arm/mach-pxa/pxa3xx.c +++ b/arch/arm/mach-pxa/pxa3xx.c @@ -438,6 +438,7 @@ void __init pxa3xx_set_i2c_power_info(struct i2c_pxa_platform_data *info) static struct pxa_gpio_platform_data pxa3xx_gpio_info __initdata = { .nr_gpios = 128, + .irq_base = PXA_GPIO_TO_IRQ(0), }; static struct platform_device *devices[] __initdata = { diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 65839a7..141190c 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -457,8 +457,6 @@ static int pxa_gpio_probe_dt(struct platform_device *pdev) dev_err(&pdev->dev, "nr-gpios isn't specified\n"); return -ENOTSUPP; } - /* set the platform data */ - pdev->dev.platform_data = pdata; next = of_get_next_child(np, NULL); prev = next; @@ -479,6 +477,9 @@ static int pxa_gpio_probe_dt(struct platform_device *pdev) dev_err(&pdev->dev, "Failed to allocate IRQ numbers\n"); return -EINVAL; } + pdata->irq_base = irq_base; + /* set the platform data */ + pdev->dev.platform_data = pdata; domain = irq_domain_add_legacy(np, pdata->nr_gpios, irq_base, 0, &pxa_irq_domain_ops, NULL); pxa_gpio_of_node = np; @@ -498,16 +499,13 @@ static int pxa_gpio_probe(struct platform_device *pdev) int irq0 = 0, irq1 = 0, irq_mux, gpio_offset = 0; ret = pxa_gpio_probe_dt(pdev); - if (ret < 0) { -#ifdef CONFIG_ARCH_PXA - irq_base = PXA_GPIO_TO_IRQ(0); -#elif defined(CONFIG_ARCH_MMP) - irq_base = MMP_GPIO_TO_IRQ(0); -#else -#error "gpio-pxa driver can't be used for your architecture" -#endif + if (ret < 0) use_of = 0; - } + info = dev_get_platdata(&pdev->dev); + pxa_last_gpio = info->nr_gpios - 1; + irq_base = info->irq_base; + if (pxa_last_gpio <=0 || irq_base <= 0) + return -EINVAL; irq0 = platform_get_irq_byname(pdev, "gpio0"); irq1 = platform_get_irq_byname(pdev, "gpio1"); @@ -540,8 +538,6 @@ static int pxa_gpio_probe(struct platform_device *pdev) } /* Initialize GPIO chips */ - info = dev_get_platdata(&pdev->dev); - pxa_last_gpio = info->nr_gpios - 1; pxa_init_gpio_chip(pdev, pxa_last_gpio); /* clear all GPIO edge detects */ diff --git a/include/linux/gpio-pxa.h b/include/linux/gpio-pxa.h index d2fa8e0..82c3e73 100644 --- a/include/linux/gpio-pxa.h +++ b/include/linux/gpio-pxa.h @@ -18,6 +18,7 @@ struct pxa_gpio_platform_data { bool inverted; /* only valid for PXA26x */ bool gafr; /* only valid for PXA25x/PXA26x/PXA27x */ unsigned int nr_gpios; + unsigned int irq_base; int (*gpio_set_wake)(unsigned int gpio, unsigned int on); };