| Message ID | 1362481780-11018-1-git-send-email-aaro.koskinen@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote: > Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to > add phy binding for RX-51, and as a result USB does not work anymore on > 3.9-rc1. Add the missing binding. > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Acked-by: Felipe Balbi <balbi@ti.com> > --- > arch/arm/mach-omap2/board-rx51.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c > index f7c4616..d2ea68e 100644 > --- a/arch/arm/mach-omap2/board-rx51.c > +++ b/arch/arm/mach-omap2/board-rx51.c > @@ -17,6 +17,7 @@ > #include <linux/io.h> > #include <linux/gpio.h> > #include <linux/leds.h> > +#include <linux/usb/phy.h> > #include <linux/usb/musb.h> > #include <linux/platform_data/spi-omap2-mcspi.h> > > @@ -98,6 +99,7 @@ static void __init rx51_init(void) > sdrc_params = nokia_get_sdram_timings(); > omap_sdrc_init(sdrc_params, sdrc_params); > > + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); > usb_musb_init(&musb_board_data); > rx51_peripherals_init(); > > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote: > On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote: >> Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to >> add phy binding for RX-51, and as a result USB does not work anymore on >> 3.9-rc1. Add the missing binding. >> >> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > Acked-by: Felipe Balbi <balbi@ti.com> Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> > >> --- >> arch/arm/mach-omap2/board-rx51.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c >> index f7c4616..d2ea68e 100644 >> --- a/arch/arm/mach-omap2/board-rx51.c >> +++ b/arch/arm/mach-omap2/board-rx51.c >> @@ -17,6 +17,7 @@ >> #include <linux/io.h> >> #include <linux/gpio.h> >> #include <linux/leds.h> >> +#include <linux/usb/phy.h> >> #include <linux/usb/musb.h> >> #include <linux/platform_data/spi-omap2-mcspi.h> >> >> @@ -98,6 +99,7 @@ static void __init rx51_init(void) >> sdrc_params = nokia_get_sdram_timings(); >> omap_sdrc_init(sdrc_params, sdrc_params); >> >> + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); >> usb_musb_init(&musb_board_data); >> rx51_peripherals_init(); >> >> -- >> 1.7.10.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >
* kishon <kishon@ti.com> [130305 03:46]: > On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote: > >On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote: > >>Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to > >>add phy binding for RX-51, and as a result USB does not work anymore on > >>3.9-rc1. Add the missing binding. > >> > >>Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > > >Acked-by: Felipe Balbi <balbi@ti.com> > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> Thanks, applying into omap-for-v3.9-rc1/fixes. Regards, Tony > >>--- > >> arch/arm/mach-omap2/board-rx51.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >>diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c > >>index f7c4616..d2ea68e 100644 > >>--- a/arch/arm/mach-omap2/board-rx51.c > >>+++ b/arch/arm/mach-omap2/board-rx51.c > >>@@ -17,6 +17,7 @@ > >> #include <linux/io.h> > >> #include <linux/gpio.h> > >> #include <linux/leds.h> > >>+#include <linux/usb/phy.h> > >> #include <linux/usb/musb.h> > >> #include <linux/platform_data/spi-omap2-mcspi.h> > >> > >>@@ -98,6 +99,7 @@ static void __init rx51_init(void) > >> sdrc_params = nokia_get_sdram_timings(); > >> omap_sdrc_init(sdrc_params, sdrc_params); > >> > >>+ usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); > >> usb_musb_init(&musb_board_data); > >> rx51_peripherals_init(); > >> > >>-- > >>1.7.10.4 > >> > >>-- > >>To unsubscribe from this list: send the line "unsubscribe linux-omap" in > >>the body of a message to majordomo@vger.kernel.org > >>More majordomo info at http://vger.kernel.org/majordomo-info.html > > >
Hi, On Tuesday 05 March 2013 05:11 PM, kishon wrote: > On Tuesday 05 March 2013 05:06 PM, Felipe Balbi wrote: >> On Tue, Mar 05, 2013 at 01:09:40PM +0200, Aaro Koskinen wrote: >>> Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to >>> add phy binding for RX-51, and as a result USB does not work anymore on >>> 3.9-rc1. Add the missing binding. >>> >>> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> >> >> Acked-by: Felipe Balbi <balbi@ti.com> > Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com> Btw I dint add usb_bind_phy for board-am3517evm.c, board-ti8168evm.c too since those board files also dint have any reference to twl4030/twl6030. Can someone let me know what phy these platforms use or provide a patch for the same? Thanks Kishon
diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c index f7c4616..d2ea68e 100644 --- a/arch/arm/mach-omap2/board-rx51.c +++ b/arch/arm/mach-omap2/board-rx51.c @@ -17,6 +17,7 @@ #include <linux/io.h> #include <linux/gpio.h> #include <linux/leds.h> +#include <linux/usb/phy.h> #include <linux/usb/musb.h> #include <linux/platform_data/spi-omap2-mcspi.h> @@ -98,6 +99,7 @@ static void __init rx51_init(void) sdrc_params = nokia_get_sdram_timings(); omap_sdrc_init(sdrc_params, sdrc_params); + usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb"); usb_musb_init(&musb_board_data); rx51_peripherals_init();
Commit 51482be9 (ARM: OMAP: USB: Add phy binding information) forgot to add phy binding for RX-51, and as a result USB does not work anymore on 3.9-rc1. Add the missing binding. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> --- arch/arm/mach-omap2/board-rx51.c | 2 ++ 1 file changed, 2 insertions(+)