| Message ID | 1362521809-22989-10-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 6 March 2013 06:16, Arnd Bergmann <arnd@arndb.de> wrote: > The definitions have move around recently, causing build errors > in spear3xx for all configurations: > > spear3xx.c:47:5: error: 'PL080_BSIZE_16' undeclared here (not in a function) > spear3xx.c:47:23: error: 'PL080_CONTROL_SB_SIZE_SHIFT' undeclared here (not in a function) > spear3xx.c:48:22: error: 'PL080_CONTROL_DB_SIZE_SHIFT' undeclared here (not in a function) > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Alessandro Rubini <rubini@gnudd.com> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > --- > arch/arm/mach-spear3xx/spear3xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You are a bit late in posting this. We already got the same patch from Vipul yesterday :)
On Tuesday 05 March 2013, Viresh Kumar wrote: > On 6 March 2013 06:16, Arnd Bergmann <arnd@arndb.de> wrote: > > The definitions have move around recently, causing build errors > > in spear3xx for all configurations: > > > > spear3xx.c:47:5: error: 'PL080_BSIZE_16' undeclared here (not in a function) > > spear3xx.c:47:23: error: 'PL080_CONTROL_SB_SIZE_SHIFT' undeclared here (not in a function) > > spear3xx.c:48:22: error: 'PL080_CONTROL_DB_SIZE_SHIFT' undeclared here (not in a function) > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Cc: Alessandro Rubini <rubini@gnudd.com> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > arch/arm/mach-spear3xx/spear3xx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > You are a bit late in posting this. > We already got the same patch from Vipul yesterday :) Are you going to send a pull request for that one then? Another -rc has just passed with the platform being broken. Arnd
On 12 March 2013 06:34, Arnd Bergmann <arnd@arndb.de> wrote: > Are you going to send a pull request for that one then? Another -rc has > just passed with the platform being broken. Probably you can just apply that patch, i am not planning to send a pull request for that one.
diff --git a/arch/arm/mach-spear3xx/spear3xx.c b/arch/arm/mach-spear3xx/spear3xx.c index f9d754f..d2b3937 100644 --- a/arch/arm/mach-spear3xx/spear3xx.c +++ b/arch/arm/mach-spear3xx/spear3xx.c @@ -14,7 +14,7 @@ #define pr_fmt(fmt) "SPEAr3xx: " fmt #include <linux/amba/pl022.h> -#include <linux/amba/pl08x.h> +#include <linux/amba/pl080.h> #include <linux/io.h> #include <plat/pl080.h> #include <mach/generic.h>
The definitions have move around recently, causing build errors in spear3xx for all configurations: spear3xx.c:47:5: error: 'PL080_BSIZE_16' undeclared here (not in a function) spear3xx.c:47:23: error: 'PL080_CONTROL_SB_SIZE_SHIFT' undeclared here (not in a function) spear3xx.c:48:22: error: 'PL080_CONTROL_DB_SIZE_SHIFT' undeclared here (not in a function) Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Alessandro Rubini <rubini@gnudd.com> Cc: Viresh Kumar <viresh.kumar@linaro.org> --- arch/arm/mach-spear3xx/spear3xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)