Message ID | 1362601138-16550-1-git-send-email-martinknoll@me.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Mar 06, 2013 at 09:18:58PM +0100, Martin Knoll wrote:
> This function has an odd name. This is probably a typo.
You should cc the platform maintainer on these kind of patches (Roland Stigge).
But it seems that he's not actually listed in MAINTAINERS.
Roland, can you send a patch adding yourself as LPC32XX maintainer so these
kind of patches don't get dropped? Thanks!
-Olof
On 02/04/13 17:58, Olof Johansson wrote: > On Wed, Mar 06, 2013 at 09:18:58PM +0100, Martin Knoll wrote: >> This function has an odd name. This is probably a typo. > > You should cc the platform maintainer on these kind of patches (Roland Stigge). > But it seems that he's not actually listed in MAINTAINERS. I indeed missed the above patch - should be a simple syntactic fix in 3 places in arch/arm/. You can go ahead this time and directly take this fix. Otherwise, please forward to me so I can add it to a lpc32xx tree and do request pull. > Roland, can you send a patch adding yourself as LPC32XX maintainer so these > kind of patches don't get dropped? Thanks! OK, just did. Thanks for notifying! Roland
diff --git a/arch/arm/mach-lpc32xx/common.c b/arch/arm/mach-lpc32xx/common.c index 0d4db8c..20c0ed7 100644 --- a/arch/arm/mach-lpc32xx/common.c +++ b/arch/arm/mach-lpc32xx/common.c @@ -207,7 +207,7 @@ void __init lpc32xx_map_io(void) iotable_init(lpc32xx_io_desc, ARRAY_SIZE(lpc32xx_io_desc)); } -void lpc23xx_restart(char mode, const char *cmd) +void lpc32xx_restart(char mode, const char *cmd) { switch (mode) { case 's': diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h index e0b2606..5d90469 100644 --- a/arch/arm/mach-lpc32xx/common.h +++ b/arch/arm/mach-lpc32xx/common.h @@ -29,7 +29,7 @@ extern void lpc32xx_timer_init(void); extern void __init lpc32xx_init_irq(void); extern void __init lpc32xx_map_io(void); extern void __init lpc32xx_serial_init(void); -extern void lpc23xx_restart(char, const char *); +extern void lpc32xx_restart(char, const char *); /* diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c index c1cd5a9..16e5b58 100644 --- a/arch/arm/mach-lpc32xx/phy3250.c +++ b/arch/arm/mach-lpc32xx/phy3250.c @@ -266,5 +266,5 @@ DT_MACHINE_START(LPC32XX_DT, "LPC32XX SoC (Flattened Device Tree)") .init_time = lpc32xx_timer_init, .init_machine = lpc3250_machine_init, .dt_compat = lpc32xx_dt_compat, - .restart = lpc23xx_restart, + .restart = lpc32xx_restart, MACHINE_END