| Message ID | 1362807578-23089-5-git-send-email-linux@prisktech.co.nz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Mar 9, 2013 at 6:39 AM, Tony Prisk <linux@prisktech.co.nz> wrote: > Remove the gpio related devicetree nodes as these are no longer required > with the move to a combined pinctrl/gpio driver. > > Signed-off-by: Tony Prisk <linux@prisktech.co.nz> (...) > - gpio: gpio-controller@d8110000 { > - compatible = "via,vt8500-gpio"; > - gpio-controller; > - reg = <0xd8110000 0x10000>; > - #gpio-cells = <3>; > - }; Whopeedo. If I understand the fine devicetree folks you may remove this stuff from the devicetree, but the code in the new pin control driver should still be backward-compatible with devicetrees that look like this. It's not like I care, just noting that this is the philosophy around such things. Yours, Linus Walleij
On Wednesday 13 March 2013, Linus Walleij wrote: > > - gpio: gpio-controller@d8110000 { > > - compatible = "via,vt8500-gpio"; > > - gpio-controller; > > - reg = <0xd8110000 0x10000>; > > - #gpio-cells = <3>; > > - }; > > Whopeedo. If I understand the fine devicetree folks you may > remove this stuff from the devicetree, but the code in the new > pin control driver should still be backward-compatible with > devicetrees that look like this. > > It's not like I care, just noting that this is the philosophy around > such things. Right. For brand new code that does not have a lot of users, we can be more pragmatic though. If you are sure enough that it does not break for any existing users, we can change the binding. This may well be the case for vt8500. Arnd
diff --git a/arch/arm/boot/dts/vt8500.dtsi b/arch/arm/boot/dts/vt8500.dtsi index 16388c2..e0ce0b9 100644 --- a/arch/arm/boot/dts/vt8500.dtsi +++ b/arch/arm/boot/dts/vt8500.dtsi @@ -25,13 +25,6 @@ #interrupt-cells = <1>; }; - gpio: gpio-controller@d8110000 { - compatible = "via,vt8500-gpio"; - gpio-controller; - reg = <0xd8110000 0x10000>; - #gpio-cells = <3>; - }; - pinctrl: pinctrl@d8110000 { compatible = "via,vt8500-pinctrl"; gpio-controller; diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi index c5aa4c9..5c7ad12 100644 --- a/arch/arm/boot/dts/wm8505.dtsi +++ b/arch/arm/boot/dts/wm8505.dtsi @@ -40,13 +40,6 @@ interrupts = <56 57 58 59 60 61 62 63>; }; - gpio: gpio-controller@d8110000 { - compatible = "wm,wm8505-gpio"; - gpio-controller; - reg = <0xd8110000 0x10000>; - #gpio-cells = <3>; - }; - pinctrl: pinctrl@d8110000 { compatible = "wm,wm8505-pinctrl"; gpio-controller; diff --git a/arch/arm/boot/dts/wm8650.dtsi b/arch/arm/boot/dts/wm8650.dtsi index 99c45e5..984d0ed 100644 --- a/arch/arm/boot/dts/wm8650.dtsi +++ b/arch/arm/boot/dts/wm8650.dtsi @@ -34,13 +34,6 @@ interrupts = <56 57 58 59 60 61 62 63>; }; - gpio: gpio-controller@d8110000 { - compatible = "wm,wm8650-gpio"; - gpio-controller; - reg = <0xd8110000 0x10000>; - #gpio-cells = <3>; - }; - pinctrl: pinctrl@d8110000 { compatible = "wm,wm8650-pinctrl"; gpio-controller; diff --git a/arch/arm/boot/dts/wm8850.dtsi b/arch/arm/boot/dts/wm8850.dtsi index 60094cd..01d67bf 100644 --- a/arch/arm/boot/dts/wm8850.dtsi +++ b/arch/arm/boot/dts/wm8850.dtsi @@ -41,13 +41,6 @@ interrupts = <56 57 58 59 60 61 62 63>; }; - gpio: gpio-controller@d8110000 { - compatible = "wm,wm8650-gpio"; - gpio-controller; - reg = <0xd8110000 0x10000>; - #gpio-cells = <3>; - }; - pinctrl: pinctrl@d8110000 { compatible = "wm,wm8850-pinctrl"; gpio-controller;
Remove the gpio related devicetree nodes as these are no longer required with the move to a combined pinctrl/gpio driver. Signed-off-by: Tony Prisk <linux@prisktech.co.nz> --- arch/arm/boot/dts/vt8500.dtsi | 7 ------- arch/arm/boot/dts/wm8505.dtsi | 7 ------- arch/arm/boot/dts/wm8650.dtsi | 7 ------- arch/arm/boot/dts/wm8850.dtsi | 7 ------- 4 files changed, 28 deletions(-)