diff mbox

[04/10] ASoC: Kconfig: imx-ssi needs imx-fiq and imx-dma

Message ID 1362940391-8338-5-git-send-email-mpa@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Markus Pargmann March 10, 2013, 6:33 p.m. UTC
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 sound/soc/fsl/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Mark Brown March 12, 2013, 6:55 p.m. UTC | #1
On Sun, Mar 10, 2013 at 07:33:05PM +0100, Markus Pargmann wrote:

>  config SND_SOC_IMX_SSI
> +	select SND_SOC_IMX_PCM_DMA
> +	select SND_SOC_IMX_PCM_FIQ
>  	tristate

Really?  I'd expect this to be an or, if we've got DMA I can't see any
reason why we'd want to use the FIQ.
Markus Pargmann March 14, 2013, 12:42 p.m. UTC | #2
On Tue, Mar 12, 2013 at 06:55:10PM +0000, Mark Brown wrote:
> On Sun, Mar 10, 2013 at 07:33:05PM +0100, Markus Pargmann wrote:
> 
> >  config SND_SOC_IMX_SSI
> > +	select SND_SOC_IMX_PCM_DMA
> > +	select SND_SOC_IMX_PCM_FIQ
> >  	tristate
> 
> Really?  I'd expect this to be an or, if we've got DMA I can't see any
> reason why we'd want to use the FIQ.

Yes, sorry, I looked at the returncodes of the devicedrivers, but
devices actually don't have to be used. So this can be dropped.

Thanks,
Markus
diff mbox

Patch

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 3b98159..42d3047 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -106,6 +106,8 @@  menuconfig SND_IMX_SOC
 if SND_IMX_SOC
 
 config SND_SOC_IMX_SSI
+	select SND_SOC_IMX_PCM_DMA
+	select SND_SOC_IMX_PCM_FIQ
 	tristate
 
 config SND_SOC_IMX_PCM