From patchwork Tue Mar 19 18:07:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Guinot X-Patchwork-Id: 2303711 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 5C4A0DFB79 for ; Tue, 19 Mar 2013 18:10:57 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UI0xC-0005oS-36; Tue, 19 Mar 2013 18:08:06 +0000 Received: from vm1.sequanux.org ([188.165.36.56]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UI0vp-0005Ig-UP for linux-arm-kernel@lists.infradead.org; Tue, 19 Mar 2013 18:06:43 +0000 Received: from localhost (unknown [37.161.170.107]) by vm1.sequanux.org (Postfix) with ESMTPSA id 656881081CF; Tue, 19 Mar 2013 19:06:40 +0100 (CET) From: Simon Guinot To: Bryan Wu , Richard Purdie , Jason Cooper , Andrew Lunn Subject: [PATCH 3/4] leds: leds-lt3593: fix devm_gpio_request_one() flags parameter Date: Tue, 19 Mar 2013 19:07:31 +0100 Message-Id: <1363716452-18870-4-git-send-email-simon.guinot@sequanux.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1363716452-18870-1-git-send-email-simon.guinot@sequanux.org> References: <1363716452-18870-1-git-send-email-simon.guinot@sequanux.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130319_140642_428128_733297D0 X-CRM114-Status: GOOD ( 10.73 ) X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This patch fixes a regression introduced by commit 507d967bc1 ("leds: leds-lt3593: use gpio_request_one"). gpio_request_one is called with a wrong flag value: The GPIO default state is used to configure the direction (bit 0) instead of the value (bit 1). As a result, if the default GPIO state is non null then the GPIO will be configured as input. This patch fixes the issue by using the dedicated macros GPIOF_OUT_INIT_{LOW,HIGH} to configure the initial GPIO value. Signed-off-by: Simon Guinot --- drivers/leds/leds-lt3593.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c index c9b9e1f..ca48a7d 100644 --- a/drivers/leds/leds-lt3593.c +++ b/drivers/leds/leds-lt3593.c @@ -106,8 +106,9 @@ static int create_lt3593_led(const struct gpio_led *template, if (!template->retain_state_suspended) led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; - ret = devm_gpio_request_one(parent, template->gpio, - GPIOF_DIR_OUT | state, template->name); + ret = devm_gpio_request_one(parent, template->gpio, state ? + GPIOF_OUT_INIT_HIGH : GPIOF_OUT_INIT_LOW, + template->name); if (ret < 0) return ret;