| Message ID | 1364218233-29636-9-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/25/2013 08:30 AM, Maxime Ripard wrote: > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > arch/arm/boot/dts/sun4i-a10.dtsi | 2 +- > arch/arm/boot/dts/sun5i-a13.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi > index be71782..805d704 100644 > --- a/arch/arm/boot/dts/sun4i-a10.dtsi > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi > @@ -121,7 +121,7 @@ > ranges; > > intc: interrupt-controller@01c20400 { > - compatible = "allwinner,sunxi-ic"; > + compatible = "allwinner,sun4i-ic"; Generally speaking, this is a bad thing to do. This breaks compatibility between dtb and kernel versions. If that breakage is not yet a concern for sunxi, then it is okay. Also, I don't see any documentation updates for any of these changes. Rob > reg = <0x01c20400 0x400>; > interrupt-controller; > #interrupt-cells = <1>; > diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi > index 7a81aaf..760222c 100644 > --- a/arch/arm/boot/dts/sun5i-a13.dtsi > +++ b/arch/arm/boot/dts/sun5i-a13.dtsi > @@ -122,7 +122,7 @@ > ranges; > > intc: interrupt-controller@01c20400 { > - compatible = "allwinner,sunxi-ic"; > + compatible = "allwinner,sun4i-ic"; > reg = <0x01c20400 0x400>; > interrupt-controller; > #interrupt-cells = <1>; >
Hi Rob, Le 25/03/2013 14:59, Rob Herring a écrit : > On 03/25/2013 08:30 AM, Maxime Ripard wrote: >> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> >> --- >> arch/arm/boot/dts/sun4i-a10.dtsi | 2 +- >> arch/arm/boot/dts/sun5i-a13.dtsi | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi >> index be71782..805d704 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -121,7 +121,7 @@ >> ranges; >> >> intc: interrupt-controller@01c20400 { >> - compatible = "allwinner,sunxi-ic"; >> + compatible = "allwinner,sun4i-ic"; > > Generally speaking, this is a bad thing to do. This breaks compatibility > between dtb and kernel versions. If that breakage is not yet a concern > for sunxi, then it is okay. Yes, I know, but I thought it was okay since sunxi has never been in an usable state, and it seemed odd to me to begin to maintain an history for a platform that has never actually been booted by a user. On the other end, if someone speaks up, I'd be happy to keep the old compatible around as well. > Also, I don't see any documentation updates for any of these changes. Ah, yes, my bad. Thanks, Maxime
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi index be71782..805d704 100644 --- a/arch/arm/boot/dts/sun4i-a10.dtsi +++ b/arch/arm/boot/dts/sun4i-a10.dtsi @@ -121,7 +121,7 @@ ranges; intc: interrupt-controller@01c20400 { - compatible = "allwinner,sunxi-ic"; + compatible = "allwinner,sun4i-ic"; reg = <0x01c20400 0x400>; interrupt-controller; #interrupt-cells = <1>; diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi index 7a81aaf..760222c 100644 --- a/arch/arm/boot/dts/sun5i-a13.dtsi +++ b/arch/arm/boot/dts/sun5i-a13.dtsi @@ -122,7 +122,7 @@ ranges; intc: interrupt-controller@01c20400 { - compatible = "allwinner,sunxi-ic"; + compatible = "allwinner,sun4i-ic"; reg = <0x01c20400 0x400>; interrupt-controller; #interrupt-cells = <1>;
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- arch/arm/boot/dts/sun4i-a10.dtsi | 2 +- arch/arm/boot/dts/sun5i-a13.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)