diff mbox

arm: prima2: export sirfsoc_reset_device as the common API of drivers

Message ID 1364353599-30731-1-git-send-email-Barry.Song@csr.com (mailing list archive)
State New, archived
Headers show

Commit Message

Barry Song March 27, 2013, 3:06 a.m. UTC 
From: "renwei.wu" <renwei.wu@csr.com>

sirfsoc_reset_device() should be an API used by other SiRF drivers.
This patch exports it.
devices who want to reset just need to add reset_bit in .dts.

Signed-off-by: Renwei Wu <Renwei.Wu@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
 arch/arm/mach-prima2/rstc.c |    1 +
 include/linux/sirfsoc_rst.h |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 include/linux/sirfsoc_rst.h

Comments

Arnd Bergmann March 28, 2013, 5:24 p.m. UTC | #1 
On Wednesday 27 March 2013, Barry Song wrote:
> From: "renwei.wu" <renwei.wu@csr.com>
> 
> sirfsoc_reset_device() should be an API used by other SiRF drivers.
> This patch exports it.
> devices who want to reset just need to add reset_bit in .dts.
> 
> Signed-off-by: Renwei Wu <Renwei.Wu@csr.com>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>

The interface is currently not used in the mainline kernel, and
having a global header for it is not a good solution in the long
run. Please have a look at the patches labeled "Reset controller
API to reset IP modules on i.MX5 and i.MX6" from Philipp Zabel
and coordinate with him or base your own drivers on his code
when you get it upstream.

	Arnd
Barry Song March 29, 2013, 11:53 a.m. UTC | #2 
2013/3/29 Arnd Bergmann <arnd@arndb.de>
>
> On Wednesday 27 March 2013, Barry Song wrote:
> > From: "renwei.wu" <renwei.wu@csr.com>
> >
> > sirfsoc_reset_device() should be an API used by other SiRF drivers.
> > This patch exports it.
> > devices who want to reset just need to add reset_bit in .dts.
> >
> > Signed-off-by: Renwei Wu <Renwei.Wu@csr.com>
> > Signed-off-by: Barry Song <Baohua.Song@csr.com>
>
> The interface is currently not used in the mainline kernel, and
> having a global header for it is not a good solution in the long
> run. Please have a look at the patches labeled "Reset controller
> API to reset IP modules on i.MX5 and i.MX6" from Philipp Zabel
> and coordinate with him or base your own drivers on his code
> when you get it upstream.

well. happy to see there is another subsystem about reset_controller.
that should remove the requirement of sirfsoc specific reset api.

>
>         Arnd

-barry
diff mbox

Patch

diff --git a/arch/arm/mach-prima2/rstc.c b/arch/arm/mach-prima2/rstc.c
index 435019c..6c40913 100644
--- a/arch/arm/mach-prima2/rstc.c
+++ b/arch/arm/mach-prima2/rstc.c
@@ -79,6 +79,7 @@  int sirfsoc_reset_device(struct device *dev)
 
 	return 0;
 }
+EXPORT_SYMBOL(sirfsoc_reset_device);
 
 #define SIRFSOC_SYS_RST_BIT  BIT(31)
 
diff --git a/include/linux/sirfsoc_rst.h b/include/linux/sirfsoc_rst.h
new file mode 100644
index 0000000..b29017a
--- /dev/null
+++ b/include/linux/sirfsoc_rst.h
@@ -0,0 +1,6 @@ 
+#ifndef _SIRFSOC_RST_H_
+#define _SIRFSOC_RST_H_
+
+int sirfsoc_reset_device(struct device *dev);
+
+#endif