diff mbox

[v7,1/5] mmc: davinci: allow driver to work without DMA resource

Message ID 1364476211-14322-2-git-send-email-prakash.pm@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Manjunathappa, Prakash March 28, 2013, 1:10 p.m. UTC 
Do not return probe failure with missing DMA resources,
allow driver to work in PIO mode.
Tested on da850-evm by mounting partition followed by
file creation and deletion.

Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
Tested-by: Sekhar Nori <nsekhar@ti.com>
---
 drivers/mmc/host/davinci_mmc.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

Comments

Sekhar Nori April 2, 2013, 8:39 a.m. UTC | #1 
On 3/28/2013 6:40 PM, Manjunathappa, Prakash wrote:
> Do not return probe failure with missing DMA resources,
> allow driver to work in PIO mode.
> Tested on da850-evm by mounting partition followed by
> file creation and deletion.
> 
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> Tested-by: Sekhar Nori <nsekhar@ti.com>

Chris accepted this patch on March 22nd. You should have dropped this
from this series.

Thanks,
Sekhar
Manjunathappa, Prakash April 2, 2013, 9:55 a.m. UTC | #2 
On Tue, Apr 02, 2013 at 14:09:29, Nori, Sekhar wrote:
> On 3/28/2013 6:40 PM, Manjunathappa, Prakash wrote:
> > Do not return probe failure with missing DMA resources,
> > allow driver to work in PIO mode.
> > Tested on da850-evm by mounting partition followed by
> > file creation and deletion.
> > 
> > Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> > Tested-by: Sekhar Nori <nsekhar@ti.com>
> 
> Chris accepted this patch on March 22nd. You should have dropped this
> from this series.
> 

Thanks Sekhar, I missed Chris's reply somehow.

Chris,
Please ignore this patch.

Regards,
Prakash
diff mbox

Patch

diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index f5d46ea..bd848d3 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1191,13 +1191,15 @@  static int __init davinci_mmcsd_probe(struct platform_device *pdev)
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 0);
 	if (!r)
-		goto out;
-	host->rxdma = r->start;
+		dev_warn(&pdev->dev, "RX DMA resource not specified\n");
+	else
+		host->rxdma = r->start;
 
 	r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
 	if (!r)
-		goto out;
-	host->txdma = r->start;
+		dev_warn(&pdev->dev, "TX DMA resource not specified\n");
+	else
+		host->txdma = r->start;
 
 	host->mem_res = mem;
 	host->base = ioremap(mem->start, mem_size);