From patchwork Sun Apr 7 20:27:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 2403301 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 3192E3FC71 for ; Sun, 7 Apr 2013 20:43:02 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UOwQF-0002Jw-G7; Sun, 07 Apr 2013 20:42:43 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UOwBe-0000hI-Qe; Sun, 07 Apr 2013 20:27:38 +0000 Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UOwBa-0000gy-Fl for linux-arm-kernel@lists.infradead.org; Sun, 07 Apr 2013 20:27:35 +0000 Received: by mail-ea0-f173.google.com with SMTP id k11so1951446eaj.4 for ; Sun, 07 Apr 2013 13:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=GKQGj5ij25xz5XL+v5V7dY/b0z/RdT0LJtXv/g9CU9o=; b=cI7/T0B8mcF9f2lY0mNp5MY/r1h72j2fdPQuZsP7iGN1kOv0UepHcSrEmyLuC3ehoT vo4xOrwOpbvtEFrny3WZkrxQqDr2l3QnjazC7sx/PrjGBO51FoKKIzmI5rhxhsF/tYp9 igsl9/VlyL23/r1TJtG6//5Aj64wUslSkg7idXOn2tRac73E2YP/VRZ8BpyeJsqEvPkB HHkm+wJIua16PMhaL0yZDW83+DmzLiJcdOYI6txJqIYQxuTZ+/H+ntofBxOmNIrZnHdx bGrT4XmMqf0nX5cDXhZVxJyVfOrGJ202p9GH2P4HHvZEs7CD6sJsvIoeunxEcLStaMYo SKTg== X-Received: by 10.15.34.199 with SMTP id e47mr32151022eev.35.1365366451507; Sun, 07 Apr 2013 13:27:31 -0700 (PDT) Received: from localhost.localdomain (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPS id a1sm28228592eep.2.2013.04.07.13.27.29 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 07 Apr 2013 13:27:30 -0700 (PDT) From: Sylwester Nawrocki To: kgene.kim@samsung.com Subject: [PATCH] ARM: Samsung: Select ARM_CPU_SUSPEND when required Date: Sun, 7 Apr 2013 22:27:22 +0200 Message-Id: <1365366442-16025-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.4.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130407_162734_723387_B0CB33AE X-CRM114-Status: GOOD ( 11.91 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sylvester.nawrocki[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: stable@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The power management code of S3C24XX, S3C64XX, S5PV210 platform in arch/arm/plat-samsung/, arch/arm/mach-s3c24xx/, arch/arm/mach-s3c64xx/ directories uses generic cpu_suspend routine. Make sure it is compiled in when building with power management support. Without this patch compilation fails with errors as below. It can be reproduced by using default config files with CONFIG_SUSPEND disabled and CONFIG_PM_RUNTIME enabled. - s5pv210_defconfig arch/arm/plat-samsung/built-in.o: In function `s3c_pm_enter': arch/arm/plat-samsung/pm.c:304: undefined reference to `cpu_suspend' arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume': arch/arm/plat-samsung/s5p-sleep.S:74: undefined reference to `cpu_resume' - s3c24xx_defconfig arch/arm/mach-s3c24xx/built-in.o: In function `s3c_cpu_resume': arch/arm/mach-s3c24xx/sleep.S:83: undefined reference to `cpu_resume' arch/arm/plat-samsung/built-in.o: In function `s3c_pm_enter': arch/arm/plat-samsung/pm.c:304: undefined reference to `cpu_suspend' - s3c64xx_defconfig arch/arm/mach-s3c64xx/built-in.o: In function `s3c_cpu_resume': arch/arm/mach-s3c64xx/sleep.S:72: undefined reference to `cpu_resume' arch/arm/plat-samsung/built-in.o: In function `s3c_pm_enter': arch/arm/plat-samsung/pm.c:304: undefined reference to `cpu_suspend' To fix this issue select ARM_CPU_SUSPEND for PLAT_SAMSUNG when PM is set. The build break occurs for kernels at least back to v3.0, however this patch applies without conflicts only back to v3.7. Signed-off-by: Sylwester Nawrocki Cc: stable@vger.kernel.org --- arch/arm/plat-samsung/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig index 54d1861..02355ba 100644 --- a/arch/arm/plat-samsung/Kconfig +++ b/arch/arm/plat-samsung/Kconfig @@ -10,6 +10,7 @@ config PLAT_SAMSUNG default y select GENERIC_IRQ_CHIP select NO_IOPORT + select ARM_CPU_SUSPEND if PM help Base platform code for all Samsung SoC based systems