| Message ID | 1365435688-4179-3-git-send-email-jagarwal@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/08/2013 09:41 AM, Jay Agarwal wrote: > Signed-off-by: Jay Agarwal <jagarwal@nvidia.com> > > - Add PCIe node entry for cardhu > - Enable only root port 2 > - Initialize regulators required for tegra30 Initialize isn't correct; this change makes no changes to any regulator; it simply includes the required regulator properties in the new node. I think you'd want to re-write this patch description as: Enable the PCIe controller on Cardhu. Only port 2 is connected on this board. It is connected to the Ethernet controller in the dock. > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi > + pcie-controller { ... > serial@70006000 { It lookos like this node is added in the wrong place. Nodes should be sorted based on reg property, and judging by the reg property for this node in tegra30.dtsi in Thierry's branch, this should be the first node in the Cardhu file.
diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi index d2fdf95..b64113e 100644 --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi @@ -137,6 +137,17 @@ }; }; + pcie-controller { + status = "okay"; + pex-clk-supply = <&pex_hvdd_3v3_reg>; + vdd-supply = <&ldo1_reg>; + avdd-supply = <&ldo2_reg>; + + pci@3,0 { + status = "okay"; + }; + }; + serial@70006000 { status = "okay"; };
Signed-off-by: Jay Agarwal <jagarwal@nvidia.com> - Add PCIe node entry for cardhu - Enable only root port 2 - Initialize regulators required for tegra30 - Based on git://gitorious.org/thierryreding/linux.git arch/arm/boot/dts/tegra30-cardhu.dtsi | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)