From patchwork Mon Apr 8 19:53:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 2411161 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 6EDBB3FD1A for ; Mon, 8 Apr 2013 19:53:27 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPI84-0001Ht-Nt; Mon, 08 Apr 2013 19:53:24 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPI82-0008HB-Ad; Mon, 08 Apr 2013 19:53:22 +0000 Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPI7y-0008Gs-SK for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2013 19:53:19 +0000 Received: by mail-ea0-f178.google.com with SMTP id o10so2540989eaj.37 for ; Mon, 08 Apr 2013 12:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=Pas7GWu2V50cb+8wMdM8TFuVtq59Sy1F/WmMVmUKMjc=; b=LbAF1h9pG/H2eAm8GfEG6fCNYIQccEPnPW+LTQvl4eBzYOCdavJzOqmS8FJv0BxRLZ 4f1x5nrM8f299fcQISMiP3FGR1WC9e9UqBbTC+A/b01K2SiDnzVfU86NdfHPqHGC/N9j fOQRQmtuAx8ZfX0h73AdzTdmiz4XvxbyNN/+K+Hsnqep1r+GWxmYA6gg0MNWyf7JC6tu G1or4T2zENXSNN4BsR9p5SDB5Tsy+RVbmzbnbO79/yxKaEmpJkhmjiKAL/SbSkOiYfIL 6JeN5j2K857bxm6akBJbKS97aTPhlhHWlOQFRI1XYq6TC7ZhYHp39ZNaJYQWQiEv4ade Dl9A== X-Received: by 10.14.216.2 with SMTP id f2mr52232489eep.44.1365450797035; Mon, 08 Apr 2013 12:53:17 -0700 (PDT) Received: from localhost.localdomain (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPS id bc1sm33977743eeb.11.2013.04.08.12.53.14 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 08 Apr 2013 12:53:15 -0700 (PDT) From: Sylwester Nawrocki To: kgene.kim@samsung.com Subject: [PATCH] ARM: S3C24XX: Fix interrupt pending register offset of the EINT controller Date: Mon, 8 Apr 2013 21:53:07 +0200 Message-Id: <1365450787-14473-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.4.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130408_155319_042751_9EA28C39 X-CRM114-Status: GOOD ( 13.36 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (sylvester.nawrocki[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The external pending interrupt register address (EINTPEND) offset is 0xa8, not 0x08. Without this patch the external interrupts are not properly acknowledged, which may lead to an interrupt storm and the system hang as soon as any external interrupt is requested. Signed-off-by: Sylwester Nawrocki Reviewed-by: Heiko Stuebner --- This patch is for _3.9_. I'm going to send a similar patch for 3.10-rc2 for drivers/irqchip/irq-s3c24xx.c. --- arch/arm/mach-s3c24xx/irq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.4.1 diff --git a/arch/arm/mach-s3c24xx/irq.c b/arch/arm/mach-s3c24xx/irq.c index cb9f5e0..d8ba9be 100644 --- a/arch/arm/mach-s3c24xx/irq.c +++ b/arch/arm/mach-s3c24xx/irq.c @@ -500,7 +500,7 @@ struct s3c_irq_intc *s3c24xx_init_intc(struct device_node *np, base = (void *)0xfd000000; intc->reg_mask = base + 0xa4; - intc->reg_pending = base + 0x08; + intc->reg_pending = base + 0xa8; irq_num = 20; irq_start = S3C2410_IRQ(32); irq_offset = 4;