From patchwork Tue Apr 9 14:07:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rogerio Pimentel X-Patchwork-Id: 2415501 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork2.kernel.org (Postfix) with ESMTP id 1EBE7DF25A for ; Tue, 9 Apr 2013 14:11:53 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPZH3-0004v3-Ob; Tue, 09 Apr 2013 14:11:49 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPZH1-0003qN-E6; Tue, 09 Apr 2013 14:11:47 +0000 Received: from am1ehsobe001.messaging.microsoft.com ([213.199.154.204] helo=am1outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UPZGy-0003pv-RY for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2013 14:11:45 +0000 Received: from mail42-am1-R.bigfish.com (10.3.201.228) by AM1EHSOBE022.bigfish.com (10.3.207.144) with Microsoft SMTP Server id 14.1.225.23; Tue, 9 Apr 2013 14:11:42 +0000 Received: from mail42-am1 (localhost [127.0.0.1]) by mail42-am1-R.bigfish.com (Postfix) with ESMTP id 6DDB93400CD; Tue, 9 Apr 2013 14:11:42 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: 0 X-BigFish: VS0(zzzz1f42h1fc6h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ahzz8275bh8275dhz2dh2a8h668h839hd24he5bhf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1155h) Received: from mail42-am1 (localhost.localdomain [127.0.0.1]) by mail42-am1 (MessageSwitch) id 1365516699767327_23776; Tue, 9 Apr 2013 14:11:39 +0000 (UTC) Received: from AM1EHSMHS014.bigfish.com (unknown [10.3.201.248]) by mail42-am1.bigfish.com (Postfix) with ESMTP id B8AB03C0084; Tue, 9 Apr 2013 14:11:39 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by AM1EHSMHS014.bigfish.com (10.3.207.152) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 9 Apr 2013 14:11:38 +0000 Received: from tx30smr01.am.freescale.net (10.81.153.31) by 039-SN1MMR1-002.039d.mgd.msft.net (10.84.1.15) with Microsoft SMTP Server (TLS) id 14.2.328.11; Tue, 9 Apr 2013 14:11:36 +0000 Received: from b19259.am.freescale.net ([10.29.240.148]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id r39EBWJM028432; Tue, 9 Apr 2013 07:11:33 -0700 From: Rogerio Pimentel To: Subject: [PATCH v2 1/4] imx-drm: parallel-display: Fix valid_mode checking Date: Tue, 9 Apr 2013 11:07:29 -0300 Message-ID: <1365516452-1287-1-git-send-email-rogerio.pimentel@freescale.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130409_101145_006655_986099E6 X-CRM114-Status: GOOD ( 11.77 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [213.199.154.204 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Rogerio Pimentel , Greg Kroah-Hartman , kernel@pengutronix.de X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org It fixes the logic of valid_mode checking, it's now in accordance with drm_mode_status enumeration. Cc: Greg Kroah-Hartman Signed-off-by: Rogerio Pimentel --- Changes since v1: Removed the "if(np)" block and now using the existent functions to get the modes by fixing the mode_valid logic test drivers/staging/imx-drm/parallel-display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/imx-drm/parallel-display.c b/drivers/staging/imx-drm/parallel-display.c index a8064fc..49c90c3 100644 --- a/drivers/staging/imx-drm/parallel-display.c +++ b/drivers/staging/imx-drm/parallel-display.c @@ -64,7 +64,7 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) num_modes = drm_add_edid_modes(connector, imxpd->edid); } - if (imxpd->mode_valid) { + if (imxpd->mode_valid == MODE_OK) { struct drm_display_mode *mode = drm_mode_create(connector->dev); drm_mode_copy(mode, &imxpd->mode); mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, @@ -78,7 +78,7 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) static int imx_pd_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { - return 0; + return MODE_OK; } static struct drm_encoder *imx_pd_connector_best_encoder(