| Message ID | 1365516452-1287-3-git-send-email-rogerio.pimentel@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Dienstag, den 09.04.2013, 11:07 -0300 schrieb Rogerio Pimentel: > Add support for CLAA WVGA display for i.MX53 QSB. > > Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com> > --- > Changes since v1: > Changed the label disp1 to disp0 to correctly match the display pins > arch/arm/boot/dts/imx53-qsb.dtsp | 26 ++++++++++++++++++++++++++ > arch/arm/boot/dts/imx53.dtsip | 35 +++++++++++++++++++++++++++++++++++ > 2 files changed, 61 insertions(+) > > diff --git a/arch/arm/boot/dts/imx53-qsb.dtsp b/arch/arm/boot/dts/imx53-qsb.dtsp > index dae8d9f..6086a3c 100644 > --- a/arch/arm/boot/dts/imx53-qsb.dtsp > +++ b/arch/arm/boot/dts/imx53-qsb.dtsp > @@ -21,6 +21,32 @@ > reg = <0x70000000 0x40000000>; > }; > > + display@di0 { > + compatible = "fsl,imx-parallel-display"; > + crtcs = <&ipu 0>; > + interface-pix-fmt = "rgb565"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ipu_disp0_1>; > + display-timings { > + claawvga { > + native-mode; > + clock-frequency = <27000000>; > + hactive = <800>; > + vactive = <480>; > + hback-porch = <40>; > + hfront-porch = <60>; > + vback-porch = <10>; > + vfront-porch = <10>; > + hsync-len = <20>; > + vsync-len = <10>; > + hsync-active = <0>; > + vsync-active = <0>; > + de-active = <1>; > + pixelclk-active = <0>; > + }; > + }; > + }; > + This clashes with the MCIMXHDMICARD daughter module, which has a sii902x HDMI encoder connected to DISP0 for i.MX53-QSB. Would it make sense to add all possible options to the device tree but mark them with status = "disabled" by default? regards Philipp > gpio-keys { > compatible = "gpio-keys"; > > diff --git a/arch/arm/boot/dts/imx53.dtsip b/arch/arm/boot/dts/imx53.dtsip > index 845982e..a5f9d68 100644 > --- a/arch/arm/boot/dts/imx53.dtsip > +++ b/arch/arm/boot/dts/imx53.dtsip > @@ -444,6 +444,41 @@ > }; > }; > > + ipu_disp0 { > + pinctrl_ipu_disp0_1: ipudisp0grp-1 { > + fsl,pins = < > + MX53_PAD_DI0_DISP_CLK__IPU_DI0_DISP_CLK 0x5 > + MX53_PAD_DI0_PIN15__IPU_DI0_PIN15 0x5 > + MX53_PAD_DI0_PIN2__IPU_DI0_PIN2 0x5 > + MX53_PAD_DI0_PIN3__IPU_DI0_PIN3 0x5 > + MX53_PAD_DISP0_DAT0__IPU_DISP0_DAT_0 0x5 > + MX53_PAD_DISP0_DAT1__IPU_DISP0_DAT_1 0x5 > + MX53_PAD_DISP0_DAT2__IPU_DISP0_DAT_2 0x5 > + MX53_PAD_DISP0_DAT3__IPU_DISP0_DAT_3 0x5 > + MX53_PAD_DISP0_DAT4__IPU_DISP0_DAT_4 0x5 > + MX53_PAD_DISP0_DAT5__IPU_DISP0_DAT_5 0x5 > + MX53_PAD_DISP0_DAT6__IPU_DISP0_DAT_6 0x5 > + MX53_PAD_DISP0_DAT7__IPU_DISP0_DAT_7 0x5 > + MX53_PAD_DISP0_DAT8__IPU_DISP0_DAT_8 0x5 > + MX53_PAD_DISP0_DAT9__IPU_DISP0_DAT_9 0x5 > + MX53_PAD_DISP0_DAT10__IPU_DISP0_DAT_10 0x5 > + MX53_PAD_DISP0_DAT11__IPU_DISP0_DAT_11 0x5 > + MX53_PAD_DISP0_DAT12__IPU_DISP0_DAT_12 0x5 > + MX53_PAD_DISP0_DAT13__IPU_DISP0_DAT_13 0x5 > + MX53_PAD_DISP0_DAT14__IPU_DISP0_DAT_14 0x5 > + MX53_PAD_DISP0_DAT15__IPU_DISP0_DAT_15 0x5 > + MX53_PAD_DISP0_DAT16__IPU_DISP0_DAT_16 0x5 > + MX53_PAD_DISP0_DAT17__IPU_DISP0_DAT_17 0x5 > + MX53_PAD_DISP0_DAT18__IPU_DISP0_DAT_18 0x5 > + MX53_PAD_DISP0_DAT19__IPU_DISP0_DAT_19 0x5 > + MX53_PAD_DISP0_DAT20__IPU_DISP0_DAT_20 0x5 > + MX53_PAD_DISP0_DAT21__IPU_DISP0_DAT_21 0x5 > + MX53_PAD_DISP0_DAT22__IPU_DISP0_DAT_22 0x5 > + MX53_PAD_DISP0_DAT23__IPU_DISP0_DAT_23 0x5 > + >; > + }; > + }; > + > owire { > pinctrl_owire_1: owiregrp-1 { > fsl,pins = <
On Tue, Apr 9, 2013 at 12:17 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote: > Am Dienstag, den 09.04.2013, 11:07 -0300 schrieb Rogerio Pimentel: >> Add support for CLAA WVGA display for i.MX53 QSB. >> >> Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com> >> --- >> Changes since v1: >> Changed the label disp1 to disp0 to correctly match the display pins >> arch/arm/boot/dts/imx53-qsb.dtsp | 26 ++++++++++++++++++++++++++ >> arch/arm/boot/dts/imx53.dtsip | 35 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 61 insertions(+) >> >> diff --git a/arch/arm/boot/dts/imx53-qsb.dtsp b/arch/arm/boot/dts/imx53-qsb.dtsp >> index dae8d9f..6086a3c 100644 >> --- a/arch/arm/boot/dts/imx53-qsb.dtsp >> +++ b/arch/arm/boot/dts/imx53-qsb.dtsp >> @@ -21,6 +21,32 @@ >> reg = <0x70000000 0x40000000>; >> }; >> >> + display@di0 { >> + compatible = "fsl,imx-parallel-display"; >> + crtcs = <&ipu 0>; >> + interface-pix-fmt = "rgb565"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_ipu_disp0_1>; >> + display-timings { >> + claawvga { >> + native-mode; >> + clock-frequency = <27000000>; >> + hactive = <800>; >> + vactive = <480>; >> + hback-porch = <40>; >> + hfront-porch = <60>; >> + vback-porch = <10>; >> + vfront-porch = <10>; >> + hsync-len = <20>; >> + vsync-len = <10>; >> + hsync-active = <0>; >> + vsync-active = <0>; >> + de-active = <1>; >> + pixelclk-active = <0>; >> + }; >> + }; >> + }; >> + > > This clashes with the MCIMXHDMICARD daughter module, which has a sii902x > HDMI encoder connected to DISP0 for i.MX53-QSB. Would it make sense to > add all possible options to the device tree but mark them with > status = "disabled" by default? > > regards > Philipp > I'm planning to add support for MCIMXHDMICARD later because it will also require support for sii902x. I'd like to add the parallel display that we have available today and after that add the support for sii902x. What do you think? Rgds Rogerio >> gpio-keys { >> compatible = "gpio-keys"; >> >> diff --git a/arch/arm/boot/dts/imx53.dtsip b/arch/arm/boot/dts/imx53.dtsip >> index 845982e..a5f9d68 100644 >> --- a/arch/arm/boot/dts/imx53.dtsip >> +++ b/arch/arm/boot/dts/imx53.dtsip >> @@ -444,6 +444,41 @@ >> }; >> }; >> >> + ipu_disp0 { >> + pinctrl_ipu_disp0_1: ipudisp0grp-1 { >> + fsl,pins = < >> + MX53_PAD_DI0_DISP_CLK__IPU_DI0_DISP_CLK 0x5 >> + MX53_PAD_DI0_PIN15__IPU_DI0_PIN15 0x5 >> + MX53_PAD_DI0_PIN2__IPU_DI0_PIN2 0x5 >> + MX53_PAD_DI0_PIN3__IPU_DI0_PIN3 0x5 >> + MX53_PAD_DISP0_DAT0__IPU_DISP0_DAT_0 0x5 >> + MX53_PAD_DISP0_DAT1__IPU_DISP0_DAT_1 0x5 >> + MX53_PAD_DISP0_DAT2__IPU_DISP0_DAT_2 0x5 >> + MX53_PAD_DISP0_DAT3__IPU_DISP0_DAT_3 0x5 >> + MX53_PAD_DISP0_DAT4__IPU_DISP0_DAT_4 0x5 >> + MX53_PAD_DISP0_DAT5__IPU_DISP0_DAT_5 0x5 >> + MX53_PAD_DISP0_DAT6__IPU_DISP0_DAT_6 0x5 >> + MX53_PAD_DISP0_DAT7__IPU_DISP0_DAT_7 0x5 >> + MX53_PAD_DISP0_DAT8__IPU_DISP0_DAT_8 0x5 >> + MX53_PAD_DISP0_DAT9__IPU_DISP0_DAT_9 0x5 >> + MX53_PAD_DISP0_DAT10__IPU_DISP0_DAT_10 0x5 >> + MX53_PAD_DISP0_DAT11__IPU_DISP0_DAT_11 0x5 >> + MX53_PAD_DISP0_DAT12__IPU_DISP0_DAT_12 0x5 >> + MX53_PAD_DISP0_DAT13__IPU_DISP0_DAT_13 0x5 >> + MX53_PAD_DISP0_DAT14__IPU_DISP0_DAT_14 0x5 >> + MX53_PAD_DISP0_DAT15__IPU_DISP0_DAT_15 0x5 >> + MX53_PAD_DISP0_DAT16__IPU_DISP0_DAT_16 0x5 >> + MX53_PAD_DISP0_DAT17__IPU_DISP0_DAT_17 0x5 >> + MX53_PAD_DISP0_DAT18__IPU_DISP0_DAT_18 0x5 >> + MX53_PAD_DISP0_DAT19__IPU_DISP0_DAT_19 0x5 >> + MX53_PAD_DISP0_DAT20__IPU_DISP0_DAT_20 0x5 >> + MX53_PAD_DISP0_DAT21__IPU_DISP0_DAT_21 0x5 >> + MX53_PAD_DISP0_DAT22__IPU_DISP0_DAT_22 0x5 >> + MX53_PAD_DISP0_DAT23__IPU_DISP0_DAT_23 0x5 >> + >; >> + }; >> + }; >> + >> owire { >> pinctrl_owire_1: owiregrp-1 { >> fsl,pins = < > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Fri, Apr 12, 2013 at 03:49:09PM -0300, Rogerio Pimentel wrote: > On Tue, Apr 9, 2013 at 12:17 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote: > > Am Dienstag, den 09.04.2013, 11:07 -0300 schrieb Rogerio Pimentel: > >> Add support for CLAA WVGA display for i.MX53 QSB. > >> > >> Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com> > >> --- > >> Changes since v1: > >> Changed the label disp1 to disp0 to correctly match the display pins > >> arch/arm/boot/dts/imx53-qsb.dtsp | 26 ++++++++++++++++++++++++++ > >> arch/arm/boot/dts/imx53.dtsip | 35 +++++++++++++++++++++++++++++++++++ > >> 2 files changed, 61 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx53-qsb.dtsp b/arch/arm/boot/dts/imx53-qsb.dtsp > >> index dae8d9f..6086a3c 100644 > >> --- a/arch/arm/boot/dts/imx53-qsb.dtsp > >> +++ b/arch/arm/boot/dts/imx53-qsb.dtsp > >> @@ -21,6 +21,32 @@ > >> reg = <0x70000000 0x40000000>; > >> }; > >> > >> + display@di0 { > >> + compatible = "fsl,imx-parallel-display"; > >> + crtcs = <&ipu 0>; > >> + interface-pix-fmt = "rgb565"; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_ipu_disp0_1>; > >> + display-timings { > >> + claawvga { > >> + native-mode; > >> + clock-frequency = <27000000>; > >> + hactive = <800>; > >> + vactive = <480>; > >> + hback-porch = <40>; > >> + hfront-porch = <60>; > >> + vback-porch = <10>; > >> + vfront-porch = <10>; > >> + hsync-len = <20>; > >> + vsync-len = <10>; > >> + hsync-active = <0>; > >> + vsync-active = <0>; > >> + de-active = <1>; > >> + pixelclk-active = <0>; > >> + }; > >> + }; > >> + }; > >> + > > > > This clashes with the MCIMXHDMICARD daughter module, which has a sii902x > > HDMI encoder connected to DISP0 for i.MX53-QSB. Would it make sense to > > add all possible options to the device tree but mark them with > > status = "disabled" by default? > > > > regards > > Philipp > > > I'm planning to add support for MCIMXHDMICARD later because it will also > require support for sii902x. I'd like to add the parallel display that > we have available > today and after that add the support for sii902x. What do you think? Having the parallel display support is fine. Philipp just suggested to add status = "disabled" for both the parallel display and the lvds encoder so that for example the bootloader can decide which one to enable during runtime. Otherwise we have two display options on the same pins and the first one wins. Sascha
Am Freitag, den 12.04.2013, 15:49 -0300 schrieb Rogerio Pimentel: > On Tue, Apr 9, 2013 at 12:17 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote: > > Am Dienstag, den 09.04.2013, 11:07 -0300 schrieb Rogerio Pimentel: > >> Add support for CLAA WVGA display for i.MX53 QSB. > >> > >> Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com> > >> --- > >> Changes since v1: > >> Changed the label disp1 to disp0 to correctly match the display pins > >> arch/arm/boot/dts/imx53-qsb.dtsp | 26 ++++++++++++++++++++++++++ > >> arch/arm/boot/dts/imx53.dtsip | 35 +++++++++++++++++++++++++++++++++++ > >> 2 files changed, 61 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/imx53-qsb.dtsp b/arch/arm/boot/dts/imx53-qsb.dtsp > >> index dae8d9f..6086a3c 100644 > >> --- a/arch/arm/boot/dts/imx53-qsb.dtsp > >> +++ b/arch/arm/boot/dts/imx53-qsb.dtsp > >> @@ -21,6 +21,32 @@ > >> reg = <0x70000000 0x40000000>; > >> }; > >> > >> + display@di0 { > >> + compatible = "fsl,imx-parallel-display"; > >> + crtcs = <&ipu 0>; > >> + interface-pix-fmt = "rgb565"; > >> + pinctrl-names = "default"; > >> + pinctrl-0 = <&pinctrl_ipu_disp0_1>; > >> + display-timings { > >> + claawvga { > >> + native-mode; > >> + clock-frequency = <27000000>; > >> + hactive = <800>; > >> + vactive = <480>; > >> + hback-porch = <40>; > >> + hfront-porch = <60>; > >> + vback-porch = <10>; > >> + vfront-porch = <10>; > >> + hsync-len = <20>; > >> + vsync-len = <10>; > >> + hsync-active = <0>; > >> + vsync-active = <0>; > >> + de-active = <1>; > >> + pixelclk-active = <0>; > >> + }; > >> + }; > >> + }; > >> + > > > > This clashes with the MCIMXHDMICARD daughter module, which has a sii902x > > HDMI encoder connected to DISP0 for i.MX53-QSB. Would it make sense to > > add all possible options to the device tree but mark them with > > status = "disabled" by default? > > > > regards > > Philipp > > > I'm planning to add support for MCIMXHDMICARD later because it will also > require support for sii902x. That's good to hear. We have some (very) work-in-progress sii902x driver patches floating around, if you are interested. > I'd like to add the parallel display that > we have available > today and after that add the support for sii902x. What do you think? As Sascha said, I'm in favor of adding the parallel display support now, but with the status = "disabled" property in there. Then anybody who has the CLAAWVGA display can just set status = "okay" manually at build time or from the bootloader. regards Philipp
Sascha/Phillip, On Sat, Apr 13, 2013 at 2:09 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > Having the parallel display support is fine. Philipp just suggested to > add status = "disabled" for both the parallel display and the lvds > encoder so that for example the bootloader can decide which one to enable > during runtime. Otherwise we have two display options on the same pins and > the first one wins. Ok, understood. It is not clear how we can tell the bootloader that we want the CLAA WVGA panel or the HDMI daughter card, for example? What would be the kernel command line in each case? Thanks, Fabio Estevam
On Mon, Apr 15, 2013 at 09:18:35PM -0300, Fabio Estevam wrote: > Sascha/Phillip, > > On Sat, Apr 13, 2013 at 2:09 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote: > > > Having the parallel display support is fine. Philipp just suggested to > > add status = "disabled" for both the parallel display and the lvds > > encoder so that for example the bootloader can decide which one to enable > > during runtime. Otherwise we have two display options on the same pins and > > the first one wins. > > Ok, understood. > > It is not clear how we can tell the bootloader that we want the CLAA > WVGA panel or the HDMI daughter card, for example? In barebox we would do a 'of_property -s /soc/display@di0 status okay'. I don't know the corresponding U-Boot command. > > What would be the kernel command line in each case? Ther kernel command line is not involved here. Sascha
diff --git a/arch/arm/boot/dts/imx53-qsb.dtsp b/arch/arm/boot/dts/imx53-qsb.dtsp index dae8d9f..6086a3c 100644 --- a/arch/arm/boot/dts/imx53-qsb.dtsp +++ b/arch/arm/boot/dts/imx53-qsb.dtsp @@ -21,6 +21,32 @@ reg = <0x70000000 0x40000000>; }; + display@di0 { + compatible = "fsl,imx-parallel-display"; + crtcs = <&ipu 0>; + interface-pix-fmt = "rgb565"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ipu_disp0_1>; + display-timings { + claawvga { + native-mode; + clock-frequency = <27000000>; + hactive = <800>; + vactive = <480>; + hback-porch = <40>; + hfront-porch = <60>; + vback-porch = <10>; + vfront-porch = <10>; + hsync-len = <20>; + vsync-len = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; + }; + }; + gpio-keys { compatible = "gpio-keys"; diff --git a/arch/arm/boot/dts/imx53.dtsip b/arch/arm/boot/dts/imx53.dtsip index 845982e..a5f9d68 100644 --- a/arch/arm/boot/dts/imx53.dtsip +++ b/arch/arm/boot/dts/imx53.dtsip @@ -444,6 +444,41 @@ }; }; + ipu_disp0 { + pinctrl_ipu_disp0_1: ipudisp0grp-1 { + fsl,pins = < + MX53_PAD_DI0_DISP_CLK__IPU_DI0_DISP_CLK 0x5 + MX53_PAD_DI0_PIN15__IPU_DI0_PIN15 0x5 + MX53_PAD_DI0_PIN2__IPU_DI0_PIN2 0x5 + MX53_PAD_DI0_PIN3__IPU_DI0_PIN3 0x5 + MX53_PAD_DISP0_DAT0__IPU_DISP0_DAT_0 0x5 + MX53_PAD_DISP0_DAT1__IPU_DISP0_DAT_1 0x5 + MX53_PAD_DISP0_DAT2__IPU_DISP0_DAT_2 0x5 + MX53_PAD_DISP0_DAT3__IPU_DISP0_DAT_3 0x5 + MX53_PAD_DISP0_DAT4__IPU_DISP0_DAT_4 0x5 + MX53_PAD_DISP0_DAT5__IPU_DISP0_DAT_5 0x5 + MX53_PAD_DISP0_DAT6__IPU_DISP0_DAT_6 0x5 + MX53_PAD_DISP0_DAT7__IPU_DISP0_DAT_7 0x5 + MX53_PAD_DISP0_DAT8__IPU_DISP0_DAT_8 0x5 + MX53_PAD_DISP0_DAT9__IPU_DISP0_DAT_9 0x5 + MX53_PAD_DISP0_DAT10__IPU_DISP0_DAT_10 0x5 + MX53_PAD_DISP0_DAT11__IPU_DISP0_DAT_11 0x5 + MX53_PAD_DISP0_DAT12__IPU_DISP0_DAT_12 0x5 + MX53_PAD_DISP0_DAT13__IPU_DISP0_DAT_13 0x5 + MX53_PAD_DISP0_DAT14__IPU_DISP0_DAT_14 0x5 + MX53_PAD_DISP0_DAT15__IPU_DISP0_DAT_15 0x5 + MX53_PAD_DISP0_DAT16__IPU_DISP0_DAT_16 0x5 + MX53_PAD_DISP0_DAT17__IPU_DISP0_DAT_17 0x5 + MX53_PAD_DISP0_DAT18__IPU_DISP0_DAT_18 0x5 + MX53_PAD_DISP0_DAT19__IPU_DISP0_DAT_19 0x5 + MX53_PAD_DISP0_DAT20__IPU_DISP0_DAT_20 0x5 + MX53_PAD_DISP0_DAT21__IPU_DISP0_DAT_21 0x5 + MX53_PAD_DISP0_DAT22__IPU_DISP0_DAT_22 0x5 + MX53_PAD_DISP0_DAT23__IPU_DISP0_DAT_23 0x5 + >; + }; + }; + owire { pinctrl_owire_1: owiregrp-1 { fsl,pins = <
Add support for CLAA WVGA display for i.MX53 QSB. Signed-off-by: Rogerio Pimentel <rogerio.pimentel@freescale.com> --- Changes since v1: Changed the label disp1 to disp0 to correctly match the display pins arch/arm/boot/dts/imx53-qsb.dtsp | 26 ++++++++++++++++++++++++++ arch/arm/boot/dts/imx53.dtsip | 35 +++++++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+)